wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-07-05 14:00:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix from review

Browse Source
This commit is contained in:
Eric Blankenhorn
2026-06-08 09:48:16 -05:00
parent 9f7c536e23
commit 8eaebaa7e8
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wolfcrypt/src/pkcs7.c
+5 -3
View File
@@ -1671,9 +1671,11 @@ static int EncodeAttributes(EncodedAttrib* ea, int eaSz,
ea[i].totalSz = attribSz;
/* Keep the running total within positive int range so callers can
* distinguish a valid size (>= 0) from a negative error return. */
if (attribSz > (WOLFSSL_MAX_32BIT >> 1) ||
(word32)allAttribsSz > (WOLFSSL_MAX_32BIT >> 1) - attribSz) {
* distinguish a valid size (>= 0) from a negative error return. Bound
* against the build's actual int maximum rather than assuming 32-bit
* int, so the (int) cast below cannot overflow on narrow-int targets. */
if (attribSz > (word32)WC_MAX_SINT_OF(int) ||
(word32)allAttribsSz > (word32)WC_MAX_SINT_OF(int) - attribSz) {
WOLFSSL_MSG("PKCS7 attributes total size overflow");
return BUFFER_E;
}