wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-31 19:24:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8962 from rlm2002/coverity

Browse Source 
Coverity: Dereference after NULL check and Use after free
This commit is contained in:
Sean Parkinson
2025-07-08 08:30:35 +10:00
committed by GitHub
parent a40b56ccb5 de59e9d25e
commit 9b92b4c902
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/internal.c
View File

@@ -6468,6 +6468,10 @@ int DhGenKeyPair(WOLFSSL* ssl, DhKey* dhKey,
WOLFSSL_ENTER("DhGenKeyPair");
if (ssl == NULL || dhKey == NULL) {
return BAD_FUNC_ARG;
}
#ifdef WOLFSSL_ASYNC_CRYPT
/* initialize event */
ret = wolfSSL_AsyncInit(ssl, &dhKey->asyncDev, WC_ASYNC_FLAG_NONE);

10
tests/api.c
View File

@@ -19598,6 +19598,9 @@ static int test_wolfSSL_d2i_ASN1_INTEGER(void)
a->isDynamic = 0;
a->data = a->intData;
}
/* Reset p2 to NULL. */
XFREE(p2, NULL, DYNAMIC_TYPE_ASN1);
/* Set a to valid value. */
ExpectIntEQ(wolfSSL_ASN1_INTEGER_set(a, 1), WOLFSSL_SUCCESS);
/* NULL output buffer. */
@@ -19637,7 +19640,6 @@ static int test_wolfSSL_d2i_ASN1_INTEGER(void)
reEncoded = NULL;
wolfSSL_ASN1_INTEGER_free(a);
a = NULL;
p2 = NULL;
}
#endif /* OPENSSL_EXTRA */
return EXPECT_RESULT();
@@ -38171,7 +38173,8 @@ static int test_wolfSSL_BIO_write(void)
ExpectNotNull(bio64 = BIO_new(BIO_f_base64()));
ExpectNotNull(bio = BIO_push(BIO_new(BIO_f_base64()), bio64));
if (EXPECT_FAIL()) {
BIO_free(bio64);
BIO_free_all(bio);
bio = NULL;
bio64 = NULL;
}
ExpectNotNull(bio_mem = BIO_new(BIO_s_mem()));
@@ -38181,6 +38184,9 @@ static int test_wolfSSL_BIO_write(void)
}
/* now should convert to base64 when stored and then decode with read */
if (bio == NULL) {
ExpectNotNull(bio = BIO_new(BIO_f_base64()));
}
ExpectIntEQ(BIO_write(bio, msg, sizeof(msg)), 25);
BIO_flush(bio);
sz = sizeof(out);