wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-08-13 08:21:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: cover the AES-EAX streaming Update authIn arg-check

Browse Source 
test_wc_AesEaxArgMcdc exercised the eax/out/in operands of
wc_AesEaxEncryptUpdate / wc_AesEaxDecryptUpdate but always passed
(authIn=NULL, authInSz=0), so the guard's authInSz>0 && authIn==NULL
term was never evaluated with authInSz>0 -- leaving those two
conditions (and their decrypt twins) uncovered in the MC/DC union.

Add, for both Update functions, the (authIn==NULL, authInSz>0) row
(rejected with BAD_FUNC_ARG) and the (authIn!=NULL, authInSz>0) row
(accepted), completing both conditions' independence pairs.

These four conditions were the only uncovered code the recent
master merge (AES-GCM-SIV, AES-OFB/CFB callbacks) added to aes.c that
was reachable from tests/api; closes them so the aes.c union returns
to its residual-only gap (410/445, gap 35).
This commit is contained in:
Daniele Lacamera
2026-07-13 11:19:23 +02:00
parent c1bb056552
commit a453136cc9
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api/test_aes.c
+14
View File
@@ -8076,6 +8076,14 @@ int test_wc_AesEaxArgMcdc(void)
/* cond: in == NULL */
ExpectIntEQ(wc_AesEaxEncryptUpdate(&eax, out, NULL, sizeof(in), NULL, 0),
WC_NO_ERR_TRACE(BAD_FUNC_ARG));
/* cond: authInSz > 0 && authIn == NULL -> BAD_FUNC_ARG (both the
* authInSz>0 and authIn==NULL conditions true). */
ExpectIntEQ(wc_AesEaxEncryptUpdate(&eax, out, in, sizeof(in), NULL,
sizeof(in)), WC_NO_ERR_TRACE(BAD_FUNC_ARG));
/* cond: authInSz > 0 && authIn != NULL -> valid (authIn==NULL false while
* authInSz>0 true), completing that pair. */
ExpectIntEQ(wc_AesEaxEncryptUpdate(&eax, out, in, sizeof(in), in,
sizeof(in)), 0);
ExpectIntEQ(wc_AesEaxFree(&eax), 0);
/* ---- wc_AesEaxDecryptUpdate(): eax/out/in OR-chain ---- */
@@ -8093,6 +8101,12 @@ int test_wc_AesEaxArgMcdc(void)
/* cond: in == NULL */
ExpectIntEQ(wc_AesEaxDecryptUpdate(&eax, out, NULL, sizeof(in), NULL, 0),
WC_NO_ERR_TRACE(BAD_FUNC_ARG));
/* cond: authInSz > 0 && authIn == NULL -> BAD_FUNC_ARG. */
ExpectIntEQ(wc_AesEaxDecryptUpdate(&eax, out, in, sizeof(in), NULL,
sizeof(in)), WC_NO_ERR_TRACE(BAD_FUNC_ARG));
/* cond: authInSz > 0 && authIn != NULL -> valid, completing the pair. */
ExpectIntEQ(wc_AesEaxDecryptUpdate(&eax, out, in, sizeof(in), in,
sizeof(in)), 0);
ExpectIntEQ(wc_AesEaxFree(&eax), 0);
/* ---- wc_AesEaxEncryptFinal(): authTag == NULL / authTagSz == 0 ---- */