wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-31 19:24:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

DSA: Don't force zero MPs on memory allocation failure

Browse Source 
When memory allocation fails, the MPs are not initialized and force zero
is using invalid values.
This commit is contained in:
Sean Parkinson
2023-01-23 08:33:09 +10:00
parent a40da56f11
commit ffe302025e
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
wolfcrypt/src/dsa.c
View File

@@ -927,33 +927,33 @@ int wc_DsaSign(const byte* digest, byte* out, DsaKey* key, WC_RNG* rng)
#ifdef WOLFSSL_SMALL_STACK
if (k) {
if (ret != MP_INIT_E)
if ((ret != MP_INIT_E) && (ret != MEMORY_E))
mp_forcezero(k);
XFREE(k, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
}
if (kInv) {
if (ret != MP_INIT_E)
if ((ret != MP_INIT_E) && (ret != MEMORY_E))
mp_forcezero(kInv);
XFREE(kInv, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
}
if (r) {
if (ret != MP_INIT_E)
if ((ret != MP_INIT_E) && (ret != MEMORY_E))
mp_clear(r);
XFREE(r, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
}
if (s) {
if (ret != MP_INIT_E)
if ((ret != MP_INIT_E) && (ret != MEMORY_E))
mp_clear(s);
XFREE(s, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
}
if (H) {
if (ret != MP_INIT_E)
if ((ret != MP_INIT_E) && (ret != MEMORY_E))
mp_clear(H);
XFREE(H, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
}
#ifndef WOLFSSL_MP_INVMOD_CONSTANT_TIME
if (b) {
if (ret != MP_INIT_E)
if ((ret != MP_INIT_E) && (ret != MEMORY_E))
mp_forcezero(b);
XFREE(b, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
}