Increased coverage of ConverterImpl.hpp

This commit is contained in:
Benoit Blanchon
2021-04-18 17:23:51 +02:00
parent 64e52e97ee
commit d8a1d1a120
2 changed files with 26 additions and 1 deletions

View File

@ -67,4 +67,30 @@ TEST_CASE("JsonVariant undefined") {
REQUIRE(variant.is<JsonObject>() == false);
}
}
SECTION("set<T>()") {
SECTION("long") {
REQUIRE(variant.set(42L) == false);
}
SECTION("unsigned") {
REQUIRE(variant.set(42U) == false);
}
SECTION("const char*") {
REQUIRE(variant.set("42") == false);
}
SECTION("Serialized<const char*>") {
REQUIRE(variant.set(serialized("42")) == false);
}
SECTION("double") {
REQUIRE(variant.set(42.0) == false);
}
SECTION("bool") {
REQUIRE(variant.set(true) == false);
}
}
}

View File

@ -121,7 +121,6 @@ struct Converter<T, typename enable_if<is_floating_point<T>::value>::type> {
template <>
struct Converter<const char*> {
static bool toJson(VariantRef variant, const char* value) {
// TODO: don't pass pool
return variantSetString(getData(variant), adaptString(value),
getPool(variant));
}