feedc0de/esp-gui-lib
1
0
Fork 0
Code Issues 6 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Implemented basic keyboard #18

Merged
CommanderRedYT merged 9 commits from keyboard into main 2022-06-14 13:56:33 +02:00
Conversation 4 Commits 9 Files Changed 11 +444 -54
CommanderRedYT commented 2022-06-13 18:03:28 +02:00 (Migrated from github.com)
Copy Link

Implemented a keyboard for string input & some UI adjustments

Implemented a keyboard for string input & some UI adjustments
CommanderRedYT commented 2022-06-13 18:03:47 +02:00 (Migrated from github.com)
Copy Link

ToDo: Fix vertical mode

ToDo: Fix vertical mode
CommanderRedYT commented 2022-06-13 18:04:27 +02:00 (Migrated from github.com)
Copy Link

@0xFEEDC0DE64 Can you review everything now so that I can fix everything and fix vertical mode at the same time?

@0xFEEDC0DE64 Can you review everything now so that I can fix everything and fix vertical mode at the same time?
0xFEEDC0DE64 (Migrated from github.com) requested changes 2022-06-14 11:22:02 +02:00
src/changevaluedisplay.cpp
0xFEEDC0DE64 (Migrated from github.com) commented 2022-06-14 11:18:15 +02:00
Copy Link

use my float text renderer

use my float text renderer
0xFEEDC0DE64 (Migrated from github.com) commented 2022-06-14 11:18:34 +02:00
Copy Link

(ok refactoring is huge, do it in the next pull request)

(ok refactoring is huge, do it in the next pull request)
src/changevaluedisplay_chrono.h
0xFEEDC0DE64 (Migrated from github.com) commented 2022-06-14 11:18:53 +02:00
Copy Link

saaaaaimme

saaaaaimme
src/keyboardhelper.h
0xFEEDC0DE64 (Migrated from github.com) commented 2022-06-14 11:21:43 +02:00
Copy Link

wenn impl schon im header sein muss, dann zumindest bitte unter der klasse und nicht inline in der klasse. macht zb größe abschätzen unmöglich ohne millionen zeilen zu lesen

wenn impl schon im header sein muss, dann zumindest bitte unter der klasse und nicht inline in der klasse. macht zb größe abschätzen unmöglich ohne millionen zeilen zu lesen
0xFEEDC0DE64 (Migrated from github.com) approved these changes 2022-06-14 13:56:22 +02:00
src/keyboardhelper.h
0xFEEDC0DE64 (Migrated from github.com) commented 2022-06-14 13:50:17 +02:00
Copy Link

futsch oida

futsch oida
Sign in to join this conversation.
Reviewers
No Reviewers
0xFEEDC0DE64
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
feedc0de
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: feedc0de/esp-gui-lib#18
No description provided.
Delete Branch "keyboard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?