Commit Graph
10581 Commits
Author SHA1 Message Date
Travis Nielsen 22b95dbbfd Merge pull request #12977 from anthonyeleven/improve-csi-addons
12976 : Improve Documentation/Storage-Configuration/Ceph-CSI/ceph-csi…
2023-12-04 10:10:52 -07:00
Alexander Trost 3097455d78 Merge pull request #13246 from koor-tech/ceph_config_via_cluster_crd_impl
operator: allow setting ceph config options via ceph cluster crd
2023-12-02 11:27:20 +01:00
Travis Nielsen 55b6a37989 Merge pull request #13311 from travisn/mergify-1.13
ci: Mergify rules for release-1.13
2023-12-01 16:15:16 -07:00
Anthony D'Atri 59d0240676 doc: improve ceph-csi-drivers.md and lintrolling
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2023-12-01 16:10:11 -07:00
Alexander Trost 4ed35d6bd6 operator: allow setting ceph config options via ceph cluster crd
This implements the "Ceph Config via Ceph Cluster CRD" design document
as a `cephConfig:` structure on the CRD.
This also fixes the `yq` commands used to manipulate the
`cluster-test.yaml` that caused CI issues for this PR and potentially
unknowingly others.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2023-12-02 00:05:48 +01:00
travisn ec2136a507 ci: mergify rules for 1.13
Add mergify rules for opening backport PRs to the release-1.13
branch and also for auto-merging backports after the CI
passes.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-12-01 15:09:10 -07:00
Travis Nielsen 25f5a23072 Merge pull request #13196 from parth-gr/external-rados
external: add support for rados namespace for external cluster
v1.13.0-alpha.0
2023-12-01 12:21:25 -07:00
Blaine Gardner 20ce9da197 Merge pull request #13177 from subhamkrai/add-cel
webhook: add validating admission policy
2023-12-01 09:56:03 -07:00
Blaine Gardner f4d67fd4db Merge pull request #13261 from subhamkrai/remove-controller-runtime
core: remove webhook & controller-runtime from apis
2023-12-01 09:55:34 -07:00
subhamkrai ae15604fbe webhook: add validating admission policy
this commit adds validating admission policy
for cephcluster cr according to webhook rules.
Not all the webhook can be moved to validating
admission policy for example checking multus
selector validation.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-12-01 22:01:12 +05:30
Travis Nielsen eacc7e7441 Merge pull request #13305 from Rakshith-R/fix-codegen
build: missing DeepCopy code for CSIDriverSpec
2023-12-01 07:11:16 -07:00
Rakshith R 1153c10ce3 build: missing DeepCopy code for CSIDriverSpec
There was a missing codegen deep copy
by running `make codegen` it updated it

Signed-off-by: Rakshith R <rar@redhat.com>
2023-12-01 15:29:49 +05:30
subhamkrai 28cc1ebc55 core: remove webhook & controller-runtime from apis
This commits removes controller-runtime dependencies
from the apis dir and to achieve that we are removing
webhook.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-12-01 14:15:40 +05:30
Travis Nielsen 09844e83a5 Merge pull request #13288 from travisn/helm-operator-ns
helm: Add namespace to all resource templates
2023-11-30 11:52:06 -07:00
Travis Nielsen 1efb694050 Merge pull request #13266 from parth-gr/svg-name
subvolumegroup: add name spec in subvolumegroup CRD
2023-11-30 10:16:40 -07:00
Travis Nielsen e391dea1f5 Merge pull request #13222 from obnoxxx/mgr-update-fix
mgr: honor the ContinueUpgradeAfterChecksEvenIfNotHealthy flag
2023-11-30 09:58:47 -07:00
Blaine Gardner d7b06ba69f Merge pull request #13293 from rkachach/fix_issue_dashboard_ipaddr
test: fix how we obtain the dashboard endpoint
2023-11-30 08:42:35 -07:00
parth-gr 939a1b7d20 subvolumegroup: add name spec in subvolumegroup
Originally we create it using this cmd
ceph fs subvolume create <vol_name> <subvol_name>
So we can have 2 variables filesystem and subvolume name,
Currently the CR doesn't allow us to make subvolume-name
as constant as needed to "csi" because of k8s limitations

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-30 20:39:11 +05:30
Redouane Kachach b739f29bc8 test: fix how we obtain the dashboard endpoint
current code gets the ip:port for the dashboard by using
the ip of the mgr pods. This works great when there's only
one mgr but it fails in case of a multi-node cluster

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-30 11:26:48 +01:00
Travis Nielsen ee14ecb5a7 Merge pull request #13281 from subhamkrai/add-callback-osd-removal
osd: add callback function in osd removal
2023-11-29 23:13:12 -07:00
subhamkrai 927af7c7f7 osd: add callback function in osd removal
Adding callback function in the osd removal method
as in downstream there is requirement of adding extra
check before proceeding with osd removal.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-11-30 10:48:24 +05:30
travisn b4e51f6d12 helm: add namespace to all resource templates
The helm templates assumed that the resources would be installed
to the given namespace for the helm install or upgrade. This works
perfectly until there is a desire to extract the manifests from
the helm chart and instead install with those. Thus, the namespace
is added to all the resources in the chart where they were
missing.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-11-29 15:13:13 -07:00
Michael Adam a40f305d5e ci: add "k8sutil" to the allowed commit prefixes
It was somewhat difficult to find an appropriate and allowed commit
prefix for changes to the k8sutil package. This changes removes this
problem by addink "k8sutil" to the list of allowed prefixes in our
commitlint configuration

Signed-off-by: Michael Adam <obnox@samba.org>
2023-11-29 20:23:25 +01:00
Michael Adam 93bf6540b2 mgr: honor the ContinueUpgradeAfterChecksEvenIfNotHealthy flag
Fixes: #13167

Previously, the mgr did not honor the flag
ContinueUpgradeAfterChecksEvenIfNotHealthy
from the cluster spec. Only osd, mds, and rgw did.

To render the update behavior correct and complete across the daemons, this
change implements the honoring of the flag for the mgr.

Signed-off-by: Michael Adam <obnox@samba.org>
2023-11-29 20:23:25 +01:00
Travis Nielsen a19860bab0 Merge pull request #13200 from Rakshith-R/CSIDriverOptions
csi: add CSIDriverOptions section in cephCluster CR
2023-11-29 08:04:34 -07:00
Rakshith R 59cb0dd4bf csi: add CSIDriverOptions section in cephCluster CR
This commit adds new CSIDriverOptions section in
cephCluster CR. This section contains settings
for read affinity and kernel+fuse Mount options
These settings will be injected directly into
rook-ceph-csi-config cm to be applicable per
ceph cluster.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-11-29 19:34:28 +05:30
Travis Nielsen 580760c8d3 Merge pull request #13282 from parth-gr/fix-codegen
build: fix codegen in master branch
2023-11-28 11:31:15 -07:00
parth-gr 1c2c82a602 build: fix codegen in master branch
there was a missing codegen deep copy
by running `make codegen` it updated it

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-28 12:55:48 +05:30
parth-gr df7c401d35 external: add support for rados namespace for external cluster
change the json output of storageclass to also inclusde rados namespace,
and also added the changes in the csi secret

Signed-off-by: parth-gr <paarora@redhat.com>
2023-11-28 11:52:30 +05:30
Travis Nielsen d1c4667c8b Merge pull request #13225 from ushitora-anqou/use-regex-match-for-pdb-reset
core: add pgHealthyRegex to DisruptionManagementSpec
2023-11-27 14:23:25 -07:00
Travis Nielsen 474f457163 Merge pull request #13252 from rook/dependabot/go_modules/github.com/go-jose/go-jose/v3-3.0.1
build(deps): bump github.com/go-jose/go-jose/v3 from 3.0.0 to 3.0.1
2023-11-27 10:41:46 -07:00
dependabot[bot] 9433f26d2d build(deps): bump github.com/go-jose/go-jose/v3 from 3.0.0 to 3.0.1
Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Changelog](https://github.com/go-jose/go-jose/blob/v3/CHANGELOG.md)
- [Commits](https://github.com/go-jose/go-jose/compare/v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-27 10:05:41 -07:00
Travis Nielsen 94060b3433 Merge pull request #13238 from rkachach/fix_issue_adding_ns_support
test: adding support to specify the operator and cluster namepaces
2023-11-27 10:02:43 -07:00
Travis Nielsen 49c4163b32 Merge pull request #13256 from rkachach/fix_issue_radosgw_admin
mgr: adding CEPH_ARGS to the mgr pod so radosgw-admin can use it
2023-11-27 10:01:12 -07:00
Travis Nielsen bdad85f46f Merge pull request #13273 from rook/dependabot/go_modules/github-dependencies-4adff8e93d
build(deps): bump the github-dependencies group with 1 update
2023-11-27 07:47:54 -07:00
Travis Nielsen e1d87471d5 Merge pull request #13265 from weirdwiz/exporter-deployment
exporter: change deployment strategy to Recreate
2023-11-27 07:45:09 -07:00
dependabot[bot] eee1a1b1bf build(deps): bump the github-dependencies group with 1 update
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).

- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.48.0...v1.48.4)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-27 12:42:48 +00:00
Divyansh Kamboj f9d6cd7f3a exporter: change deployment strategy to Recreate
Restarting the exporter using RollingRelease causes a race condition,
that results in exporter crashing and the ceph health to show a warning.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
2023-11-27 15:20:25 +05:30
Satoru Takeuchi 4e58be48c3 Merge pull request #13259 from cybozu-go/osd-revert-encrypted-osd-on-part
helm: use csiaddonsport parameter
2023-11-24 14:10:37 +09:00
Satoru Takeuchi 1d8cdeca03 helm: use csiaddonsport correctly
We have csi.csiAddonsPort paramete but it's not used everywhere.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2023-11-24 02:30:08 +00:00
Redouane Kachach 734d105790 test: applying adding rbac.yaml when enabling monitoring
applying adding rbac.yaml when enabling monitoring to avoid
permission issues when accessing servicemonitors

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 16:38:12 +01:00
Redouane Kachach f60cdde460 test: increasing rook-ceph-tools deployment timeout to 90s
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 16:37:01 +01:00
Redouane Kachach f93532a8e4 test: adding support to specify the operator and cluster namepaces
adding support to specify operator and cluster namespaces through new
command-line arguments: -c for cluster and -o for operator. The script
will automatically update the namespace in the corresponding YAML files

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 13:48:06 +01:00
Redouane Kachach afc485fa03 mgr: adding CEPH_ARGS to the mgr pod so radosgw-admin can use it
ceph dashboard uses radosgw-admin for certain tasks that
aren't accessible via the rgw REST API. Due to the absence of
a valid ceph.conf file at /etc/ceph/ceph.conf within the mgr pod,
radosgw-admin fails to operate, resulting in 500 errors across
various 'Object Gateway' views on the dashboard. This change
adds CEPH_ARGS environment variable to the mgr pod enabling
its propagation and utilization by the dashboard/radosgw-admin
for executing rgw commands.

closes: https://github.com/rook/rook/issues/13255

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-23 10:48:55 +01:00
Ryotaro Banno 0ad88e9d68 core: add pgHealthyRegex to DisruptionManagementSpec
This patch adds `pgHealthyRegex` field to DisruptionManagementSpec.
`pgHealthyRegex` is a regular expression that is used to determine which
PG states should be considered healthy. The default value of
`pgHealthyRegex` is:

        ^(active\+clean|active\+clean\+scrubbing|active\+clean\+scrubbing\+deep)$

which is effectively the same as before.

Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
2023-11-22 00:19:04 +00:00
Travis Nielsen 510d2721b4 Merge pull request #13247 from riya-singhal31/master
csi: add csi-addons sidecar to cephfs deployment
2023-11-21 16:13:31 -07:00
Travis Nielsen da2513e484 Merge pull request #13248 from rkachach/fix_issue_exporter_interval
mgr: get servicemonitor exporter's interval from MonitoringSpec
2023-11-21 16:02:38 -07:00
Riya Singhal 401ce4697a csi: add csi-addons sidecar to cephfs deployment
this commit adds csi-addon sidecar to
cephfsplugin provisioner deployment

Signed-off-by: Riya Singhal <rsinghal@redhat.com>
2023-11-22 02:50:45 +05:30
Redouane Kachach 6b71325dbe mgr: get servicemonitor exporter's interval from MonitoringSpec
this change updates the serviceMonitor interval of the the rook-ceph-exporter
with the value from the MonitoringSpec.

closes: https://github.com/rook/rook/issues/13159

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-11-21 21:47:28 +01:00
Travis Nielsen 38ceb90ab2 Merge pull request #13211 from subhamkrai/pr/gauravsitlani/12957
core: operator to skip reconcile of mgr, rgw, mds and rbd-mirror
2023-11-21 12:15:34 -07:00