Cluster_ID variable that we export from python script was different
from what we going to use in import script so changed it
Signed-off-by: parth-gr <paarora@redhat.com>
CephFS CSI driver dont have/advertise controller publish/unpublish
capabilities, thus dont need attacher sidecar for its operations.
The presence of external-attacher adds on overhead and issues wrt
attachment in various scenarios. One of them would be the lack of
performance on syncing volumeattachment from api server..etc.
More or less we don't have controller publish and unpublish capabilities,
so we should not make use of this sidecar and cause
unnecessary addon here thus other issues.
similar changes have been added to CSI
https://github.com/ceph/ceph-csi/pull/3149
Signed-off-by: yati1998 <ypadia@redhat.com>
This commit introduces new log level called csidecarLogLevel
for the sidecars which are not maintained by the csi-driver.
This will allow to have different configuration options
for the sidecars like snapshotter, resizer, attacher and
provisioner containers which will help to avoid the
spamming of logs to an extent.
Signed-off-by: yati1998 <ypadia@redhat.com>
Indentation level for the rule array for pools was inconsistent, leading to a broken YAML array.
This commit corrects indentation level for pool rules to align with the rest of the array.
Closes: https://github.com/rook/rook/issues/10653
Signed-off-by: James Harmison <jharmison@gmail.com>
A Liveness sidecar container that is deployed
with the CSI pods will be helpful to check
csi driver is properly responding or not.
and there is no liveness or readiness
kubernetes probe added for this one.
Providing an option to enable this
sidecar deployment and disabling it by default.
fixes#8783
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
The RGW support server side encryption with help of s3 protocol, till
now the `sse:kms` was support in which keys will be provided by the user
and but it will be saved in external management service like vault. Now
the support for `sse:s3` is added so the entire encryption key
management is performed by RGW itsels.
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
This commit updates the CephFS mirroring documentation
around Peer tokens to get the token created correctly.
Signed-off-by: Gaurav Sitlani <gauravsitlani@riseup.net>
this commits add new field `MaxLogSize` inside `LogCollectorSpec` of
cephCluster cr which will take max size of log after which we want to
rotate the log.
Signed-off-by: subhamkrai <srai@redhat.com>
adding port which was missing from helm rook-ceph chart
which is used by webhook due to which it was failing with
```
failed to run operator: gave up to run the operator manager: failed to
run the controller-runtime manager: listen tcp :9443: bind: address
already in use
```
Signed-off-by: subhamkrai <srai@redhat.com>
With octopus coming to end of life, we remove support from
Rook for deploying Ceph Octopus and assume a min version of
Pacific v16. Any checks for octopus or earlier are removed
from the reconciles since they are obsolete.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The toolbox is really only used for ceph commands. The main reason
the rook image was being used in the toolbox pod was for the script
that generates the ceph.conf and updates it whenever the mons are
updated during mon failover.
Now the ceph image can be specified directly by moving the script
inline with the container definition instead of being required
in the image.
The rook image will still contain the script for backward compatibility
and for scenarios where the rook binary may still be needed
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Using subvolume group and rados namespace for external deployment
was complicated and not documented,
Automating the process for the users, so they just need to pass
the respective names by cli flag for creation
Closes: rook#10427
Signed-off-by: parth-gr <paarora@redhat.com>
At present the CephFS CSI driver works with default mode ie,
`ReadWriteOncewithFsType`. However `File` type is more apt for
the CephFS CSI driver and this commit bring that change. The
similar change is also introduced in ceph csi driver here:
https://github.com/ceph/ceph-csi/pull/3204
considering the `File` mode has been GAd in 1.23 kubernetes version
and also we are lifting one of the problematic code path in this
area via Ceph CSI driver changes, it is good to move the
fsgrouppolicy to `File`.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
From kube v1.24 onwards, Kubeadm applies a "node-role" label to its
control plane Nodes.Currently this label key is node-role.kubernetes.io/master
and it will be renamed to node-role.kubernetes.io/control-plane. Kubeadm
also uses the same "node-role" as key for a taint it applies on control
plane Nodes. This taint key should also be renamed to
"node-role.kubernetes.io/control-plane".
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Mudit Agarwal
Blaine Gardner
Sébastien Masset
parth-gr
yati1998
Travis Nielsen
subhamkrai
James Harmison
Madhu Rajanna
Jiffin Tony Thottan
Gaurav Sitlani
Anthony D'Atri
Mathieu Parent
Ali, Akil
Josh Soref
Alexander Trost
Santosh Pillai
zhucan
Markus Schmidleitner
Humble Chirammal
Niels de Vos
Rakshith R