Commit Graph
13292 Commits
Author SHA1 Message Date
dependabot[bot] 113175b105 build(deps): bump github/codeql-action from 3.27.1 to 3.27.4
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/4f3212b61783c3c68e8309a0f18a699764811cda...ea9e4e37992a54ee68a9622e985e60c8e8f12d9f)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-18 12:46:10 +00:00
dependabot[bot] d72327d3b5 build(deps): bump dcarbone/install-jq-action from 2.1.0 to 3.0.1
Bumps [dcarbone/install-jq-action](https://github.com/dcarbone/install-jq-action) from 2.1.0 to 3.0.1.
- [Release notes](https://github.com/dcarbone/install-jq-action/releases)
- [Commits](https://github.com/dcarbone/install-jq-action/compare/8867ddb4788346d7c22b72ea2e2ffe4d514c7bcb...e397bd87438d72198f81efd21f876461183d383a)

---
updated-dependencies:
- dependency-name: dcarbone/install-jq-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-18 12:46:03 +00:00
amrut-asm 8750b70771 helm: set service account for toolbox pod
run the tools pod with the rook-ceph-default service account

setting the service account for the pod prevents SCC violations on openshift

Signed-off-by: amrut-asm <amrutrn1@gmail.com>
2024-11-18 12:45:00 +05:30
Travis Nielsen 9bad30dd0d Merge pull request #14826 from prazumovsky/use-keyfile-if-no-auth
osd: import keyring file on activate to ceph auth if not imported yet
2024-11-15 21:00:45 -07:00
Travis Nielsen 597e5e9be7 Merge pull request #15004 from parth-gr/external-fix-docs
external: fix external cluster docs
2024-11-15 07:30:38 -07:00
parth-gr 59ed91cc7e external: fix external cluster docs
update the incstruction for where to run python script

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-11-15 18:57:06 +05:30
Peter Razumovsky 12613bc2fa osd: add osd auth recovery from file canary job test
Add test to canary-integration-test scenarios which removes
osd auth and then recovers it on osd activation from keyring
file.

Resolves: #14825
Signed-off-by: Peter Razumovsky <prazumovsky@mirantis.com>
2024-11-15 16:41:31 +04:00
Peter Razumovsky 62ffcd4cbe osd: remove excess if-else for keyring file import in activate script
Remove unnecessary if-else statement inside "if keyring file exists"
condition of osd activate script.

Resolves: #14825
Signed-off-by: Peter Razumovsky <prazumovsky@mirantis.com>
2024-11-12 21:20:57 +04:00
Peter Razumovsky 6eb2d1121a osd: import keyring file on activate to ceph auth if not imported yet
If host path keyring file exists and created during osd-prepare but not
imported to ceph auth then rook-ceph-osd activate init container will
create new keyring in ceph auth by ceph auth get-or-create command. To
avoid keyrings difference in host path and in ceph auth, consider
importing key from host path keyring file if no keyring found in ceph
auth.

Resolves: #14825
Signed-off-by: Peter Razumovsky <prazumovsky@mirantis.com>
2024-11-12 21:20:57 +04:00
subham rai 7822e6b199 Merge pull request #14990 from rook/dependabot/github_actions/github/codeql-action-3.27.1
build(deps): bump github/codeql-action from 3.27.0 to 3.27.1
2024-11-11 21:27:59 +05:30
subham rai d749893247 Merge pull request #14992 from rook/dependabot/go_modules/golang.org/x/sync-0.9.0
build(deps): bump golang.org/x/sync from 0.8.0 to 0.9.0
2024-11-11 21:15:45 +05:30
dependabot[bot] a98a1e531c build(deps): bump golang.org/x/sync from 0.8.0 to 0.9.0
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.8.0 to 0.9.0.
- [Commits](https://github.com/golang/sync/compare/v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-11 12:54:29 +00:00
dependabot[bot] 0edd074851 build(deps): bump github/codeql-action from 3.27.0 to 3.27.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.0 to 3.27.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/662472033e021d55d94146f66f6058822b0b39fd...4f3212b61783c3c68e8309a0f18a699764811cda)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-11 12:41:55 +00:00
subham rai 66e2d53c06 Merge pull request #14987 from Madhu-1/csiaddons-rbac
csi: add required finalizers for openshift
2024-11-11 14:04:53 +05:30
Madhu Rajanna 158891a37c csi: add required finalizers for openshift
openshift cluster need to have access to
finalizers when we set the blockOwnerDeletion
if an ownerReference refers to a resource
we can't set finalizers on, This adds the extra
required permission

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-11-11 08:49:16 +01:00
Travis Nielsen a100ae3d8c Merge pull request #14977 from sp98/pool-id-in-status
core: add pool IDs to cephBlockPool CR status
2024-11-08 10:57:50 -07:00
Travis Nielsen afb6bce4b7 Merge pull request #14981 from GrantFleming/allow-arbiter-failover-in-stretch
operator: monitors should always be allowed to failover
2024-11-08 09:22:42 -07:00
Grant Fleming cdf692d227 operator: monitors should always be allowed to failover
Previously arbiter monitors were allowed to failover in supported versions
of Ceph. This behaviour regressed. Since all supported versions of Ceph now
support this, we no longer need to check this at all.

Signed-off-by: Grant Fleming <gfleming@evroc.com>
2024-11-08 16:48:05 +01:00
Santosh Pillai a344ff53f3 core: add pool IDs to cephBlockPool CR status
Adding pool ID of the cephBlockPool in the CR status

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2024-11-08 21:07:48 +05:30
Travis Nielsen 721f934bb2 Merge pull request #14966 from parth-gr/monitor-blockpool-mirror
rbdmirror: fix mirroring monitoring settings for blockpool
2024-11-08 08:14:47 -07:00
Travis Nielsen 70c1f27b5e Merge pull request #14970 from Madhu-1/add-rbac-csiaddons-sidecar
csi: add new RBAC required for csiaddons
2024-11-06 11:25:48 -07:00
parth-gr ed5013e9c6 rbdmirror: add disable check for status check
enable and disable the status of rados namespace
mirroring by looking at statusCheck spec of blockpool

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-11-06 22:42:46 +05:30
Madhu Rajanna 501e0ea0a4 csi: add new RBAC required for csiaddons
csiaddons required new RBAC in the next
release to create/update the csiaddonsnode
object based on the owner deployment/daemonset
names of the pods its running with.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-11-06 08:24:01 +01:00
parth-gr eec2b3e581 rbdmirror: fix mirroring monitoring settings for blockpool
currently if we disable the monitoring for cephblockpool
it didnt worked, as there was no check to cancel it
if the mirroring is still enabled

Add a check to disable the monitoring if mirroring is still enabled

closes: https://github.com/rook/rook/issues/14958

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-11-06 11:56:16 +05:30
Travis Nielsen c5df2fe721 Merge pull request #14824 from prazumovsky/fix-5-2-8
core: add capabilities to securityContext to fix CIS 5.2.8
2024-11-05 12:32:43 -07:00
Blaine Gardner 8f6da3d6da Merge pull request #14897 from OdedViner/delete_pool_item
rbd: CephBlockPool enableRBDStats not clearing rbd_stats_pools
2024-11-05 11:07:31 -07:00
Travis Nielsen 1ed625152a Merge pull request #14951 from cobaltcore-dev/keep-default-placement
rgw: keep default-placement in zone config
2024-11-05 09:17:17 -07:00
Travis Nielsen 7692cae359 Merge pull request #14896 from parth-gr/rbd-mirror-rados-monitor
rbd: enable periodic monitoring for rados namespace mirroring
2024-11-05 09:15:32 -07:00
Oded Viner 8dea77255b pool: fix CephBlockPool enableRBDStats not clearing rbd_stats_pools
This PR fixes an issue where disabling enableRBDStats in CephBlockPool did not remove
the pool from rbd_stats_pools, leading to unnecessary monitoring.
The update ensures that when enableRBDStats is set to false,
the pool is properly removed from rbd_stats_pools, optimizing resource tracking.

Signed-off-by: Oded Viner <oviner@redhat.com>
2024-11-05 15:03:21 +02:00
Peter Razumovsky 97a13628e5 core: add capabilities to securityContext to fix CIS 5.2.8
Resolves CIS benchmark 5.2.8 rule by adding capabilities with
explicitly defined empty "add" list (where it needed) and with
NET_RAW capability in "drop" list.

5.2.8 Minimize the admission of containers with added capabilities

Containers must drop the `NET_RAW` capability and are not permitted
to add back any capabilities.

Signed-off-by: Peter Razumovsky <prazumovsky@mirantis.com>
2024-11-05 16:27:43 +04:00
Artem Torubarov 8ad2bf88bb rgw: keep default-placement in zone config
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
2024-11-05 10:47:10 +01:00
parth-gr 9785ef5c8d rbdmirror: enable periodic monitoring for rados namespace
enable monitoring for rados namespace

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-11-05 13:45:02 +05:30
Travis Nielsen fb02f500be Merge pull request #14962 from travisn/ci-latest-squid
ci: Default to the latest stable squid instead of devel
2024-11-04 15:36:59 -07:00
Travis Nielsen b229240faa ci: default to the latest stable squid instead of devel
The devel images have been fairly stable for Rook to test
against, but on occasion there are regressions from
Ceph development that affect the Rook CI. For stability during
Rook development, use the latest stable version of ceph for
PRs, master, and release tests. The daily CI will still use
the devel images from Ceph.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-11-04 14:10:36 -07:00
Travis Nielsen 0b666c0a3f Merge pull request #14952 from travisn/fs-standby-update
mds: Wait for mds standby upgrade for same fs
2024-11-04 10:40:00 -07:00
Travis Nielsen 13495aea5a Merge pull request #14941 from travisn/detect-version-resources
core: Set resources on the detect version job
2024-11-04 10:14:38 -07:00
Travis Nielsen bebe5bd402 Merge pull request #14949 from travisn/schedule-all-nodes
osd: Allow scheduling on unschedulable nodes
2024-11-01 14:17:43 -06:00
Travis Nielsen 99d60c5bba mds: wait for mds standby upgrade for same fs
The upgrade of the mds daemons pauses to wait for the
stopping of standby daemons before the filesystem upgrade
is completed. If there are multiple filesystems, there
could be standbys for other filesystems that will not be
stopped at the time of the upgrade of another filesystem.
Thus, the standbys may not upgrade and be stuck on the
previous version. Now, the standby upgrade will only wait
for standbys for the same filesystem.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-11-01 14:03:13 -06:00
Travis Nielsen 18c9261d0b Merge pull request #14943 from travisn/obsolete-object-test
test: Remove obsolete object user test flag
2024-11-01 07:21:04 -06:00
Travis Nielsen 98638de22d Merge pull request #14936 from cybozu-go/doc-take-multicluster-into-account-for-datadirhostpath
doc: clarify dataDirHostPath must be unique for each cluster
2024-10-31 17:16:28 -06:00
Satoru Takeuchi 62d99330d6 doc: clarify dataDirHostPath must be unique for each cluster
If there are multiple clusters, `dataDirHostPath` must be unique
for each cluster. However, it's not documented yet.
In addition, `ceph-teardown.md` was also updated because
the original document assumes that `dataDirHostPath` is
`/var/lib/rook` and the files for a cluster `rook-ceph` is
under `/var/lib/rook/rook-ceph`.

related issue:
https://github.com/rook/rook/issues/14790

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-31 22:15:17 +00:00
Travis Nielsen f489f99e13 core: set resources on the cmd reporter jobs
If the cmd-reporter key is set under the resources
element in the CephCluster CR, the memory and cpu request
and limits will be set on the ceph detect version job
and network job accordingly.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-31 14:52:57 -06:00
Travis Nielsen 7fbe4e7db5 osd: allow scheduling on unschedulable nodes
For nodes that are explicitly requested for deploying
OSDs, they will be skipped temporarily if not
schedulable or not ready. A future reconcile is
expected to schedule them. Allow the OSDs to be
scheduled even on these nodes that are temporarily
down, even if it blocks the reconcile from completing.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-31 14:05:36 -06:00
Travis Nielsen 0ae1916312 Merge pull request #14944 from cybozu-go/test-avoidalways--running-tmate-session
doc: avoid always enabling tmate session
2024-10-31 08:06:40 -06:00
Travis Nielsen d725b31e59 Merge pull request #14942 from travisn/no-csi-version-check
csi: Remove version check for k8s and cephcsi
2024-10-31 07:31:37 -06:00
Satoru Takeuchi 47ca3fd245 doc: avoid always enabling tmate session
tmate session is always enabled by mistake. This bug is
introduced in the following PR.

https://github.com/rook/rook/pull/14934

We should enable this if `inputs.debug-ci` is `true`.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-31 06:00:49 +00:00
Travis Nielsen f60f4443df test: remove obsolete object user test flag
In Rook v1.6 some new properties were added for
ceph object store users, so the CI was skipping
validation of that setting in the upgrade test.
Now we are far past the need for that flag, and we
can assume the latest flags exist for the tests.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-30 15:03:24 -06:00
Travis Nielsen 2ff429e479 csi: remove version check for k8s and cephcsi
The version checks for the csi driver are removed now
since they are all obsolete. The K8s version and cephcsi
versions are no longer checked. Anyway, the move to the
csi operator would take ownership of version checks
needed in the future, so for now we simplify rook
deployment of the csi driver.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-30 14:03:51 -06:00
Blaine Gardner 4e8d4dee41 Merge pull request #14934 from cybozu-go/make-debug-ci-label-work-again
test: make debug-ci label work again
2024-10-30 11:25:11 -06:00
Blaine Gardner c01741260e Merge pull request #14922 from obnoxxx/make-generate-systematic
Make generating make targets more  systematic
2024-10-30 10:58:25 -06:00