feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
13,292 Commits 38 Branches 289 Tags
c1a892396a94de281cddfa088945b91ae8a6f33a
Commit Graph
13292 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael AdamandBlaine Gardner 04741fb899 build: make generating make targets more systematic 
This addresses a suggestion from a review comment in another PR.

The goal of this change is to make generating make targets more systematic.

Firstly, generating targets are made available under a more systematic naming
 following the pattern of "gen.foo".
more concretely, the following targets are introduced as aliases of the corresponding existing
 targets:

* gen.codegen
* gen.rbac
* gen.crds
* gen.docs
* gen.crd-docs

additionally, a  new "generate" make target is added that invokes all generating targets.

Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Signed-off-by: Michael Adam <obnox@samba.org>
 2024-10-30 12:11:01 +01:00
Satoru Takeuchi 448f42ab12 test: make debug-ci label work again 
cmoposite workflow can't use `github` variable.

close: https://github.com/rook/rook/issues/14898

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
 2024-10-30 01:44:07 +00:00
Travis Nielsen 45e05ee09f Merge pull request #14921 from rook/dependabot/go_modules/k8s-dependencies-e3707453b0 
build(deps): bump the k8s-dependencies group with 7 updates
 2024-10-29 13:16:22 -06:00
dependabot[bot] 8382c084e4 build(deps): bump the k8s-dependencies group with 7 updates 
Bumps the k8s-dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.31.1` | `0.31.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.1` | `0.31.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.1` | `0.31.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.1` | `0.31.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.1` | `0.31.2` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.31.1` | `0.31.2` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.19.0` | `0.19.1` |

Updates `k8s.io/api` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/api/compare/v0.31.1...v0.31.2)

Updates `k8s.io/apiextensions-apiserver` from 0.31.1 to 0.31.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.1...v0.31.2)

Updates `k8s.io/apimachinery` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.1...v0.31.2)

Updates `k8s.io/cli-runtime` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.31.1...v0.31.2)

Updates `k8s.io/client-go` from 0.31.1 to 0.31.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.31.1...v0.31.2)

Updates `k8s.io/cloud-provider` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.31.1...v0.31.2)

Updates `sigs.k8s.io/controller-runtime` from 0.19.0 to 0.19.1
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.19.0...v0.19.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-29 12:30:37 -06:00
subham rai e78a4832de Merge pull request #14918 from rook/dependabot/github_actions/github/codeql-action-3.27.0 
build(deps): bump github/codeql-action from 3.26.13 to 3.27.0
 2024-10-29 21:15:45 +05:30
Travis Nielsen ac2c5cb0a2 Merge pull request #14913 from travisn/roadmap-1.16 
doc: Update the tentative roadmap for the 1.16 release
 2024-10-29 07:41:01 -06:00
Travis Nielsen 6021f70a59 Merge pull request #14928 from parth-gr/external-doc-fix1 
docs: fix external doc broken links
 2024-10-29 07:40:02 -06:00
parth-gr d061382661 docs: fix external doc broken links 
some of the links have the full path
which is not working in the doc server,
but works locally

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2024-10-29 17:33:35 +05:30
subham rai 3eef446b14 Merge pull request #14917 from rook/dependabot/github_actions/actions/setup-python-5.3.0 
build(deps): bump actions/setup-python from 5.2.0 to 5.3.0
 2024-10-29 13:11:09 +05:30
subham rai 2c41e22f80 Merge pull request #14916 from rook/dependabot/github_actions/actions/checkout-4.2.2 
build(deps): bump actions/checkout from 4.2.1 to 4.2.2
 2024-10-29 13:10:46 +05:30
subham rai 01a7d62747 Merge pull request #14919 from rook/dependabot/github_actions/actions/setup-go-5.1.0 
build(deps): bump actions/setup-go from 5.0.2 to 5.1.0
 2024-10-29 13:10:24 +05:30
Travis Nielsen be53292e51 Merge pull request #14910 from cybozu-go/test-specify-ceph-image-correctly 
test: specify ceph image correctly
 2024-10-28 12:59:57 -06:00
Travis Nielsen 280cb922ab doc: update the roadmap for the 1.16 release 
The roadmap doc is now updated for v1.16 with potential
features and fixes we hope to include.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2024-10-28 11:14:54 -06:00
dependabot[bot] 6f4ad530e0 build(deps): bump actions/setup-go from 5.0.2 to 5.1.0 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32...41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-28 12:35:50 +00:00
dependabot[bot] f1cd919564 build(deps): bump github/codeql-action from 3.26.13 to 3.27.0 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.13 to 3.27.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f779452ac5af1c261dce0346a8f964149f49322b...662472033e021d55d94146f66f6058822b0b39fd)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-28 12:35:43 +00:00
dependabot[bot] 56752e5890 build(deps): bump actions/setup-python from 5.2.0 to 5.3.0 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/f677139bbe7f9c59b41e40162b753c062f5d49a3...0b93645e9fea7318ecaed2b359559ac225c90a2b)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-28 12:35:31 +00:00
dependabot[bot] 734da26d89 build(deps): bump actions/checkout from 4.2.1 to 4.2.2 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871...11bd71901bbe5b1630ceea73d27597364c9af683)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-28 12:35:26 +00:00
Blaine Gardner 4c812f573b Merge pull request #14835 from BlaineEXE/rgw-use-system-certs-for-tls 
object: also use system certs for validating RGW cert
 2024-10-25 11:57:26 -06:00
Blaine Gardner 7bb72a0171 object: also use system certs for validating RGW cert 
When generating the HTTP client used for RGW admin ops, use both system
certs as well as the user-given cert.

As a real world example, admins may use ACME to rotate Letsencrypt certs
every 2 months. For an external CephObjectStore, the cert used by Rook
and RGW may not be rotated at the same time. This can cause the Rook
operator to fail CephObjectStore reconciliation until both certs agree.

When Rook also relies on system certs in the container, Rook's
reconciliation will not have reconciliation failures because
Letsencrypt's well-known and trusted root certificates can be loaded
from the system to validate the RGW's newly-rotated cert.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
 2024-10-25 11:22:11 -06:00
Blaine Gardner c7dfe7837e Merge pull request #14884 from cobaltcore-dev/rgw-default-placement 
rgw: support custom name for default pool placement
 2024-10-25 10:30:58 -06:00
Travis Nielsen 48c7661c1f Merge pull request #14906 from travisn/test-wait-for-mon-daemon 
test: Wait for mon daemons rather than mon canaries
 2024-10-25 09:58:22 -06:00
Travis Nielsen b52ba6baca test: wait for mon daemons rather than mon canaries 
The mon canaries may be created even when the mon daemons
are not created thereafter during the integration tests.
Therefore, the integration tests need to also query a label
specific to the mon daemon so the canaries are not a distraction
to the test.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2024-10-25 09:17:02 -06:00
Satoru Takeuchi 36721edae8 test: specify ceph image correctly 
`encryption-pvc-kms-ibm-kp` workflow replaces the name of ceph-image.
Since the dest value is always empty by mistake, this workflow
always fails.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
 2024-10-25 11:50:56 +00:00
Artem Torubarov b47dff9770 rgw: support custom name for default pool placement 
introduce Default flag to CRD

Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
 2024-10-25 12:52:06 +02:00
Satoru Takeuchi f50734962b Merge pull request #14901 from guits/add-udev-bindmount 
osd: mount /run/udev in the init container for ceph-volume activate
 2024-10-25 16:18:08 +09:00
Travis Nielsen 3b94c50d8b Merge pull request #14818 from iPraveenParihar/kms/vault-keyrotation 
kms: key rotation support for vault kms
 2024-10-24 11:38:33 -06:00
Blaine Gardner 7a4cf8d93c Merge pull request #14819 from BlaineEXE/holder-pods-remove-config 
multus: finish deprecating holder pods
 2024-10-24 10:55:02 -06:00
Travis Nielsen 58df41e0cf Merge pull request #14895 from Madhu-1/cleanup-block 
core: Cleanup blockpool with annotation
 2024-10-24 10:28:31 -06:00
Guillaume Abrioux dbcd0d46dd osd: mount /run/udev in the init container for ceph-volume activate 
The /run/udev directory is now mounted in the OSD init container. This change
is necessary because `ceph-volume activate` needs access to /run/udev [1] in order
to properly handle devices. Without this mount, `ceph-volume activate` could
fail to discover devices during OSD initialization.

[1] https://github.com/ceph/ceph/commit/c2e8c295dc46f1bd74861feb163d9d82f8bb5509

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
 2024-10-24 17:16:10 +02:00
Blaine Gardner 8491c427f1 Merge pull request #14834 from jhoblitt/feature/obc-bucket-quota 
object: add bucketMaxObjects & bucketMaxSize to obc
 2024-10-23 16:42:21 -06:00
Blaine Gardner 5539eedd1b multus: finish deprecating holder pods 
Finish the process of deprecating holder pods by removing Rook's ability
to deploy them. The intent of this change is to make the most
superficial changes possible to accomplish this. There are still
remnants of code in Rook (particularly the CSI controller) that helped
configure or deploy holder pods. Due to the risk of breaking some
features, cleanup work of hose remnants will be deferred for future
work.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
 2024-10-23 16:29:02 -06:00
Joshua Hoblitt f64027bf43 test: add obc bucketMaxObjects integration test 
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2024-10-23 14:39:38 -07:00
Joshua Hoblitt f51cfbdf6b object: add bucketMaxObjects & bucketMaxSize to obc 
Two new keys are added to ObjectBucketClaim.spec.additionalConfig to
support the configuration of bucket scope quota(s). This differs from
the existing maxObjects & maxSize keys, which manage a user scope
quota(s) on the automatically generated rgw user.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2024-10-23 14:39:38 -07:00
Madhu Rajanna 4e29717317 core: cleanup blockpool with annotation 
This is similar to #14052 we did for radosnamespace
and this is an extension to support cleanup
at the blockpool level to cleanup the images
and the snapshots in a pool.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2024-10-23 12:20:31 +02:00
subham rai f8a820683e Merge pull request #14891 from black-dragon74/rbd-vgs-docs-revert 
Revert "docs: add documentation for rbd volumegroupsnapshot"
 2024-10-23 13:21:29 +05:30
Praveen M c9bc3a2685 ci: add test for vault key rotation 
Signed-off-by: Praveen M <m.praveen@ibm.com>
 2024-10-23 12:58:11 +05:30
Niraj Yadav b040a02336 Revert "docs: add documentation for rbd volumegroupsnapshot" 
This reverts commit 524b6071d2.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
 2024-10-23 11:44:47 +05:30
Praveen M 01ccb5e20a docs: update docs for vault KMS key rotation support 
Signed-off-by: Praveen M <m.praveen@ibm.com>
 2024-10-23 11:43:55 +05:30
Praveen M d8c0242c29 security: key rotation support for vault kms 
Signed-off-by: Praveen M <m.praveen@ibm.com>
 2024-10-23 11:43:49 +05:30
Travis Nielsen 615086ccf2 Merge pull request #14715 from cobaltcore-dev/rgw_new_shared_pools 
rgw: support new zone pools
 2024-10-22 15:39:05 -06:00
Travis Nielsen ce63317732 Merge pull request #14886 from obnoxxx/codegen-remove-wrong-comment 
ci: remove incorrect comment from codegen workflow
 2024-10-22 11:17:08 -06:00
Michael Adam 714f80a80a ci: remove incorrect comment from codegen workflow 
PR #14883 fixed the codegen workflow but introduced a comment
that is simply wrong.

This change rectifies this mistake by removing the comment.

Signed-off-by: Michael Adam <obnox@samba.org>
 2024-10-22 18:42:58 +02:00
Travis Nielsen e0d50bae9a Merge pull request #14883 from obnoxxx/fix-codegen-ci 
ci: fix the codegen workflow
 2024-10-22 09:50:17 -06:00
Artem Torubarov f6a25b0c4b rgw: support v19 zone pools 
add rgw shared pools rados ns to topics_pool, account_pool, and group_pool

Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
 2024-10-22 11:23:42 +02:00
Michael AdamandTravis Nielsen f32d3df995 ci: fix the codegen workflow 
The codegen workflow recently sometimes failed to detect files modified
by codegen. This has been analysed in a test PR:
https://github.com/rook/rook/pull/14723

The result of the analysis is the insight that the codegen tooling did not work
as expcted because the git checkout was not located in the src/github.com
directory under the GOPATH.

This change fixes the codegen workflow by post-processing the git checkout
action by copying the git checkout directory to the expected location.

Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
 2024-10-22 10:45:37 +02:00
subham rai 092fd550d1 Merge pull request #14875 from Madhu-1/fix-14822 
csi: fix typo in image version
 2024-10-21 15:57:15 +05:30
Madhu Rajanna 55441ee408 csi: fix typo in image version 
add missing `v` in the cephcsi
image version

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2024-10-21 10:53:55 +02:00
Blaine Gardner 1c917743b4 Merge pull request #14827 from jhoblitt/feature/parseAdditionalConfig 
object: set obc user quota(s) in one SetUserQuota() call
 2024-10-18 16:57:50 -06:00
Joshua Hoblitt 9243764359 object: set obc user quota(s) in one SetUserQuota() call 
Previously, up to 3 calls to SetUserQuota() could be made. This has been
consolidated into a single call. Additionally, the `addtionalConfigSpec`
struct is introduced to centralize handling of `.spec.additionalConfig`
keys and as foundational work to support new keys in the future.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
 2024-10-18 15:27:01 -07:00
Travis Nielsen be23171b7d Merge pull request #14872 from jhoblitt/bugfix/rgw-multisite-testing-ceph-image 
test: fix ceph image tag used by most canary tests
 2024-10-18 14:42:54 -06:00