Commit Graph
13292 Commits
Author SHA1 Message Date
Travis Nielsen e2cadab6fe mon: do not remove extra mon in middle of failover
If the mon failover is in progress, ensure the removal
of an extra mon deployment is skipped since that code
path only has one mon in the list for the mon that was
just newly started. The extra mon was erroneously removing
a random mon in that case, followed immediately by the mon
failover completing and removing the expected failed mon,
and potentially causing mon quroum loss.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-04 14:29:57 -06:00
Joshua Hoblitt d301114680 test: do not always run sudo lsblk in github-action-helper.sh
This removes the execution of `sudo lsblk` three times for every single
invocation of the script.  Usage of the BLOCK var is replaced with
functions which memoize the result of probing for block devices.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 16:40:10 -07:00
Travis Nielsen 4083282687 Merge pull request #14801 from rook/bugfix/cephobjectzone-existing-pools
rgw: fix CephObjectZone failing with pre-existing pools
2024-10-03 13:49:15 -06:00
Travis Nielsen e26d5f80ed Merge pull request #14795 from travisn/remove-quincy
core: Remove support for Ceph Quincy
2024-10-03 12:07:39 -06:00
Joshua Hoblitt 76fa776795 rgw: change CephObjectZone.spec.{dataPool,metadataPool} to optional
These fields must be optional in order to allow usage of pre-existing
pools managed by CephBlockPool CR(s).

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 10:56:24 -07:00
Travis Nielsen 049953471d Merge pull request #14772 from jhoblitt/bugfix/cephobjectstore-existing-pools
rgw: fix CephObjectStore failing with pre-existing pools
2024-10-03 11:50:32 -06:00
Joshua Hoblitt 581fd5c197 test: convert all github-action-helper functs to $REPO_DIR
This allows all functions to be called in any order without concern for
the CWD.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 10:18:17 -07:00
Joshua Hoblitt 31d55b90fe test: mv canary test specific resources out of deploy_cluster()
Factor out most of the CRs used by various canary tests to a new
deploy_cluster_full_of_cruft_please_stop_using_this() function.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 10:18:17 -07:00
Joshua Hoblitt ed8156017e test: add object-with-cephblockpool canary test
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 10:16:30 -07:00
Joshua Hoblitt 9b952e0a55 rgw: fix cephObjectStore failing with pre-existing pools
When attempting to use pre-existing (or cephBlockPool managed) pools and
the cephObjectStore.spec.{metadataPool,dataPool} fields are not
specified, rgw creation will fail with this error:

    2024-09-25 21:00:17.744358 E | ceph-object-controller: failed to reconcile CephObjectStore "rook-ceph/test1". failed to create object store deployments: failed to create object pools: failed to create metadata pools: failed to create pool "test1.rgw.control": pool "test1.rgw.control" type is not defined as replicated or erasure coded

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 10:16:30 -07:00
Joshua Hoblitt cb1dd152ad test: add github-action-helper toolbox functions
Added these functions for running commands in the toolbox pod:

- toolbox()
- ceph()
- rbd()
- radosgw-admin()

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-03 10:16:30 -07:00
Travis Nielsen b665d7a7b7 core: remove support for ceph quincy
Given that Ceph Quincy (v17) is past end of life,
remove Quincy from the supported Ceph versions,
examples, and documentation.

Supported versions now include only Reef and Squid.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-03 11:12:55 -06:00
Travis Nielsen fc2ac66d65 Merge pull request #14791 from travisn/helm-host-network
helm: Add enforce host network setting
2024-10-02 16:03:04 -06:00
Travis Nielsen 810de394e7 helm: add enforce host network setting
The ROOK_ENFORCE_HOST_NETWORK option was implemented recently
and now we add the helm setting to expose this new setting
in the rook chart.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-02 15:14:46 -06:00
Blaine Gardner b2d2dc7951 Merge pull request #14775 from obnoxxx/revision-history-limit
core: add ROOK_REVISION_HISTORY_LIMIT operator setting
2024-10-02 13:32:05 -06:00
Michael AdamandTravis Nielsen 20f0031280 helm: add revisionHistoryLimit setting
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
2024-10-02 19:40:37 +02:00
Michael Adam ab8fd90aa6 core: add ROOK_REVISION_HISTORY_LIMIT operator setting
This adds an operator config setting ROOK_REVISION_HISTORY_LIMIT
defaulting to kubernetes'value for RevisionHistoryLimit.

If configured, the provided value will be used as RevisionHistoryLimit

for all Deployments rook creates.

Fixes: #12722

Signed-off-by: Michael Adam <obnox@samba.org>
2024-10-02 19:40:37 +02:00
Travis Nielsen fd3927bc84 Merge pull request #14774 from xin3liang/arm-ci-fix
ci: fix canary-arm64 job
2024-10-01 12:41:50 -06:00
Xinliang Liu 05ac99c0c0 ci: fix canary-arm64 job
Fix OSD isn't up.
As sdb device might change to vdb in the runner, let
find_extra_block_dev() exclude the nbd devices and find the proper
extra device for OSD.

Clean up the nbd devices after the test job is running.

Fix logs artifact upload twice and collect logs before clean up.

Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
2024-10-01 12:05:32 -06:00
Travis Nielsen 9bd70ef152 Merge pull request #14755 from sp98/pool-application
core: preserve pool application name change
2024-10-01 11:00:44 -06:00
Travis Nielsen 4eb278915a Merge pull request #14782 from parth-gr/csi-fix-logrotate
csi: add sc privileged to logrotate sidecar container
2024-10-01 09:55:24 -06:00
Travis Nielsen fc8e500f7c Merge pull request #14752 from travisn/config-doc
docs: Declare cephconfig settings stable
2024-09-30 14:25:50 -06:00
Travis Nielsen 0481c8f64a Merge pull request #14780 from rook/dependabot/go_modules/go.uber.org/automaxprocs-1.6.0
build(deps): bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0
2024-09-30 13:48:33 -06:00
Travis Nielsen 3db15b224f Merge pull request #14784 from rook/dependabot/github_actions/github/codeql-action-3.26.9
build(deps): bump github/codeql-action from 3.26.8 to 3.26.9
2024-09-30 13:47:27 -06:00
Travis Nielsen 330ddf97cb Merge pull request #14783 from rook/dependabot/github_actions/actions/checkout-4.2.0
build(deps): bump actions/checkout from 4.1.7 to 4.2.0
2024-09-30 11:33:32 -06:00
parth-gr 21ca333ed7 csi: add sc privileged to logrotate sidecar container
deployments on openshift where we need csi container pods
to be run on privileged, the logrotate sidecar container was missing the
privileged permission letting, side car to not run properly

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-09-30 20:14:09 +05:30
dependabot[bot] e82925eb00 build(deps): bump github/codeql-action from 3.26.8 to 3.26.9
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.8 to 3.26.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/294a9d92911152fe08befb9ec03e240add280cb3...461ef6c76dfe95d5c364de2f431ddbd31a417628)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-30 12:55:06 +00:00
dependabot[bot] c96641f29f build(deps): bump actions/checkout from 4.1.7 to 4.2.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/692973e3d937129bcbf40652eb9f2f61becf3332...d632683dd7b4114ad314bca15554477dd762a938)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-30 12:54:51 +00:00
dependabot[bot] b7539890e8 build(deps): bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0
Bumps [go.uber.org/automaxprocs](https://github.com/uber-go/automaxprocs) from 1.5.3 to 1.6.0.
- [Release notes](https://github.com/uber-go/automaxprocs/releases)
- [Changelog](https://github.com/uber-go/automaxprocs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/uber-go/automaxprocs/compare/v1.5.3...v1.6.0)

---
updated-dependencies:
- dependency-name: go.uber.org/automaxprocs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-30 12:08:33 +00:00
Santosh Pillai 2f69bd006d doc: osd migration design doc
Existing OSD migration process is limited to updating the OSD backend store. This docs proposes
a more generic API for the OSD migration that will help with other scenarios as well.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2024-09-27 15:50:17 +05:30
Santosh Pillai 1a95d6f533 core: preserve pool application name change
default application name is updated inside the `CreatePool` method. Send
pool spec as address in order to preserve this change.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2024-09-25 12:12:01 +05:30
Travis Nielsen 3fbee3c3ae Merge pull request #14761 from subhamkrai/remove-z-version-go-mod
build: keep specific z version in go mod 1.22.5
2024-09-24 07:21:59 -06:00
subhamkrai b818dd1c7d build: keep specific z version in go mod 1.22.5
let's keep specific z version in go.mod 1.22.5.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-09-24 18:14:19 +05:30
Travis Nielsen 1c9727c271 docs: declare cephconfig settings stable
The cephConfig settings in the CephCluster CR have been
stable and there are no planned changes, so remove the
experimental documentation indicator. Also, clarify
the usage and the precedence of the ceph config
options.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-09-23 11:12:53 -06:00
Blaine Gardner 31362664f3 Merge pull request #14748 from obnoxxx/support-go-1-23
build: support golang 1.23
2024-09-23 10:33:20 -06:00
Travis Nielsen aba78eac07 Merge pull request #14746 from parth-gr/fix-csi-driver
csi: fix the ROOK_CSI_DISABLE_DRIVER flag in the csi reconcile
2024-09-23 10:20:13 -06:00
Michael Adam 9ecd6a2500 build: support golang 1.23
Signed-off-by: Michael Adam <obnox@samba.org>
2024-09-23 18:07:01 +02:00
subham rai d15dabf059 Merge pull request #14757 from rook/dependabot/github_actions/github/codeql-action-3.26.8
build(deps): bump github/codeql-action from 3.26.7 to 3.26.8
2024-09-23 21:07:32 +05:30
dependabot[bot] 33c9bdf652 build(deps): bump github/codeql-action from 3.26.7 to 3.26.8
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/8214744c546c1e5c8f03dde8fab3a7353211988d...294a9d92911152fe08befb9ec03e240add280cb3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-23 12:24:01 +00:00
subham rai bdd22c5b55 Merge pull request #14747 from subhamkrai/update-toolchain
build: update toolchain to latest version
2024-09-20 21:34:48 +05:30
parth-gr 166e4f35b2 csi: fix the disable driver flag in the csi driver reconcile
ROOK_CSI_DISABLE_DRIVER was not working accurate
from https://github.com/rook/rook/pull/14489
The csi driver was installed even if its not
expected

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-09-20 20:30:17 +05:30
Travis Nielsen cc2ea726e1 Merge pull request #14718 from parth-gr/external-doc-structure
docs: update external docs with a better structure
2024-09-20 08:30:04 -06:00
parth-gr 467578d368 docs: update external docs with a better structure
step1 to improve the external docs
and make it more clear to end user

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-09-20 19:56:07 +05:30
subhamkrai 99337b648d build: update toolchain to latest version
this commits update the toolchain version to go v1.22.7

Signed-off-by: subhamkrai <srai@redhat.com>
2024-09-20 17:03:37 +05:30
subham rai 5d69d80874 Merge pull request #14722 from subhamkrai/update-caps-cephfs-external-fencing
external: mds caps to healthchecker/cephfs users
2024-09-20 11:41:50 +05:30
Travis Nielsen ab9fa00e7a Merge pull request #14731 from travisn/crash-annotations
core: Enable annotations on crash collector
2024-09-19 11:48:19 -06:00
subham rai abd1cf1c1a Merge pull request #14738 from subhamkrai/fix-ci
ci: fix ci permission issue with minikube start
2024-09-19 18:01:48 +05:30
subhamkrai f647444515 ci: fix ci permission issue with minikube start
this commit upgrade the minikube, k8s, crictl versions
in CI and also fix permission error in the github runner.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-09-19 15:55:18 +05:30
Travis Nielsen d4f3bf3f2c Merge pull request #14717 from cobaltcore-dev/ceph_exporter_config
Configure prio-limit for ceph exporter container
2024-09-18 14:15:17 -06:00
Travis Nielsen 19ab0eab76 Merge pull request #14720 from black-dragon74/docs-add-vgs
docs: Add documentation for VolumeGroupSnapshot
2024-09-18 13:46:49 -06:00