Commit Graph
13292 Commits
Author SHA1 Message Date
Joshua Hoblitt 84694397bc test: fix ceph image tag used by most canary tests
Fix ceph image tag string passed to replica_ceph_image.  Previously, the
result was "" was being passed in most cases.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-18 12:27:25 -07:00
Joshua Hoblitt 100c8bd7a9 test: require ceph tag param to replace_ceph_image
To prevent silent failures where the ceph image tag is not updated.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-18 12:08:57 -07:00
Travis Nielsen 95578a63ed Merge pull request #14793 from jhoblitt/feature/cephobjectzone-existing-pools
test: add two-object-one-zone canary test
2024-10-18 09:00:56 -06:00
Travis Nielsen 9b2be860f2 Merge pull request #14870 from subhamkrai/update-mac-os
ci: macos-12 will EOL soon, let's use latest tag
2024-10-18 07:38:28 -06:00
subhamkrai febfa5acbc ci: macos-12 will EOL soon, let's use latest tag
Signed-off-by: subhamkrai <srai@redhat.com>
2024-10-18 12:53:20 +05:30
Travis Nielsen 6428693e1c Merge pull request #14823 from prazumovsky/fix-cis-5-7-3-1
core: define empty securityContext for pods to fix CIS 5.7.3
2024-10-17 11:46:16 -06:00
Santosh Pillai c3c58a1822 Merge pull request #14862 from sp98/fix-deleteoptions
core: fix deletion of the osd-replace-config cm
2024-10-16 19:20:11 +05:30
Santosh Pillai 8dd237b460 core: fix deletion of the osd-replace-config cm
MustDelete DeleteOption was set to `true` when deleting
osd-repalce-config configMap.  This cm won't existing after
all the OSDs get migrated. So deletion of the non-existent
cm will result in error. This PR removes `mustDelete: true` from
the DeletionOption when deleting osd-replace-config configmap

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2024-10-16 16:18:29 +05:30
Travis Nielsen 119362059b Merge pull request #14854 from travisn/exporter-cleanup
core: Skip counting exporter pods as a ceph pod
2024-10-15 10:09:17 -06:00
Travis Nielsen 0d4f2f4cbe Merge pull request #14853 from travisn/v1beta-cronjobs
core: Remove obsolete creation of v1beta1 pruner cron jobs
2024-10-15 08:01:48 -06:00
Travis Nielsen 67bca20b40 Merge pull request #14845 from black-dragon74/rbd-vgs-docs
docs: Add documentation for RBD VolumeGroupSnapshot
2024-10-15 07:48:24 -06:00
Niraj Yadav 524b6071d2 docs: add documentation for rbd volumegroupsnapshot
This PR adds the sample YAMLs and documentation
for the RBD VolumeGroupSnapshot.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2024-10-15 16:09:01 +05:30
subham rai b772982566 Merge pull request #14846 from rook/dependabot/github_actions/psf/black-24.10.0
build(deps): bump psf/black from 24.8.0 to 24.10.0
2024-10-15 09:10:01 +05:30
subham rai 327f949004 Merge pull request #14847 from rook/dependabot/github_actions/github/codeql-action-3.26.13
build(deps): bump github/codeql-action from 3.26.11 to 3.26.13
2024-10-15 09:09:36 +05:30
subham rai 30b1bec057 Merge pull request #14848 from rook/dependabot/github_actions/actions/upload-artifact-4.4.3
build(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3
2024-10-15 09:09:18 +05:30
subham rai 59ec129c3f Merge pull request #14849 from rook/dependabot/github_actions/actions/checkout-4.2.1
build(deps): bump actions/checkout from 4.2.0 to 4.2.1
2024-10-15 09:08:55 +05:30
Travis Nielsen a71078b733 core: skip counting exporter pods as a ceph pod
The exporter pods were being counted as a ceph pod,
so once an exporter pod was added to a node, it would never
be removed since the controller thinks the exporter pod
itself is a ceph pod for which the exporter must be present.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-14 21:32:22 -06:00
Joshua Hoblitt edd65e5686 test: when collecting logs, describe instead of get CRs
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-14 16:54:39 -07:00
Joshua Hoblitt 16dd6257c2 test: when collecting logs, use get in secret filename
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-14 16:54:39 -07:00
Joshua Hoblitt 11250013a0 test: add two-object-one-zone canary test
This acceptance test demonstrates the creation of two CephObjectStore(s)
that share the same pool(s) manually managed by CephBlockPool(s).

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-14 16:54:39 -07:00
Travis Nielsen 7ed77ddd13 core: remove obsolete creation of v1beta1 pruner cron jobs
The v1beta1 cron jobs have been obsolete since K8s 1.21,
and Rook has not supported that version of K8s
for many moons, so we can remove the obsolete code
for the handling of v1beta1 cron jobs for crash pruning.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-14 17:13:06 -06:00
Travis Nielsen 1433587457 Merge pull request #14836 from xin3liang/arm-ci-fix-2
ci: fix canary-arm64 job
2024-10-14 11:03:56 -06:00
Blaine Gardner 9baf983187 Merge pull request #14842 from jhoblitt/bugfix/rgw-multisite-testing
test: improve reliability of canary rgw-multisite-testing
2024-10-14 10:57:36 -06:00
dependabot[bot] 0954126b3d build(deps): bump actions/checkout from 4.2.0 to 4.2.1
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/d632683dd7b4114ad314bca15554477dd762a938...eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-14 12:59:53 +00:00
dependabot[bot] ad485e605d build(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/50769540e7f4bd5e21e526ee35c689e35e0d6874...b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-14 12:59:35 +00:00
dependabot[bot] 36ac25a32b build(deps): bump github/codeql-action from 3.26.11 to 3.26.13
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.11 to 3.26.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/6db8d6351fd0be61f9ed8ebd12ccd35dcec51fea...f779452ac5af1c261dce0346a8f964149f49322b)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-14 12:59:26 +00:00
dependabot[bot] 268be1838a build(deps): bump psf/black from 24.8.0 to 24.10.0
Bumps [psf/black](https://github.com/psf/black) from 24.8.0 to 24.10.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/compare/b965c2a5026f8ba399283ba3e01898b012853c79...1b2427a2b785cc4aac97c19bb4b9a0de063f9547)

---
updated-dependencies:
- dependency-name: psf/black
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-14 12:59:20 +00:00
Joshua Hoblitt 92d9f994c2 test: improve reliability of canary rgw-multisite-testing
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-12 12:42:58 -07:00
Xinliang Liu ac7f8e1a60 ci: fix canary-arm64 job
Since the below commit, addons are moved out of deploy_cluster().
31d55b90fe ("test: mv canary test specific resources out of
deploy_cluster()")

Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
2024-10-12 01:56:30 +00:00
Joshua Hoblitt b4ac943b62 test: inline .github/workflows/rgw-multisite-test
Merge/inline.github/workflows/rgw-multisite-test/action.yml into
.github/workflows/canary-integration-test.yml as the step from the
"composite" action are not displayed in the console.  The absence of the
step names may make it difficult to determine where a failure is
occurring.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-11 16:02:50 -07:00
Travis Nielsen 09562fdda5 Merge pull request #14831 from Madhu-1/disable-fencing
csi: disable fencing in Rook
2024-10-11 10:25:35 -06:00
Madhu Rajanna 1d1ed5e962 csi: disable fencing in Rook
Disabling the RBD and CephFS fencing
in Rook for now as its having bugs where
Rook is blocklisting wrong IP address
due to timing issues.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-10-10 19:28:15 +02:00
Travis Nielsen 0fa21969df Merge pull request #14701 from parth-gr/rbd-mirror-rados
rbdmirror: enable rbd rados namespace mirroring
2024-10-10 09:35:22 -06:00
parth-gr 2cef47a9b7 rbdmirror: enable rbd rados namespace mirroring
Modify the CR to allow mirroring of an rados namespace
to a differently named namespace on the remote cluster

1) enable rados namesapce mirroring only
if the blockpool mirrroing is enabled

2) disable blockpool mirroing only if
all the namesapce mirroing is disabled

if the rbd mirroring fails and ceph version is not supported
provide a error message with supported version details
and reason of failing

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-10-10 14:23:11 +05:30
Blaine Gardner 4c87cf9723 Merge pull request #14820 from BlaineEXE/multus-validation-do-not-force-delete
multus: do not force delete in validation cleanup
2024-10-09 12:04:51 -06:00
Peter Razumovsky 516eab4d8a core: define empty securityContext for pods to fix CIS 5.7.3
Resolves CIS benchmark rule 5.7.3, Pods part. SecurityContext
should be explicitly defined in pod level of Pod spec section.
It is sufficient to specify empty securityContext to satisfy
CIS 5.7.3 rule.

5.7.3 Apply Security Context to Your Pods and Containers

When designing your containers and pods, make sure
that you configure the security context for your pods,
containers, and volumes.

Signed-off-by: Peter Razumovsky <prazumovsky@mirantis.com>
2024-10-09 16:10:03 +04:00
Blaine Gardner 936fe60a76 multus: do not force delete in validation cleanup
Do not force delete resources in validation cleanup. Force deletion can
result in CNI IP address management (IPAM) addresses not being released
cleanly, exhausting them. This can then lead to Rook cluster deploy
failure if the CNI IPAM isn't able to garbage collect the IPs quickly.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-10-08 12:50:37 -06:00
Santosh Pillai 0465908912 Merge pull request #14719 from sp98/osd-migration-api
doc: osd migration design
2024-10-08 11:25:58 +05:30
Travis Nielsen bb91b25d49 Merge pull request #14804 from rook/maint/canary-runner-cleaning
test: rm canary/integration "Free Disk Space" step
2024-10-07 11:48:10 -06:00
Travis Nielsen e775bd76a2 Merge pull request #14813 from rook/dependabot/github_actions/golang/govulncheck-action-1.0.4
build(deps): bump golang/govulncheck-action from 1.0.3 to 1.0.4
2024-10-07 10:37:26 -06:00
Travis Nielsen ff42bf777e Merge pull request #14812 from rook/dependabot/github_actions/github/codeql-action-3.26.11
build(deps): bump github/codeql-action from 3.26.9 to 3.26.11
2024-10-07 10:36:53 -06:00
Joshua Hoblitt 66de53dd51 test: rm canary/integration "Free Disk Space" step
This step consumes several minutes per job.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-07 09:20:17 -07:00
subham rai c17660ca85 Merge pull request #14811 from rook/dependabot/github_actions/golangci/golangci-lint-action-6.1.1
build(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1
2024-10-07 21:15:08 +05:30
Travis Nielsen 82eada0f98 Merge pull request #14805 from travisn/remove-extra-mon
mon: Do not remove extra mon in middle of failover
2024-10-07 07:19:12 -06:00
dependabot[bot] 23f8399f15 build(deps): bump golang/govulncheck-action from 1.0.3 to 1.0.4
Bumps [golang/govulncheck-action](https://github.com/golang/govulncheck-action) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/golang/govulncheck-action/releases)
- [Commits](https://github.com/golang/govulncheck-action/compare/dd0578b371c987f96d1185abb54344b44352bd58...b625fbe08f3bccbe446d94fbf87fcc875a4f50ee)

---
updated-dependencies:
- dependency-name: golang/govulncheck-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-07 12:59:02 +00:00
dependabot[bot] 3dab47b6fa build(deps): bump github/codeql-action from 3.26.9 to 3.26.11
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.9 to 3.26.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/461ef6c76dfe95d5c364de2f431ddbd31a417628...6db8d6351fd0be61f9ed8ebd12ccd35dcec51fea)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-07 12:58:59 +00:00
dependabot[bot] 87fb080d09 build(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/aaa42aa0628b4ae2578232a66b541047968fac86...971e284b6050e8a5849b72094c50ab08da042db8)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-07 12:58:50 +00:00
subham rai 0c236b7406 Merge pull request #14800 from jhoblitt/maint/github-action-helper-less-lsblk
test: do not always run `sudo lsblk` in github-action-helper.sh
2024-10-07 15:27:07 +05:30
subham rai 681f38b888 Merge pull request #14798 from BlaineEXE/mds-liveness-probe-fix-timeout
mds: fix liveness probe timeout
2024-10-07 11:47:15 +05:30
Blaine Gardner ad1bae9e1b mds: fix liveness probe timeout
When the MDS liveness probe times out, it should not fail the probe. If
the cluster has a network partition or other issue that causes the Ceph
mon cluster to become unstable, `ceph ...` commands can hang and cause
a timeout. In this case, the MDS should not be restarted so as to not
cause cascading cluster disruption.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-10-04 16:20:47 -06:00