Commit Graph
13292 Commits
Author SHA1 Message Date
Travis Nielsen 35bcf5c1db Merge pull request #10577 from travisn/mgr-services
mgr: Skip updating service if there is no selector
2022-07-13 07:44:11 -06:00
subhamkrai 5e92a30a77 csi: default values of leader election not enough
csi pods uses leader election and they were using
default values but seems like default values of leader
election are not working for some specific clusters.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-07-13 09:50:39 +05:30
Travis Nielsen b8dac76d18 mgr: skip updating service if there is no selector
When the mgr services are updated by the operator to set the
active mgr properly, skip services that do not currently
have a selector set.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-12 16:30:20 -06:00
Sébastien Han a6036074db core: more checkpoint for context cancelled
Some context canceled were missed and not reported correctly. We had
multiple reconcilers running in //. Since they all run in goroutine then
will continue to run until they timeout (if timeout is available,
    otherwise would run forever until the op is restarted).

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-07-12 12:07:59 +02:00
Sébastien Han 247d725aac core: let IsInitialized return errors
Let's return an error instead of a bool so we can better parse it and
decide what to do with it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-07-12 12:07:57 +02:00
Satoru Takeuchi d82eb8adbe Merge pull request #7967 from cybozu-go/ceph-support-some-dm-devices-in-host-based-cluster
osd: support OSD on logical volume in host-based cluster
2022-07-12 07:24:32 +09:00
Satoru Takeuchi 7e571f6114 osd: support OSD on logical volume in host-based cluster
Rook supports raw mode OSD in host-based cluster. So we can also
support OSD on logical volume in this kind of cluster.

Logical volumes aren't picked by filters (i.e. `useAllDevices: true`
and `device{Path,}Filter` to avoid unwanted LV consumption on upgrade.

Closes: https://github.com/rook/rook/issues/2047

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2022-07-11 21:08:50 +00:00
shalev.p 49996522bf pool: configureRBDStats remove postfix dot in mgr config path
The ceph rbd_stats does not take affect with dot postfix.

Closes: https://github.com/rook/rook/issues/10574
Signed-off-by: shalev.p <shalev.p@taboola.com>
2022-07-11 18:21:42 +03:00
Blaine Gardner 97114eaa07 Merge pull request #10572 from BlaineEXE/remove-old-rbac-yaml
build: remove obsolete rbac.yaml file
2022-07-08 12:23:11 -06:00
Blaine Gardner 7cbda4d814 Merge pull request #10563 from parth-gr/rbac-wildcard
core: remove all wildcard permissions in rbac definations
2022-07-08 11:36:54 -06:00
Blaine Gardner 566585640b build: remove obsolete rbac.yaml file
build/rbac/rbac.yaml should have been removed when we started generating
common.yaml, but it was missed.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-07-08 09:59:05 -06:00
parth-gr 50daeb29e5 core: remove all wildcard permissions in rbac definations
Reduce the RBAC scope to the minimum necessary
permissions for rook to operator

Signed-off-by: parth-gr <paarora@redhat.com>
2022-07-08 20:50:59 +05:30
Travis Nielsen 5b6d9cc172 Merge pull request #10569 from subhamkrai/helm-webhook-port
helm: add missing port for webhook in helm
2022-07-08 08:34:38 -06:00
subhamkrai 94f0c0dc25 helm: add missing port for webhook in helm
adding port which was missing from helm rook-ceph chart
which is used by webhook due to which it was failing with
```
failed to run operator: gave up to run the operator manager: failed to
run the controller-runtime manager: listen tcp :9443: bind: address
already in use
```

Signed-off-by: subhamkrai <srai@redhat.com>
2022-07-08 17:39:46 +05:30
Josh Soref 6e7b8767f3 core: fix spelling
* another
* are
* availability
* available
* bootstrap
* boundaries
* ceph
* certificate
* class
* codifies
* consuming
* corrupted
* createor
* csi
* deployments
* exceeded
* execute
* filesystem
* healthiness
* heuristics
* immediately
* insecure
* installed
* isolated
* maintained
* maximum
* minute
* monitor
* new
* nginx
* nonexistent
* not
* occurs
* omitempty
* operator
* orchestration
* persistentvolumes
* placement
* preexisting
* prometheus
* protecting
* provisioner
* purposes
* reconcile
* regex
* related
* requests
* returns
* rubbish
* running
* schedulable
* schedule
* serviceaccount
* simulating
* snapshots
* statement
* static
* tenants
* the
* unavailable
* volumeattachment
* waiting
* with
* wrapper
* zonegroup

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-07-07 18:10:47 -04:00
Travis Nielsen a730d6d801 Merge pull request #10544 from travisn/remove-octopus
core: Remove support for ceph Octopus in Rook v1.10
2022-07-07 15:35:16 -06:00
Travis Nielsen dad97f3425 core: remove support for ceph octopus
With octopus coming to end of life, we remove support from
Rook for deploying Ceph Octopus and assume a min version of
Pacific v16. Any checks for octopus or earlier are removed
from the reconciles since they are obsolete.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-07-07 15:03:26 -06:00
Travis Nielsen 86b14d4467 Merge pull request #10558 from koor-tech/helm_label
helm: use recommended value for helm managed-by label
2022-07-07 11:57:00 -06:00
Alexander Trost 455508ea14 helm: use recommended value for helm managed-by label
This changes the `app.kubernetes.io/managed-by` label to use the helm
`{{ .Release.Service }}` for it's value.
This is recommended by the Helm labels and annotations standard labels
doc page, see https://helm.sh/docs/chart_best_practices/labels/#standard-labels

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-07-06 13:53:24 +02:00
Alexander Trost 1ae867049b Merge pull request #10552 from Sheetalpamecha/issue_10482 2022-07-05 21:22:57 +02:00
Travis Nielsen 864ea2fdcb Merge pull request #10547 from sp98/operator-upgrade-strategy
manifest: use `Recreate` strategy for operator upgrade
2022-07-05 11:41:09 -06:00
Travis Nielsen 5dadd6a50e Merge pull request #10539 from Rakshith-R/skip-nfs-e2e
ci: skip nfs e2e to avoid flaky e2e
2022-07-05 11:25:30 -06:00
Sheetal Pamecha eb2eeb82a6 docs: correct multiple 404 page not found error
multiple links broken in docs needs update

Fixes: #10482
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
2022-07-05 22:16:22 +05:30
Santosh Pillai 693c2d9306 manifest: use Recreate strategy for operator upgrade
Use `Recreate` strategy instead of `RollingUpdate` for
rook-ceph-operator deployement upgrade

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2022-07-04 15:28:42 +05:30
Rakshith R 034c4756d3 ci: make sure PVC is deleted before proceeding for file test
Signed-off-by: Rakshith R <rar@redhat.com>
2022-07-04 11:36:37 +05:30
Rakshith R 16d34e1425 ci: skip nfs csi e2e to avoid flaky e2e
Skip nfs csi e2e until https://github.com/rook/rook/issues/10518
is resolved to avoid flakiness.

Signed-off-by: Rakshith R <rar@redhat.com>
2022-07-04 11:36:37 +05:30
Blaine Gardner 8b512a14bb Merge pull request #10318 from thotz/design-ceph-sse-s3
docs: design doc for supporting aws sse:s3 in RGW
2022-07-01 10:58:51 -06:00
Travis Nielsen 8ecbfbe49d Merge pull request #10540 from subhamkrai/skip-synk-on-fork
ci: skip snyk ci from running on fork repo
2022-07-01 07:37:45 -06:00
subhamkrai ae2a56deb0 ci: skip snyk ci from running on fork repo
Signed-off-by: subhamkrai <srai@redhat.com>
2022-07-01 12:23:23 +05:30
Travis Nielsen f1673152fa Merge pull request #10533 from travisn/integration-test-cleanup
test: Upgrade test to use correct manifests for uninstall
2022-06-30 17:20:27 -06:00
Travis Nielsen e30a068e68 test: skip cluster cleanup in upgrade test
The cluster cleanup is tested in all of the test suites. Now that the
correct manifest test installer is being used for cleanup, the
upgrade tests are failing to delete the namespace due to some
finalizer that is holding on for some resource that wasn't cleaned
up properly. Let's just disable the cleanup for these tests since
it's tested in other test suites and not worth the time to
troubleshoot every resource getting cleaned up.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-06-30 16:19:04 -06:00
Travis Nielsen e86b2f8b02 test: upgrade test to use correct manifests for uninstall
The uninstall after the upgrade test was attempting to read
the crds from github, instead of the local repo as expected.
Now the correct manifests interface is updated during
the upgrade so it will be used during the uninstall.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-06-30 15:33:31 -06:00
Travis Nielsen 7ca9631e6f Merge pull request #10537 from subhamkrai/skip-daily-test-on-fork
ci: skip daily nightly job on fork
2022-06-30 11:44:32 -06:00
subhamkrai e764d05a8c ci: skip daily nightly job on fork
Signed-off-by: subhamkrai <srai@redhat.com>
2022-06-30 17:34:35 +05:30
Jiffin Tony Thottan 2f63f8c337 docs: design doc for supporting aws sse:s3 in RGW
The design doc for adding support in RGW for handling s3 requests with
sse:s3.

Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
2022-06-30 11:34:04 +05:30
zhucan 5ee75d6652 object: support separated network for objectstore
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
2022-06-30 10:56:03 +08:00
zhucan 6f6c26009c object: generated code
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
2022-06-30 10:55:24 +08:00
Travis Nielsen 95f20196ca Merge pull request #10249 from travisn/kube-1.24
ci: Run tests against k8s 1.24
2022-06-29 10:16:48 -06:00
Travis Nielsen 8e65d69c7a Merge pull request #10495 from Rakshith-R/nfs-ci-cleanup
ci: rename EnableCSINFS to TestNFSCSI & explain "nolock" mountOption
2022-06-29 07:59:40 -06:00
Travis Nielsen 63311df9f3 Merge pull request #10519 from travisn/toolbox-script-spec
manifest: Inline toolbox script for direct use of ceph image
2022-06-28 18:55:26 -06:00
Travis Nielsen febce342b7 manifest: inline toolbox script for direct use of ceph image
The toolbox is really only used for ceph commands. The main reason
the rook image was being used in the toolbox pod was for the script
that generates the ceph.conf and updates it whenever the mons are
updated during mon failover.

Now the ceph image can be specified directly by moving the script
inline with the container definition instead of being required
in the image.

The rook image will still contain the script for backward compatibility
and for scenarios where the rook binary may still be needed

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-06-28 17:19:22 -06:00
Travis Nielsen 2294c15bf7 ci: run tests against k8s 1.24
Since K8s 1.24.0 was released we need to run rook
CI against the latest Kubernetes. At the same time,
we update minikube in the CI to 1.25.2.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-06-28 15:11:55 -06:00
Travis Nielsen 676884aab4 Merge pull request #10459 from parth-gr/subvolume-external
external: add support for subvolumegroup and rados namespace
2022-06-28 14:02:40 -06:00
parth-gr c9a864ccdb external: add support for subvolumegroup and rados namespace
Using subvolume group and rados namespace for external deployment
was complicated and not documented,
Automating the process for the users, so they just need to pass
the respective names by cli flag for creation

Closes: rook#10427

Signed-off-by: parth-gr <paarora@redhat.com>
2022-06-28 21:57:54 +05:30
Travis Nielsen 5614b5843e Merge pull request #10154 from bitfisher/master
helm: use correct namespace for provisioner in cephobjectstore template
2022-06-28 08:54:15 -06:00
Travis Nielsen a79d70f11e Merge pull request #10520 from koor-tech/docs_fix_docs_build
build: fix working dir for docs building
2022-06-28 07:56:42 -06:00
Travis Nielsen eb1d22c973 Merge pull request #10502 from jsoref/guard-tmate
ci: be selective about when to offer tmate
2022-06-28 07:43:12 -06:00
Travis Nielsen 04c64a0943 Merge pull request #10506 from travisn/cluster-crd-docs-refactor
docs: Refactor cluster crd doc for subtopics
2022-06-28 07:41:13 -06:00
Markus Schmidleitner 506c266f2f docs: added upgrade note (#10153)
Signed-off-by: Markus Schmidleitner <markus.schmidleitner@ocilion.com>
2022-06-28 10:42:40 +02:00
Markus Schmidleitner 00689476df test: delete object sc before upgrade tests (#10153)
Signed-off-by: Markus Schmidleitner <markus.schmidleitner@ocilion.com>
2022-06-28 10:39:58 +02:00