Commit Graph
13292 Commits
Author SHA1 Message Date
Travis Nielsen 99b00344a9 Merge pull request #10745 from travisn/mergify-1.10
build: Update mergify for the release-1.10 branch and remove 1.6 automatic backports
2022-08-19 13:07:40 -06:00
Travis Nielsen eaa3822a63 build: update mergify for the release-1.10 branch
Configure the mergify bot to open backport PRs for the
1.10 release branch if PRs are labeled as such.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-19 12:52:36 -06:00
Blaine Gardner f2b3634f3b Merge pull request #10737 from BlaineEXE/update-codespell
ci: update codespell config
v1.10.0-alpha.0
2022-08-18 09:25:25 -06:00
Blaine Gardner 5b0a22ca46 ci: update codespell config
Codespell had its first release in a year yesterday and added some
dictionary rules that are now being flagged in our code. Only one
issue required changes to our code, so modify the codespell config to
allow the words we want to allow.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-08-18 09:07:52 -06:00
Travis Nielsen 1ff27e2fd6 Merge pull request #10716 from koor-tech/fix_tests_log_collection
test: fix test pod log collector
2022-08-17 12:26:35 -06:00
Travis Nielsen d7267ff9d2 Merge pull request #10726 from subhamkrai/handle-v1beta-cronjob
core: no need to delete v1beta cronJob during v1 deletion
2022-08-17 10:39:46 -06:00
Blaine Gardner 994a06c1dd Merge pull request #10629 from thotz/rgw-custom-zone-endpointlist
rgw: add custom endpoint list option for zone
2022-08-17 09:50:30 -06:00
subhamkrai e1a585e55f core: no need to delete v1beta cronJob during v1 deletion
we are already deleting v1beta1 cronJob while creating v1 cronJob,
so no need to delete v1beta while v1 cronJob deltion.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-08-17 19:53:59 +05:30
Jiffin Tony Thottan 8003e764f9 rgw: add custom endpoint list option for zone
User can define his desired endpoint list in Zone CR so that it will
overwrite the default service name for rgw.

Resolves #6432

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
2022-08-17 10:03:12 +05:30
Alexander Trost 154df5a21f Merge pull request #10722 from gauravsitlani/master 2022-08-16 16:02:04 +02:00
gauravsitlani b806f0f912 docs: fixed the developer guide link in README.md
Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
2022-08-16 14:30:00 +05:30
Alexander Trost 49440e8b20 test: fix test pod log collector
When a test has a slash in it's name the log collection can fail due to
the "directory" not existing, this makes sure the slashes are replaced
by underscores.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-08-12 23:44:13 +02:00
Travis Nielsen 768602bbe8 Merge pull request #10709 from travisn/ceph-17.2.3
manifest: Update default version of ceph to v17.2.3
2022-08-12 07:35:25 -06:00
Travis Nielsen f02fadc531 manifest: update default version of ceph to v17.2.3
For the Rook v1.10 release we want the latest version of Quincy to
be the default deployment. Updating to v17.2.3 with the latest
patch release.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 16:55:03 -06:00
Blaine Gardner 113970c416 Merge pull request #10676 from BlaineEXE/nfs-sssd
nfs: add support for running SSSD as a sidecar
2022-08-11 16:31:00 -06:00
Blaine Gardner 8c4548935c Merge pull request #10708 from degorenko/lbp-update
rgw: update lib-bucket-provisioner version
2022-08-11 15:42:48 -06:00
Blaine Gardner b98efbb320 nfs: add support for running SSSD as a sidecar
Implement the SSSD sidecar design for NFS.

Because NFS documents are getting long, create an NFS
`Storage-Configuration` section with separated topics to keep the `NFS
Overview` document sane.

Adjust the SSSD design to allow any VolumeSource, not just ConfigMaps.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-08-11 14:59:23 -06:00
Jamison Lofthouse f553034351 monitoring: fix pool growth warning grouping
Predict linear will continue to predict on exporter data from old pods.
We can take the max value for every hour in the 2 day window before we
linearly predict to get the most conservative estimate. This will only
affect the hour in which a new mgr pod is started.

Fixes #10691

Signed-off-by: Jamison Lofthouse <jamison.lofthouse@gmail.com>
2022-08-11 13:53:28 -07:00
Denis Egorenko a553d2f52d rgw: update lib-bucket-provisioner version
Update version of lib-bucket-provisioner to fix issue with updating objectbuckets config.

related-issue: https://github.com/rook/rook/issues/10679
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
2022-08-11 23:53:02 +04:00
Blaine Gardner 1610a304a0 Merge pull request #10681 from travisn/go-mod-update
build: Update go modules to build with go 1.18 and support go 1.19
2022-08-11 13:27:48 -06:00
Travis Nielsen 24e416069a core: update controller runtime to v0.6.2
The dependencies in controller runtim v0.5 were getting old
and causing go module issues on macos. Now with the update to
v0.6.2 the module dependency issue is solved. For another
day we should update the controller runtime to even newer.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:41:11 -06:00
Travis Nielsen e3b4b18938 ci: update macos to v12
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:41:10 -06:00
Travis Nielsen 5ef8d15659 build: format comments for go 1.19
The tool gofmt in go 1.19 requires certain formatting
in the comments section for better rendering.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:41:10 -06:00
Travis Nielsen b726f81542 ci: add support for go 1.19
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:41:10 -06:00
Travis Nielsen 49ca309622 build: only support go 1.18 with the latest modules
The modules are only compatible with go 1.18.
Remove support for go 1.17.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:31:50 -06:00
Travis Nielsen 759b0d1c24 core: use the cluster name due to updated api reference
The cephcluster.ClusterName is no longer available in the k8s api
with the ObjectMeta type, so we use the cephcluster.Name

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:31:50 -06:00
Travis Nielsen a596471757 test: pass test suite by value
The latest go modules come with a sync mutex that requires
us to pass the test suite by reference for proper use
of the mutex.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:31:49 -06:00
Travis Nielsen 93013f7594 manifest: update manifests for latest references
The manifests are regenerated with the latest go references.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:31:49 -06:00
Travis Nielsen 90a0da1de0 build: update go modules
This is an update from make go.mod.update to ensure we
are consuming the latest stable packages available.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-11 12:31:46 -06:00
Travis Nielsen 51c6510a58 Merge pull request #10701 from jclab-joseph/fix/skip-upgrade-check-in-external-cluster
core: skip ceph upgrade check in external cluster
2022-08-11 11:35:58 -06:00
Alexander Trost 59bee3e841 Merge pull request #10456 from koor-tech/docs_tweaks 2022-08-11 18:52:54 +02:00
Alexander Trost 9872b3f7d6 docs: add ci configuration page
This page contains initial information on Rook's CI setup, such as
environment variables.

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-08-11 18:50:06 +02:00
Alexander Trost fe2000e6d8 docs: rename Rook-Ceph to Rook Ceph
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2022-08-11 14:58:57 +02:00
parth-gr 62fec90c19 external: fix cluster id naming in import-external-cluster script
Cluster_ID variable that we export from python script was different
from what we going to use in import script so changed it

Signed-off-by: parth-gr <paarora@redhat.com>
2022-08-11 14:58:42 +02:00
Joseph Lee 9639b60fc4 core: skip ceph upgrade check in external cluster
Closes: rook#10688
Signed-off-by: Joseph Lee <joseph@jc-lab.net>
2022-08-11 19:09:40 +09:00
Travis Nielsen 44fb239334 Merge pull request #10695 from agarwal-mudit/attacher
Revert "csi: remove attacher sidecar from CephFS rook deployment"
2022-08-10 08:06:45 -06:00
Mudit Agarwal 40081cbcd2 Revert "csi: remove attacher sidecar from CephFS rook deployment"
This reverts commit 4bfd88dc4d.

Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
2022-08-10 13:04:14 +05:30
Travis Nielsen 270bc50e0f Merge pull request #10585 from travisn/skip-debug-daemon-reconcile
core: Operator to skip reconcile of mons and osds in debug mode
2022-08-09 16:23:29 -06:00
Travis Nielsen 7c56b9328a core: operator skips reconcile of mons and osds in debug
During certain maintenance tasks the admin will own running
operations on the ceph mons and osds, and the operator should
not interfere with those operations. If the operator sees
any mon in debug mode, every reconcile and mon health check
will be skipped. Thus, mons will not be updated while any
one of them is in maintenance. During OSD reconcile, individual
OSD deployment updates will only be skipped for OSDs that are
actively being debugged.

The debug mode for osd and mon deployments is signaled by
creating the ceph.rook.io/do-not-reconcile label.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-08-09 15:26:04 -06:00
Blaine Gardner 97129d8a0b Merge pull request #10673 from BlaineEXE/sssd-design
docs: SSSD-NFS design
2022-08-08 14:35:41 -06:00
Blaine Gardner 307e8a0bf4 Merge pull request #10543 from smasset-orange/bugfix/rbac-second-cluster-master
[MASTER] Bugfix RBAC second cluster
2022-08-08 10:27:48 -06:00
Sébastien Masset 4427c85845 manifest: fix example RoleBindings
This enables deployment of CephClusters in multiple namespaces in clusters where PSPs are enforced.

Missing bindings:
 * rook-ceph-cmd-reporter-psp
 * rook-ceph-default-psp
 * rook-ceph-mgr-psp
 * rook-ceph-mgr-system
 * rook-ceph-osd-psp
 * rook-ceph-purge-osd-psp
 * rook-ceph-rgw-psp

Signed-off-by: Sébastien Masset <sebastien.masset@orange.com>
2022-08-08 17:47:27 +02:00
Travis Nielsen 7c424992bc Merge pull request #10677 from parth-gr/external-storag-class-correction
external: fix cluster id naming in import-external-cluster script
2022-08-05 11:33:13 -06:00
Blaine Gardner 7787699bab docs: add SSSD to nfs design doc
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-08-05 10:21:11 -06:00
Travis Nielsen 37758836ca Merge pull request #10674 from travisn/Pinned-Dependencies-GitHub
ci: set permissions for github actions
2022-08-05 10:12:08 -06:00
parth-gr c1a16d300e external: fix cluster id naming in import-external-cluster script
Cluster_ID variable that we export from python script was different
from what we going to use in import script so changed it

Signed-off-by: parth-gr <paarora@redhat.com>
2022-08-05 17:30:39 +05:30
neilnaveen 2e2eca672a ci: set permissions for github actions
Restrict the GitHub token permissions only to the required ones;
this way, even if the attackers will succeed in compromising your workflow,
they won’t be able to do much.

Included permissions for the action.
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
2022-08-04 11:07:00 -06:00
Travis Nielsen 03a9ebdc55 Merge pull request #10664 from yati1998/cephfs-attacher
csi: remove attacher sidecar from CephFS rook deployment
2022-08-03 09:02:47 -06:00
yati1998 4bfd88dc4d csi: remove attacher sidecar from CephFS rook deployment
CephFS CSI driver dont have/advertise controller publish/unpublish
capabilities, thus dont need attacher sidecar for its operations.
The presence of external-attacher adds on overhead and issues wrt
attachment in various scenarios. One of them would be the lack of
performance on syncing volumeattachment from api server..etc.
More or less we don't have controller publish and unpublish capabilities,
so we should not make use of this sidecar and cause
unnecessary addon here thus other issues.

similar changes have been added to CSI
https://github.com/ceph/ceph-csi/pull/3149

Signed-off-by: yati1998 <ypadia@redhat.com>
2022-08-03 19:56:39 +05:30
Blaine Gardner ec0c9a7963 Merge pull request #10668 from travisn/test-file-delete-timeout
test: Increase timeout waiting for file deletion status
2022-08-02 14:11:54 -06:00