forked from qt-creator/qt-creator
Git: fix compilation failure in Qt4 specific code.
Caused by 762099487c
where a memory pool
was introduced to fix memory leakage.
Change-Id: Ib2f7c53e9560ff473fcdfedd6dcfce50455095da
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
This commit is contained in:
committed by
Friedemann Kleint
parent
76a3007eeb
commit
0e62487fb3
@@ -664,11 +664,13 @@ static bool parseOutput(const QSharedPointer<GerritParameters> ¶meters,
|
||||
result.clear();
|
||||
result.reserve(lines.size());
|
||||
|
||||
Utils::JsonMemoryPool pool;
|
||||
|
||||
foreach (const QByteArray &line, lines) {
|
||||
if (line.isEmpty())
|
||||
continue;
|
||||
QScopedPointer<Utils::JsonValue> objectValue(Utils::JsonValue::create(QString::fromUtf8(line)));
|
||||
if (objectValue.isNull()) {
|
||||
Utils::JsonValue *objectValue = Utils::JsonValue::create(QString::fromUtf8(line), &pool);
|
||||
if (!objectValue) {
|
||||
QString errorMessage = GerritModel::tr("Parse error: '%1'")
|
||||
.arg(QString::fromLocal8Bit(line));
|
||||
qWarning() << errorMessage;
|
||||
|
Reference in New Issue
Block a user