feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AndroidManifestEditor: Fix versionCode being limited

Browse Source 
The android documentation does not require a minimum value of 1,
but suggest that "Typically, you would release the first version
of your application with versionCode set to 1". Thus keep the
minimum of 1. A maximum value is not specified.

Task-number: QTCREATORBUG-12668
Change-Id: I6bfb0a534661af82b6fcfe5667d9224893707e41
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
This commit is contained in:
Daniel Teske
2014-07-16 15:37:55 +02:00
parent a4e55cbeda
commit 1b0279955f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/android/androidmanifesteditorwidget.cpp
View File

@@ -70,6 +70,8 @@
#include <QTimer>
#include <QCheckBox>
#include <limits>
using namespace ProjectExplorer;
using namespace Android;
using namespace Android::Internal;
@@ -180,7 +182,7 @@ void AndroidManifestEditorWidget::initializePage()
m_versionCode = new QSpinBox(packageGroupBox);
m_versionCode->setMaximum(99);
m_versionCode->setMaximum(std::numeric_limits<int>::max());
m_versionCode->setValue(1);
m_versionCode->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed);
formLayout->addRow(tr("Version code:"), m_versionCode);