feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Don't set ALWAYS_SAVE_IN_CRUMBLEBAR when no changes in qml

Browse Source 
Core::DocumentManager::saveModifiedDocument doesn't set the alwaysSave
flag if there is nothing to save, which led to undefined results as
the flag was left to uninitialized state.

Change-Id: I9417775241123b9e1bb3b57b6ced96bc555fb635
Fixes: QDS-2718
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This commit is contained in:
Miikka Heikkinen
2020-09-07 13:51:00 +03:00
parent b7e660471f
commit 2387b56012
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmldesigner/components/componentcore/crumblebar.cpp
View File

@@ -135,10 +135,10 @@ Utils::CrumblePath *CrumbleBar::crumblePath()
void CrumbleBar::showSaveDialog() void CrumbleBar::showSaveDialog()
{ {
if (DesignerSettings::getValue(DesignerSettingsKey::ALWAYS_SAVE_IN_CRUMBLEBAR).toBool()) { bool alwaysSave = DesignerSettings::getValue(DesignerSettingsKey::ALWAYS_SAVE_IN_CRUMBLEBAR).toBool();
if (alwaysSave) {
Core::DocumentManager::saveModifiedDocumentSilently(currentDesignDocument()->editor()->document()); Core::DocumentManager::saveModifiedDocumentSilently(currentDesignDocument()->editor()->document());
} else { } else {
bool alwaysSave;
bool canceled; bool canceled;
Core::DocumentManager::saveModifiedDocument(currentDesignDocument()->editor()->document(), Core::DocumentManager::saveModifiedDocument(currentDesignDocument()->editor()->document(),