"foreach (QString" -> "foreach (const QString &"

Change-Id: Idb866407347722766edbc85ce20799b088ce36dd
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

src/libs/qmljs/qmljsmodelmanagerinterface.cpp

@@ -1000,7 +1000,7 @@ void ModelManagerInterface::importScan(QFutureInterface<void> &future,
             QStringList subDirs(dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot));
             workDone += 1;
             totalWork += pathBudget / 2 * subDirs.size() - pathBudget * 3 / 4 + 1;
-            foreach (const QString path, subDirs)
+            foreach (const QString &path, subDirs)
                 pathsToScan.append(ScanItem(dir.absoluteFilePath(path), toScan.depth + 1));
         } else {
             workDone += pathBudget * 3 / 4;
@@ -1040,7 +1040,7 @@ void ModelManagerInterface::maybeScan(const QStringList &importPaths,
     QStringList pathToScan;
     {
         QMutexLocker l(&m_mutex);
-        foreach (QString importPath, importPaths)
+        foreach (const QString &importPath, importPaths)
             if (!m_scannedPaths.contains(importPath)) {
                 pathToScan.append(importPath);
             }

src/plugins/android/androiddeployqtstep.cpp

@@ -247,7 +247,7 @@ void AndroidDeployQtStep::run(QFutureInterface<bool> &fi)
 
     ProjectExplorer::ProcessParameters *pp = processParameters();
     QString args;
-    foreach (const QString arg, AndroidDeviceInfo::adbSelector(m_serialNumber))
+    foreach (const QString &arg, AndroidDeviceInfo::adbSelector(m_serialNumber))
         Utils::QtcProcess::addArg(&args, arg);
 
     Utils::QtcProcess::addArg(&args, QLatin1String("install"));

src/plugins/beautifier/abstractsettings.cpp

@@ -196,7 +196,7 @@ void AbstractSettings::save()
     }
 
     // remove old files
-    foreach (const QString file, m_stylesToRemove)
+    foreach (const QString &file, m_stylesToRemove)
         m_styleDir.remove(file);
     m_stylesToRemove.clear();
 
@@ -239,7 +239,7 @@ void AbstractSettings::read()
     s->beginGroup(QLatin1String(Constants::SETTINGS_GROUP));
     s->beginGroup(m_name);
     const QStringList keys = s->allKeys();
-    foreach (const QString key, keys) {
+    foreach (const QString &key, keys) {
         if (key == QLatin1String("command"))
             setCommand(s->value(key).toString());
         else if (m_settings.contains(key))
@@ -259,7 +259,7 @@ void AbstractSettings::read()
     const QStringList files
             = m_styleDir.entryList(QStringList() << QLatin1Char('*') + m_ending,
                                    QDir::Files | QDir::Readable | QDir::NoDotAndDotDot);
-    foreach (const QString filename, files) {
+    foreach (const QString &filename, files) {
         // do not allow empty file names
         if (filename == m_ending)
             continue;

src/plugins/clearcase/activityselector.cpp

@@ -87,7 +87,7 @@ bool ActivitySelector::refresh()
     int current;
     QList<QStringPair> activities = m_plugin->activities(&current);
     m_cmbActivity->clear();
-    foreach (QStringPair activity, activities)
+    foreach (const QStringPair &activity, activities)
         m_cmbActivity->addItem(activity.second, activity.first);
     m_cmbActivity->setCurrentIndex(current);
     m_cmbActivity->updateGeometry();

src/plugins/cmakeprojectmanager/makestep.cpp

@@ -140,7 +140,7 @@ void MakeStep::activeBuildConfigurationChanged()
 void MakeStep::buildTargetsChanged()
 {
     QStringList filteredTargets;
-    foreach (const QString t, static_cast<CMakeProject *>(project())->buildTargetTitles()) {
+    foreach (const QString &t, static_cast<CMakeProject *>(project())->buildTargetTitles()) {
         if (m_buildTargets.contains(t))
             filteredTargets.append(t);
     }

src/plugins/qmakeprojectmanager/qmakenodes.cpp

@@ -978,7 +978,7 @@ bool QmakePriFileNode::addFiles(const QStringList &filePaths, QStringList *notAd
     typedef QMap<QString, QStringList> TypeFileMap;
     // Split into lists by file type and bulk-add them.
     TypeFileMap typeFileMap;
-    foreach (const QString file, filePaths) {
+    foreach (const QString &file, filePaths) {
         const Core::MimeType mt = Core::MimeDatabase::findByFile(file);
         typeFileMap[mt.type()] << file;
     }
@@ -1025,7 +1025,7 @@ bool QmakePriFileNode::removeFiles(const QStringList &filePaths,
     typedef QMap<QString, QStringList> TypeFileMap;
     // Split into lists by file type and bulk-add them.
     TypeFileMap typeFileMap;
-    foreach (const QString file, filePaths) {
+    foreach (const QString &file, filePaths) {
         const Core::MimeType mt = Core::MimeDatabase::findByFile(file);
         typeFileMap[mt.type()] << file;
     }

src/plugins/qnx/blackberrysigningutils.cpp

@@ -244,7 +244,7 @@ void BlackBerrySigningUtils::saveDebugTokens()
     settings->beginGroup(DebugTokensGroup);
 
     int count = 0;
-    foreach (QString dt, m_debugTokens) {
+    foreach (const QString &dt, m_debugTokens) {
         settings->beginGroup(QString::fromLatin1("debugToken_%1").arg(++count));
         settings->setValue(DebugTokensPath, dt);
         settings->endGroup();

src/plugins/qnx/cascadesimport/projectfileconverter.cpp

@@ -94,11 +94,11 @@ static QString updateVariable(const QString &varStr, const QString &varsToAdd,
     QSet<QString> var = parseVariable(varStr);
 
     QSet<QString> ss = parseVariable(varsToAdd);
-    foreach (QString s, ss)
+    foreach (const QString &s, ss)
         var << s;
 
     ss = parseVariable(varsToRemove);
-    foreach (QString s, ss)
+    foreach (const QString &s, ss)
         var.remove(s);
 
     QStringList sl = QStringList::fromSet(var);

src/plugins/winrt/winrtpackagedeploymentstep.cpp

@@ -96,7 +96,7 @@ bool WinRtPackageDeploymentStep::init()
                 raiseError(tr("Cannot parse manifest file %1.").arg(fullManifestPath));
                 return false;
             }
-            foreach (QString icon, iconsToDeploy) {
+            foreach (const QString &icon, iconsToDeploy) {
                 m_mappingFileContent += QLatin1Char('"')
                         + QDir::toNativeSeparators(targetDir + icon) + QLatin1String("\" \"")
                         + QDir::toNativeSeparators(icon) + QLatin1String("\"\n");