feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Replace local lambda with static method

Browse Source 
No need to create lambda on every call to credentialKey().
This should remove the warning about the
Performance inefficiencies (AUTO_CAUSES_COPY).

Change-Id: I9a7dc9cabcc6f80e58e39ef8be6a5445a11e0433
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Jarek Kobus
2024-03-11 15:05:38 +01:00
parent d30f97ac7e
commit 54205c1b62
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/axivion/axivionplugin.cpp
View File

@@ -119,13 +119,15 @@ static QString apiTokenDescription()
return "Automatically created by " + ua + " on " + user + "@" + QSysInfo::machineHostName();
}
static QString escapeKey(const QString &string)
{
QString escaped = string;
return escaped.replace('\\', "\\\\").replace('@', "\\@");
}
static QString credentialKey()
{
const auto escape = [](const QString &string) {
QString escaped = string;
return escaped.replace('\\', "\\\\").replace('@', "\\@");
};
return escape(settings().server.username) + '@' + escape(settings().server.dashboard);
return escapeKey(settings().server.username) + '@' + escapeKey(settings().server.dashboard);
}
template <typename DtoType>