feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PE: Do not use setVisible() before having a parent

Browse Source 
Fixes shortly popping up floating widget on the Build & Run
settings page.

Change-Id: I8bcc887ae73b9cb27f690548d0e98038fb757674
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2022-10-20 12:16:52 +02:00
parent c72a93599d
commit 6cc47de5b1
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/projectexplorer/projectexplorersettingspage.cpp
View File

@@ -107,7 +107,6 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) :
m_terminalModeComboBox->addItem(tr("Deduced from Project"));
m_terminalModeComboBox->setSizePolicy(cbSizePolicy);
m_jomCheckbox = new QCheckBox(tr("Use jom instead of nmake"));
m_jomCheckbox->setVisible(HostOsInfo::isWindowsHost());
auto jomLabel = new QLabel("<i>jom</i> is a drop-in replacement for <i>nmake</i> which "
"distributes the compilation process to multiple CPU cores. "
"The latest binary is available at "
@@ -115,7 +114,6 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) :
"http://download.qt.io/official_releases/jom/</a>. "
"Disable it if you experience problems with your builds.");
jomLabel->setWordWrap(true);
jomLabel->setVisible(HostOsInfo::isWindowsHost());
using namespace Utils::Layouting;
Column {
@@ -155,6 +153,9 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) :
st,
}.attachTo(this);
m_jomCheckbox->setVisible(HostOsInfo::isWindowsHost());
jomLabel->setVisible(HostOsInfo::isWindowsHost());
m_directoryButtonGroup = new QButtonGroup;
m_directoryButtonGroup->setExclusive(true);
m_directoryButtonGroup->addButton(m_currentDirectoryRadioButton, UseCurrentDirectory);