forked from qt-creator/qt-creator
PerfProfiler: Replace essential with reverse dependency
Having both: perfParserWorker -> perfRecordWorker and perfRecordWorker -> perfParserWorker dependencies have the same effect as "essential" property. This may fix the QdbPerfProfilerWorkerFactory case when stopping the recorded didn't necessarily stopped the parser. Change-Id: I8884deb453bffd65a84a2ba722924ff8352517ab Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
@@ -108,10 +108,6 @@ public:
|
||||
runner->setEnvironment(runControl->environment());
|
||||
runControl->appendMessage("Starting Perf: " + cmd.toUserOutput(), NormalMessageFormat);
|
||||
});
|
||||
|
||||
// In the local case, the parser won't automatically stop when the recorder does. So we need
|
||||
// to mark the recorder as essential, too.
|
||||
runner->setEssential(true);
|
||||
return runner;
|
||||
});
|
||||
|
||||
@@ -143,6 +139,7 @@ public:
|
||||
|
||||
perfParserWorker->addStartDependency(perfRecordWorker);
|
||||
perfParserWorker->addStopDependency(perfRecordWorker);
|
||||
perfRecordWorker->addStopDependency(perfParserWorker);
|
||||
PerfProfilerTool::instance()->onWorkerCreation(runControl);
|
||||
|
||||
auto tool = PerfProfilerTool::instance();
|
||||
|
Reference in New Issue
Block a user