feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PerfProfiler: Replace essential with reverse dependency

Browse Source 
Having both:
perfParserWorker -> perfRecordWorker and
perfRecordWorker -> perfParserWorker dependencies
have the same effect as "essential" property.

This may fix the QdbPerfProfilerWorkerFactory case when stopping
the recorded didn't necessarily stopped the parser.

Change-Id: I8884deb453bffd65a84a2ba722924ff8352517ab
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2025-01-17 10:40:55 +01:00
parent f218886cbc
commit 7c0ab5a40b
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/perfprofiler/perfprofilerruncontrol.cpp
View File

@@ -108,10 +108,6 @@ public:
runner->setEnvironment(runControl->environment()); runner->setEnvironment(runControl->environment());
runControl->appendMessage("Starting Perf: " + cmd.toUserOutput(), NormalMessageFormat); runControl->appendMessage("Starting Perf: " + cmd.toUserOutput(), NormalMessageFormat);
}); });
// In the local case, the parser won't automatically stop when the recorder does. So we need
// to mark the recorder as essential, too.
runner->setEssential(true);
return runner; return runner;
}); });
@@ -143,6 +139,7 @@ public:
perfParserWorker->addStartDependency(perfRecordWorker); perfParserWorker->addStartDependency(perfRecordWorker);
perfParserWorker->addStopDependency(perfRecordWorker); perfParserWorker->addStopDependency(perfRecordWorker);
perfRecordWorker->addStopDependency(perfParserWorker);
PerfProfilerTool::instance()->onWorkerCreation(runControl); PerfProfilerTool::instance()->onWorkerCreation(runControl);
auto tool = PerfProfilerTool::instance(); auto tool = PerfProfilerTool::instance();