feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Remove note in settings dialog that does not apply anymore

Browse Source 
Change-Id: I54e86ad419c09acc7ebd15bb4b2660d159c410f0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2021-03-19 14:46:09 +01:00
parent aa69415ac7
commit 8d6cb35b74
2 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/git/gitsettings.cpp
View File

@@ -132,18 +132,6 @@ GitSettings::GitSettings()
refLogShowDate.setSettingsKey("RefLogShowDate");
timeout.setDefaultValue(Utils::HostOsInfo::isWindowsHost() ? 60 : 30);
note.setText(tr("<b>Note:</b>") + tr("Git needs to find Perl in the environment."));
const auto updateNoteField = [this] {
Environment env = Environment::systemEnvironment();
env.prependOrSetPath(path.value());
const bool showNote = env.searchInPath("perl").isEmpty();
note.setVisible(showNote);
};
updateNoteField();
QObject::connect(&path, &BaseAspect::changed, &note, updateNoteField);
}
FilePath GitSettings::gitExecutable(bool *ok, QString *errorMessage) const

1
src/plugins/git/gitsettings.h
View File

@@ -63,7 +63,6 @@ public:
Utils::BoolAspect followRenames;
Utils::IntegerAspect lastResetIndex;
Utils::BoolAspect refLogShowDate;
Utils::TextDisplay note;
Utils::FilePath gitExecutable(bool *ok = nullptr, QString *errorMessage = nullptr) const;
};