feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove ArgumentsAspect::argumentsChanged signal

Browse Source 
The base Aspect::changed() is good enough.

Change-Id: Ib660e06cf4240198f7f73948ea0922a11568d4a2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-09-09 17:58:47 +02:00
parent ec75575e64
commit da5852a3b3
4 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/boot2qt/qdbrunconfiguration.cpp
View File

@@ -63,7 +63,7 @@ public:
+ ' ' + usedExecutable + ' ' + args); + ' ' + usedExecutable + ' ' + args);
}; };
connect(argumentsAspect, &ArgumentsAspect::argumentsChanged, this, updateCommandLine); connect(argumentsAspect, &ArgumentsAspect::changed, this, updateCommandLine);
connect(exeAspect, &ExecutableAspect::changed, this, updateCommandLine); connect(exeAspect, &ExecutableAspect::changed, this, updateCommandLine);
updateCommandLine(); updateCommandLine();
} }

2
src/plugins/nim/project/nimblebuildstep.cpp
View File

@@ -120,7 +120,7 @@ NimbleBuildStep::NimbleBuildStep(BuildStepList *parentList, Id id)
QTC_ASSERT(buildConfiguration(), return); QTC_ASSERT(buildConfiguration(), return);
QObject::connect(buildConfiguration(), &BuildConfiguration::buildTypeChanged, QObject::connect(buildConfiguration(), &BuildConfiguration::buildTypeChanged,
m_arguments, &ArgumentsAspect::resetArguments); m_arguments, &ArgumentsAspect::resetArguments);
QObject::connect(m_arguments, &ArgumentsAspect::argumentsChanged, QObject::connect(m_arguments, &ArgumentsAspect::changed,
this, &NimbleBuildStep::onArgumentsChanged); this, &NimbleBuildStep::onArgumentsChanged);
} }

2
src/plugins/projectexplorer/runconfigurationaspects.cpp
View File

@@ -281,7 +281,7 @@ void ArgumentsAspect::setArguments(const QString &arguments)
{ {
if (arguments != m_arguments) { if (arguments != m_arguments) {
m_arguments = arguments; m_arguments = arguments;
emit argumentsChanged(arguments); emit changed();
} }
if (m_chooser && m_chooser->text() != arguments) if (m_chooser && m_chooser->text() != arguments)
m_chooser->setText(arguments); m_chooser->setText(arguments);

3
src/plugins/projectexplorer/runconfigurationaspects.h
View File

@@ -113,9 +113,6 @@ public:
void setResetter(const std::function<QString()> &resetter); void setResetter(const std::function<QString()> &resetter);
void resetArguments(); void resetArguments();
signals:
void argumentsChanged(const QString &arguments);
private: private:
void fromMap(const QVariantMap &map) override; void fromMap(const QVariantMap &map) override;
void toMap(QVariantMap &map) const override; void toMap(QVariantMap &map) const override;