feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: make sure there is no nullptr buildConfiguration

Browse Source 
This caused a crash in QtDesinStudio calling the preview in buildmanager.cpp:

  for (const BuildConfiguration * const bc
    : buildConfigsForSelection(target, configSelection)) {
        bsl = isBuild ? bc->buildSteps() : bc->cleanSteps(); //bc was nullptr here

Change-Id: I67d165adb1b81c1b68fbc6fb38b67d4d2887eed1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tim Jenssen
2020-01-28 10:56:34 +01:00
parent 5c13c7ae7b
commit db01563fda
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/buildmanager.cpp
View File

@@ -81,7 +81,9 @@ static const QList<BuildConfiguration *> buildConfigsForSelection(const Target *
{
if (configSelection == ConfigSelection::All)
return target->buildConfigurations();
return {target->activeBuildConfiguration()};
else if (target->activeBuildConfiguration())
return {target->activeBuildConfiguration()};
return {};
}
static int queue(const QList<Project *> &projects, const QList<Id> &stepIds,