feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Remove 'dllimport' attribute warning

Browse Source 
By having the function body in the class we automatically get the
same inline functionality and get rid of the warnings below on LLVM
Clang 13.

src/plugins\coreplugin/find/ifindsupport.h:71:27: warning:
 'Core::IFindSupport::highlightAll' redeclared inline; 'dllimport'
 attribute ignored [-Wignored-attributes]

Change-Id: I0daa6412678090f45bdfb6401157cb68bcb0241f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Cristian Adam
2021-09-02 13:57:42 +02:00
parent ebae255e49
commit e203581956
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/coreplugin/find/ifindsupport.h
View File

@@ -49,7 +49,7 @@ public:
virtual QString currentFindString() const = 0;
virtual QString completedFindString() const = 0;
virtual void highlightAll(const QString &txt, FindFlags findFlags);
virtual void highlightAll(const QString &txt, FindFlags findFlags) {}
virtual Result findIncremental(const QString &txt, FindFlags findFlags) = 0;
virtual Result findStep(const QString &txt, FindFlags findFlags) = 0;
virtual void replace(const QString &before, const QString &after,
@@ -68,6 +68,4 @@ signals:
void changed();
};
inline void IFindSupport::highlightAll(const QString &, FindFlags) {}
} // namespace Core