feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Fix conversion warning in tests

Browse Source 
mock-matchers.h:204:60: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
   bool operator()(const A& a, const B& b) const { return a == b; }
                                                             ~~^~~~

Change-Id: I58883118e1eb42f2e0129b760cdce07daf4ac8d3
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Nikolai Kosjar
2017-06-14 14:44:09 +02:00
parent ae485ac551
commit f9f10a1e32
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unit/unittest/clangcompletecodejob-test.cpp
View File

@@ -79,7 +79,8 @@ TEST_F(CompleteCodeJob, ForwardTicketNumber)
job.setContext(jobContextWithMockClient);
job.prepareAsyncRun();
EXPECT_CALL(mockIpcClient,
codeCompleted(Property(&CodeCompletedMessage::ticketNumber, Eq(99))))
codeCompleted(Property(&CodeCompletedMessage::ticketNumber,
Eq(jobRequest.ticketNumber))))
.Times(1);
job.runAsync();

2
tests/unit/unittest/clangrequestreferencesjob-test.cpp
View File

@@ -79,7 +79,7 @@ TEST_F(RequestReferencesJob, ForwardTicketNumber)
job.setContext(jobContextWithMockClient);
job.prepareAsyncRun();
EXPECT_CALL(mockIpcClient,
references(Property(&ReferencesMessage::ticketNumber, Eq(99))))
references(Property(&ReferencesMessage::ticketNumber, Eq(jobRequest.ticketNumber))))
.Times(1);
job.runAsync();