Commit Graph

85691 Commits

Author SHA1 Message Date
hjk
e02de2ddde ProjectExplorer: More KitAspect related renamings
Change-Id: I10ad7aacaaf7346f91cadec479f4bba8481b1502
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-16 15:09:32 +00:00
hjk
aa093c1e91 Axivion: Move query error handling closer to query code
Change-Id: I6c57c0578b284f20e23312bf748c5efbe0ac3c3e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-16 13:26:55 +00:00
Christian Stenger
397cd1ba3d AutoTest: Fix using target information after kit change
Fixes: QTCREATORBUG-29477
Change-Id: I5d1f8d65ed074d912740b87eac1c7d4413ed2588
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-16 13:26:24 +00:00
Jarek Kobus
19bc9e69c9 ValgrindRunner: Inline some slots
Change-Id: I29b099694fd0cbbd29bbd34362f2d93074b125d1
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 13:11:03 +00:00
Jarek Kobus
89343f6574 ValgrindRunner: Store the input data outside of the process
Apply it when process is started. This is a preparation
step before employing the task tree inside the ValgrindRunner.

Change-Id: I4cb64ef72b353af7ca97ae61fded23d9cea5e365
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 12:20:56 +00:00
Jarek Kobus
604cf67a0c ValgrindRunner: Get rid of valgrindExecuted() signal
Use appendMessage() signal instead.

Change-Id: I2beb70d1c9f59e6b8b3b1ad03ec7707d67aa50cd
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 12:20:50 +00:00
Jarek Kobus
74c7ec35bc ValgrindRunner: Establish connections in private c'tor
Change-Id: I3238c1dc09008484b270a0904688bc4a7b6e10cc
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 12:20:44 +00:00
Jarek Kobus
054394eec2 Valgrind: Add task adapter for Parser
Change-Id: I164305299edf4ce3c665034c7c1f8d7ad2ee9b66
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 12:20:38 +00:00
hjk
6f2b237ecf ProjectExplorer: Change KitManager::sortKits()
... to sortedKits(). Simplifies the caller side and saves one temporary
container.

Change-Id: Id87a1ba0779e6f09cd6575808c4d05c126900f0f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-16 10:58:41 +00:00
Amr Essam
ce8423a42b QmlDesigner: Create the CompositionNode class
This one is used to represent an effect with its attributes while editing the current composition.
Also some refactoring to remove the composition properties from EffectNode.

Change-Id: Idd0137db98cb608f3ead49ba3208e4480a185e88
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-08-16 10:53:44 +00:00
hjk
c40a802e70 ProjectExplorer: Postpone set up of kit save connection
Does not require early access to ICore::instance(), and there's
no point in attempting to save kits before they werde set up.

Change-Id: I68953c6019e14e88655ddb46b30ebb9f1916ec46
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-16 10:50:02 +00:00
hjk
f21282cb2d ProjectExplorer: Simplify KitManagerPrivate access
Change-Id: Ia4e97a93899c7cd90d97a4cfaa6098cd2b395cc8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-16 10:38:47 +00:00
Thomas Hartmann
c78e0965c0 QmlDesigner: Implement transient scrollbar for widgets in studiostyle
Task-number: QDS-9556
Task-number: QDS-10368
Task-number: QDS-10385
Change-Id: Idcbc70db3075f7741a754376580f48d7df40e67a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-08-16 10:28:40 +00:00
hjk
fa011af1a0 ProjectExplorer: Avoid early creation of KitManager
This was only meant as part of a safety net, but in the case that
the situation this was guarding against actually happens we'd also
notice by simply not seeing the effect. This is not different to
any other place in the code where we e.g. create objects/widgets/...
and don't put them in the right container.

Change-Id: I0700fd3ca235662b718cf01229211a4eebec8a9a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-16 10:17:35 +00:00
Tim Jenssen
98a28d30bc QmlDesigner: fix LESS_EQUAL -> GREATER_EQUAL Qt 6.4.3 check
Change-Id: I4718e1afa555164d1b41e8f577a915d915187e30
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-08-16 10:16:37 +00:00
Christian Stenger
b79ffcf8a2 Copilot: Fix qbs build
Change-Id: I2fad66854b69345150fdd19fa7da18125f8590d9
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 08:57:26 +00:00
hjk
e9c1901bad Core: Use an aspect for the Patch tool path setting
Change-Id: Ifc758fb4ac5d00a7b755ea06f3f6b98d53e7cc46
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-16 08:57:09 +00:00
hjk
cf35cf326b ProjectExplorer: Use some better names for local variables
In KitManagerConfigWidget, plus a bit of style cleanup.

Change-Id: I6e28f697267c5e51d95a734cb2fe989346ac016b
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-16 08:37:47 +00:00
Jarek Kobus
0ad7ec4518 RunWorker: Remove unused method
Change-Id: I02da4d0336949c24000a70a6f4364fe80b14dae8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-16 08:34:13 +00:00
hjk
2a07253a42 Debugger: Rename debuggerkitinformation.{cpp,h}
... to debuggerkitaspect.{cpp,h}

Change-Id: Ia6316fcdc893ca066933658a52c78ef1587a76e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-16 07:33:43 +00:00
David Schulz
1036c776f5 CMake: add environment variable for ccache support
Add another environment variable whether CMake should check for ccache
and adjust the compiler options accordingly when building Qt Creator.

Change-Id: I796f29d7f6ad4a1f054f978d50dbd0120b873aea
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-16 07:29:09 +00:00
hjk
a3b93481da Debugger: Hide KitAspectFactory
Change-Id: If98f4598efb273852a602a9ed7379341a3720a60
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-16 07:27:10 +00:00
Marcus Tillmanns
ae51ad8c92 Copilot: Move to Settings::setLayouter()
Change-Id: I1d7d9872f12aa5436f03107bdd5fedfbe2829700
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:55:06 +00:00
Marcus Tillmanns
f2d62c6d91 Copilot: Add support for proxy settings
For easier testing a docker file is added. You can start
"buildandrun.sh" in copilot/tests/proxy to get a simple
proxy server up and running. The argument "PWDMODE" in
buildandrun.sh can be set to "with" and "without" to get
a proxy server that needs a password or not. The username
and password are user/1234.

Fixes: QTCREATORBUG-29485
Change-Id: I3859c9ad04ebd4f9349e25665ba710e23fb64dea
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:54:54 +00:00
Christian Stenger
91596316f2 WinPty: Fix qbs build on Windows
Change-Id: I993fa3c8d9bc364c00e9e9eedba021a7432d908f
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:49:48 +00:00
hjk
f53e18ee73 Test: Avoid some Id::withSuffix calls
Saves cycles and is arguably clearer.

Change-Id: Ib53207704806d4b6ea184633a15ab98fb2eeb89a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-16 06:06:55 +00:00
Tim Jenssen
91a931dd21 QmlDesigner: build it only if Qt is GREATER_EQUAL 6.4.3
Change-Id: Iccd05a7d4f4ace47fd9398bdc78584e3919ec595
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-08-15 18:57:48 +00:00
Marco Bubke
0f7462ad24 QmlDesigner: Fix dependency
Change-Id: Iccf3f80e9dd5c9a9dc49c363f9099352732bab60
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-08-15 16:14:33 +00:00
hjk
0690b65abc LanguageServer: Compile fix for Qt 6.2
QLatin1StringView ist ein alias fuer QLatin1String, aber erst ab 6.4

Change-Id: I9b04d39722bf2707c327c6596a4bfe9ee719bae8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-15 16:04:47 +00:00
Marco Bubke
007467898b QmlDesigner: Fix crash for missing null pointer check
Change-Id: I49e971ee9037847dcaa591e98fa8933cff162658
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-08-15 15:46:39 +00:00
Marco Bubke
f4492f567b QmlDesigner: Fix qml file name filter
Change-Id: I40b40a4c6235566830510b244752ec120759f500
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-08-15 15:19:26 +00:00
Marco Bubke
dadb9074ed UnitTests: Improve matcher
It should work for pointer and non pointer.

Change-Id: Ib80a58874282191b0cbaa576e8846f43d674ce9d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-15 15:18:28 +00:00
Marco Bubke
c24ae64411 QmlDesigner: Remove useless semicolon
Change-Id: I3b829ac7a050dfaf1f0ea75e9bef68155930bf60
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-08-15 15:15:39 +00:00
Ali Kianian
0f9a6a2ccc QmlDesigner: Use Designer icons for 3d view toolbar
Designer Icons are updated for the toolbar usage.
Disabled colors are changed for the View 3D toolbar.

Task-number: QDS-10044
Change-Id: I98e7e43d39af4d57a1527fd1a9600c964e49114c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 13:56:10 +00:00
Ali Kianian
86d4fbab79 QmlDesigner: Import only mandatory libraries or directories
Only mandatory files are imported by the newly created component.
In the case that the import data is empty, All parent imports would be
included.

Task-number: QDS-9829
Change-Id: Ie96e2bc04a10e00b15ae12c5e58b5dc2392886ae
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-15 13:55:49 +00:00
hjk
5aa138bb68 ProjectExplorer: Hide some KitAspectFactory implementations
Change-Id: If84dd7aeb72e87d2cb35635689ad1c9c2e09a825
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 13:49:59 +00:00
Mahmoud Badri
e2f5b37fce QmlDesigner: Add 3 icons to the icon font
added icons: help, drag marks, and code.

Fixes: QDS-10459
Change-Id: I87c7e28d8858e49c98a4e9e2d991ee5d87df5a23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 13:44:09 +00:00
Marcus Tillmanns
02e2a642dc ProcessStub: Add missing if
When not starting in debug mode, the inferior is not waiting
for ptrace(DETACH), so the code that calls DETACH waits for
something that does not happen.

Fixes: QTCREATORBUG-29503
Change-Id: Ic00a52b9e4f3a797d1be337a2ce53afc6ee63927
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-15 13:32:45 +00:00
Marcus Tillmanns
013b71b301 Utils: Allow cascaded aspect "setEnabler"
Change-Id: I4e519c0ef27460b42c4e44a755e5e6cbbf49ebdf
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 13:30:06 +00:00
Marcus Tillmanns
bc1ab260b4 Utils: Add password input dialog
Task-number: QTCREATORBUG-29485
Change-Id: I2b55e7d39f848f1c89d3a365a2cadd44e8aac97c
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 13:17:19 +00:00
Mahmoud Badri
bf6ea8496a QmlDesigner: Refactor Effect maker nodes view
Also add node click handler

Change-Id: I4b4e327f5c69f27d64ef2f2c3d13628aea46f0af
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 13:08:33 +00:00
hjk
123793fbb1 Utils: Add an 'If' LayoutItem
Change-Id: I700e28d03b6dc39e96fa969152f236760989bdb7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 13:03:11 +00:00
Marcus Tillmanns
b0d5e44235 Utils: Add Password display to StringAspect
Task-number: QTCREATORBUG-29485
Change-Id: I8da46be4c63f97595aa1e93b6ac4905bdbb54799
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 13:02:31 +00:00
hjk
876d9fb1e0 ProjectExplorer: Separate KitAspectFactory storage from live kits
Change-Id: Ic4d4f4938a11e209c31dcba73d1a793d359fe135
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 12:54:05 +00:00
Jarek Kobus
d6068c3ce5 TaskTree: Make TreeStorage final
Allow TreeStorageBase to be subclasses only by TreeStorage.

Change-Id: I6e119d6b6f2f99cc7846752cf55f9fb92f3834c7
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 12:46:46 +00:00
Tim Jenssen
8812c1816b Merge remote-tracking branch 'origin/11.0' into qds/dev
Change-Id: I23063e42621b272bd4b04a06746955e6b5768b49
2023-08-15 12:32:47 +00:00
Marco Bubke
a7987380cd QmlDesigner: Silence bogus warning by Clang
The parens are needed by the fold expression.

Change-Id: Ib53596f2be2f3bcdb6040c1690f5f6dfe6249583
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2023-08-15 12:31:00 +00:00
Mehdi Salem
10feedf9de Axivion: integrate generated DTOs
We are not yet making use of the integrated DTOs as this will happen
in a future commit along with the network requests to fetch the data.

Change-Id: I72cf9005cae052c41a7e906e0fae5dbe176e0882
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
2023-08-15 11:35:02 +00:00
Marcus Tillmanns
5ae116618e Tracing: Remove useless code
runSceneGraphTest() did nothing but create an opengl context and
offscreen surface. It did nothing with the provided QSGNode.
The only thing it does is make the test fail if the opengl context
can't be created for instance on test machines without opengl.

Change-Id: I376c3565f5afcee6e123a7ef8b9832e679e645a0
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-08-15 11:04:36 +00:00
hjk
9b18e73fac Utils: Switch FileIconProviderImplementation::icon() overloads
The FilePath based one seems to be called primarily, so make that
the primary implementation, saving a FilePath <-> QFileInfo round trip.

Change-Id: Ib3427a5168e559b8a583570ac1c82dfe658644da
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 10:52:16 +00:00