Commit Graph

85691 Commits

Author SHA1 Message Date
Christian Kandeler
66a6cceaf4 CppEditor: Fix possible null pointer access
Fixes: QTCREATORBUG-29484
Change-Id: I047ea13e6808902a3b0fb94b9eacdd48e411a22a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-10 13:48:39 +00:00
David Schulz
b128c585d9 TextEditor: render suggestion with the tab width of the editor
Fixes: QTCREATORBUG-29483
Change-Id: Id8da019130055ce40bd639d038eb1e74d9787884
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-10 13:37:33 +00:00
hjk
0a3aad0093 Debugger: Name KitAspect related classes more similar to their bases
Change-Id: I2f18f382ccedfde343c72f8a9562f900faa43756
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 13:03:27 +00:00
hjk
fde372b81e ProjectExplorer: Rename KitAspect related classes
KitAspect -> KitAspectFactory
KitAspectWidget -> KitAspect

KitAspect::createConfigWidget() -> KitAspectFactory::createKitAspect()

Possibly not perfect yet, but closer to what it does and is.

There will be follow-ups to rename derived classes.

Change-Id: I226f6f025f1e6462c348b68663f776f5a2e8c42d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 13:03:21 +00:00
Jarek Kobus
26853ee7a9 Creator: Block the usage of foreach in qbs build
Change-Id: If1fc3a69505cf8c2b7e931861a07991643d5e8d5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 12:51:10 +00:00
Christian Kandeler
88dc7cf7e0 Debugger: Fix qbs build
Change-Id: I660bfd4053ef52881c9a64f1492631819321d2c1
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 12:31:18 +00:00
Christian Kandeler
b3c7e3abd6 Valgrind: Fix build
Amends ec53435e04.

Change-Id: Iaee2b355a98bf92c94bd66a8a615befec08b11c3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 12:31:05 +00:00
Marcus Tillmanns
973f74bad3 Tests: Add NEEDS_GUI flag to add platform argument
Tests that create a QApplication need to be started with
"-platform minimal" so that they won't fail on build servers
without Display.

This also keeps them from distracting you if you run them while working.

Change-Id: I05df258b2204a3abd3cdea446d6a52f3e57a4a62
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-10 12:15:12 +00:00
Jarek Kobus
2732b6e939 Creator: Block the usage of foreach
Change-Id: I5557b1eccb8bd1e4acdc519ded799ce21c5be45e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-10 11:44:42 +00:00
Marcus Tillmanns
cb50a67521 Utils: Fix FilePath tests
Change-Id: I2751cd9393baa836715f778a9bcbc47a445c264c
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 10:48:40 +00:00
hjk
3ad1a6ecdd Revert "Utils: Allow (encoded) colons in host parts of FilePath"
This reverts commit f65b343c8a.

It's not needed anymore for the problem it was supposed to help with
(bad docker imange/qmake paths written by sdktool) and complicates
reasoning in this area.

Change-Id: Idef2ef9147d73e83461589907aa68c09721755cb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-10 10:36:03 +00:00
hjk
256ee1c05a Perforce: Inline PerforcePluginPrivate::applySettings
... into its only user, hope is to move it into the settings proper
at some time.

Change-Id: I5877e7e19f4c3ef0ad5dba2761b12545ab59a1e8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 09:25:54 +00:00
Jarek Kobus
98aacfd688 Debugger tests: Bump min cpp version to 17
Change-Id: I0fa3c153d1533f7f0390134d4b046e00c0368d9d
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 09:24:20 +00:00
David Schulz
d2434d90dc ProjectExplorer: prefer git ssh over windows ssh
In contrast to the git provided ssh the current ssh provided in windows
ignores the SSH_ASKPASS environment variable. So we should prefer the
implementation of git. This was done correctly in previous versions of
Qt Creator since Environment::searchInPath first went through the
additional provided directories before looking into the PATH environment
variable. This behavior changed in 11.0 and now we look first into the
entries of PATH.

Change-Id: I4f3c21866d2d1a5151998fd527978ed482946ef8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 08:42:25 +00:00
Christian Kandeler
9fc53ef745 RemoteLinux: Do not reject sftp deployment when no info is available
We would set up a non-working deploy configuration for devices that
existed before 11.0.
Amends 3cd0dad3d4.

Change-Id: If9d79207c9781e158635e35e211c0071109101db
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 08:22:30 +00:00
Jarek Kobus
bce2dde117 Valgrind test: Use Utils::Process instead of QProcess
Change-Id: Id7a0611fd7d36adc22993f50cce87cd30c6a336c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-10 08:19:33 +00:00
Marcus Tillmanns
f13d9cc736 ProcessStub: Wait for detach to finish
Without calling waitpid() after detaching from the inferior
a race condition could occur where the ptrace(...) call would
finish before it was actually detached, leading to the following
gdb to fail attaching as the stub was still attached to it.

Calling waitpid here solves the race condition.

Fixes: QTCREATORBUG-29463
Change-Id: Ia1d79a18a96078bbf72589bebbc7d7ac027dea0d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-10 08:14:29 +00:00
hjk
0be0772fc9 Merge remote-tracking branch 'origin/11.0'
Change-Id: Ib67c8ecb1865ee31ca6485c9287039ba877c68cd
2023-08-10 10:03:04 +02:00
hjk
0e4710b708 BareMetal: Move some code from *.h to *.cpp
Change-Id: I4acedd7ca6c27e371fe2c651e0d769591bed99ff
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 07:58:16 +00:00
Mahmoud Badri
63dd551b06 QmlDesigner: Add effect maker nodes popup window
Barebone combobox custom popup implementation. This allows the popup to
extend outside the Qml limits. Window content to be implemented
separately.

Task-number: QDS-10403
Change-Id: Ic59d6a8436630d1dcd76063425ce311e5bdff190
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-10 07:57:33 +00:00
hjk
cf0cf0fa9b Debugger: Make DebuggerItemManager a namespace
It had only static functions left.

Change-Id: If0c76373a8428ae7015017b4644e3f974e14a36e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 07:52:58 +00:00
Marcus Tillmanns
8ac37d3df4 Qt: Fix slow options page
For remote devices, reading and parsing all the information
of a qt version, can take a long time. This patch delays the read
until the user actually opens the details widget.

Change-Id: I7bd34d05acc8d01f17609996e84630f958091b3a
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 04:41:57 +00:00
Aaron Barany
d1deeb2c0d App: Use PassThrough high DPI rounding policy
When high DPI is enabled, use PassThrough rounding policy to allow
for fractional scaling without having to manually set an environment
variable.

The high DPI setting is now respected even if various Qt scale/ratio
environment variables are set, which is the case in valid default
situations such as setting the global scaling factor for KDE Plasma.

Task-number: QTCREATORBUG-29461
Change-Id: Ife2820d205b3440646255dc997744b2b8867bc70
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-09 18:50:44 +00:00
Christian Kandeler
9c2527eea6 QmakeProjectManager: Do not run the clean steps spuriously
Amends c732667838.

Fixes: QTCREATORBUG-29451
Fixes: QTCREATORBUG-29481
Change-Id: Ib79977d49ec7650f025887ec956efde45a8efb7c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-09 16:03:51 +00:00
Burak Hancerli
e7fa015a4c QmlProjectManager: Fix for absolute import path problem
Task-number: QDS-10145
Change-Id: I11998b474a25351901ca0eb45716e1d3e309c572
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-08-09 14:43:16 +00:00
Jarek Kobus
7630801293 Valgrind: Make Parser's API similar to the ThreadedParser's API
Change-Id: I39634c881dac44fc857a4aa2049e9c2618daec9b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-09 13:54:33 +00:00
hjk
e84369bbfa Core: Remove IOptionPage::setSettings()
The last user is gone, setSettingsProvider is the thing to use,
and allows delay-created settings.

Change-Id: Ic6491e2b0ba2ceaad7786cf37248d734f9714437
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-09 13:17:56 +00:00
Jarek Kobus
97461f6f18 AndroidRunnerWorker: Replace jdb process with Utils::Process
Change-Id: I269c9910a6d0ca1f259a3632abe3601bcdb19f8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-09 12:41:16 +00:00
Jarek Kobus
af731de4df CubicSegment: Avoid iterating double
Change-Id: I7f98247a20228a1087291138394ebc7469ad7b18
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2023-08-09 12:26:21 +00:00
Jarek Kobus
81d38bb711 AndroidRunnerWorker: Replace adbLogcat process with Utils::Process
Change-Id: Ia4e0e7e0b49ca1847bac537a7672c39b069bf767
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-09 11:46:30 +00:00
hjk
578ecfc846 SdkTool: Don't destroy :// parts in qmake paths
Change-Id: I1b8fef656550b7d2e59e6a606728d0f3e85d5af2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-09 11:32:57 +00:00
Jarek Kobus
fe1aeb3057 EasingCurve: Avoid iterating double
Iterate int instead. Store the x() value of QPointF,
instead of storing the whold QPointF instance.

Change-Id: I8c19eaa81cd60c4a164392afd5429ad9a2d222bd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-09 10:21:33 +00:00
hjk
4b4cbd142c Debugger: Rename main option page to DebuggerSettingsPage
That's the page in the 'Kits' category.

Also, move code to the canonical place at the end of the file
and self-register the factory at plugin load.

Change-Id: I6bdf7288a6a475447ea8a5a57b9118d49831a7b2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-09 09:52:48 +00:00
Marcus Tillmanns
1ca8487e91 Utils: Fix for invalid docker paths from installer
Some installers wrote "docker:/" into the settings instead of
"docker://". This adds a workaround for that.

Fixes: QTCREATORBUG-29474
Change-Id: I49a69d6fa9e4fe383257313e534660814c4a011f
Reviewed-by: hjk <hjk@qt.io>
2023-08-09 09:49:57 +00:00
Cristian Adam
6528bd3eed CMakePM: Find the right AUTOUIC generated header
Amends c4e15769ec

When using ui files in static libraries AUTOUIC reports fake header file
names.

By using the target that includes the source ui file we can find the
correct header file name.

Change-Id: I1c8e0b81ad2c670be87c3620f98bd0f5cce40cd1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-09 09:48:27 +00:00
Vikas Pachdha
fdb5600194 Docs: Add docs for removing properties through Qt Bridge plugin
Improve the properties docs across all Qt Bridge plugins as well

Task-number: QDS-8602
Change-Id: Ia48000053f793b08648e0b092195de8a443142b8
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-08-09 09:40:58 +00:00
hjk
9f1c99cb98 Debugger: Call DebuggerItemManager::restoreDebuggers() more directly
Change-Id: I77a293a8754e2aa3dd521e0810006c5f10ae23ff
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-09 08:59:28 +00:00
Christian Kandeler
048f77b961 CppEditor: Let users specify a preferred doxygen command prefix
Fixes: QTCREATORBUG-8096
Change-Id: I08bf4e3e0092fc775b50be6e5f4cefb9ed6979a5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-09 08:42:15 +00:00
Esa Törmänen
380648e142 Doc: Rewrite the QDS on MCUs intro page in ToC format
Rewrote the QDS on MCUs intro page into ToC format. Moved all the
sections into separate topics and added links to the topics.

Sections rewritten as new topics:
- Qt for MCUs Framework
- Developing Applications for MCUs
- Connecting MCUs with Qt Creator

Existing topics polished & edited to suit the new structure:
- Qt Design Studio Version Compatibility with Qt for MCUs SDKs
- Creating Projects for MCUs
- Creating UIs for MCUs
- All Topics
- Help

Task-number: QDS-10398
Change-Id: Iaba9c699d99c13f5f3b8d0fbf7b3ee97c674e9c4
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
2023-08-09 08:30:01 +00:00
hjk
aa5b3b670e Beautifier: Rename settingspage classes
*SettingsPage is the predominant name.

Also move the code to the canonical location at the end of the file.

Change-Id: Ib8e0d1f7a87576c4fd8019896102907c77c30f2f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-09 07:22:34 +00:00
hjk
2c353c37ea Utils: Base AspectContainer on BaseAspect
Change-Id: I78b11727af6e465da5731ba36bbae476d11d11ee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-09 06:59:01 +00:00
David Schulz
4330736db3 Bump version to 11.0.2
Change-Id: Ib733cb5adf7fb583dc161d3d20d0c4a61638cf0e
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-09 06:33:29 +00:00
David Schulz
fbb9946331 Copilot: avoid crash on misconfigured agent
When setting up a wrong or unusable agent.js the client used inside the
AuthWidget get's deleted eventually. In that case we need to reset the
tracked client otherwise we use a pointer to the deleted client in the
destructor of AuthWidget.

Change-Id: Ide4067c01cdcd05a33d44bc9460acfe9a56c7815
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-08-09 04:20:55 +00:00
hjk
5a9cc840d5 Perforce: Allow delay-created settings
... in theory. The first argument of the connect() call in
perforceplugin.cpp:555 currently spoils the fun.

Change-Id: I041c7707264d8ba64098c37f8fbb5ee4ea1e1753
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-08-08 16:53:42 +00:00
hjk
130f92c4d9 VcsBase: Remove a few now unnecessary Q_OBJECT uses
Change-Id: I41d50e437b3bcfb964d2ef27541ea6a55855ec2f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-08-08 16:34:46 +00:00
Jarek Kobus
f573af5f69 Valgrind: Split parse() into setIODevice() and start()
Make the API more TaskTree friendly.

Change-Id: I5119e38b5fc3cce234395fc5db5c73cf0c474ac0
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 16:23:44 +00:00
Jarek Kobus
0a320185dc Valgrind: Merge parsers' finished() and internalError() signals
Replace them with done() signal.

Change-Id: I5f03df927ddefd803d9cb0b06d3f4c1601a15381
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 16:23:39 +00:00
Burak Hancerli
eb13b7274d QmlProjectManager: Fix a crash while accessing an uninitialized aspect
Task-number: QDS-8145
Change-Id: I1ee9688a2ae860291878c64305cb5e6b2e0df277
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 16:07:43 +00:00
Jarek Kobus
3970a834bc Valgrind: Replace global toolTipForFrame() with Frame::toolTip()
Change-Id: I66cc481d588c468b9388e3b3863ed35aab406fa2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-08 15:10:47 +00:00
hjk
bb6c26cac9 QtSuppoer: De-O_OBJECT-ify QScxmlGenerator
Change-Id: I2732aaf838144d6da4c0b51bdfc2c8bb6cc8e21b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-08 14:30:17 +00:00