Only emit changed if the current interpreter changes.
This is more in line with the other aspects.
This fixes the pyside detection since the changed signal was not
emitted in all relevant code paths.
Change-Id: I53409b17f260b35914e39de894b48d7bd1ce27c0
Reviewed-by: hjk <hjk@qt.io>
Slightly nicer code and works well with settingspages nowadays.
Change-Id: Ic12ff58f4b0f8db226843961eb2ab6fb8879429c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
In order to prevent any possible further conversion.
Change-Id: I0f8be7558affb36b3015144fe9c640a7bfcab295
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Mostly local variables and KitManager::kitAspectFactories() to
match closer what they are.
Change-Id: I8f837357528f9e1110888898077f82b5097003f0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Also make nodes size smaller and small tweaks to margins.
Change-Id: I044684d1a57d1da2ed8b5768df80fb0948f94882
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Just re-organization relate to, but not a fix for the linked issue.
Task-number: QTCREATORBUG-29494
Change-Id: I0c5413b2dc97738a03b737e764194c4d90d3f086
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
So far we create all AbtractProperties and then filter and cast them. So
we throw most of them away.
Now we filter before we create them and we create directly the type we
want.
Change-Id: Ic1b32e11f2b934edfcf890e27de323af38051784
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
In the case of the has and remove functions we don't need the value. If
we use views we can use const expressions.
We have to change from QHash to std::map because QHash can not handle
different types for the find function.
The patch is removing a double lookup too.
Change-Id: I89bb942d7948127344d230ee61ac166102354ccb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Make node collection a little bit more explicit. Before we created,
copied and destroyed node lists. Now we send a list
around where we add nodes.
Use raw pointer for properties. Properties are used as internal pointer
plus the property name. The repesentation as an shared pointer is a
implementation detail and could be removed in the future.
Use raw pointer for internal nodes if we don't handle ownership but only
access member.
Remove double checks for properties. One lookup is better than two or
three.
Change-Id: If162f365db3e8869cbc19913abfc44d57c2d8324
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Make it implicitly threaded.
Get rid of ThreadedParser.
Don't move QTcpSocket instances, received by
QTcpServer::nextPendingConnection(), into another thread,
as docs says it's not safe.
Use wait condition for waiting for new data.
Don't potentially leak the Parser in loadXmlLogFile():
store a unique pointer to the running parser.
Introduce Parser::setData() method and use it with
QFile device in loadXmlLogFile().
Pass QAbstractSocket into the parser instead of
QIODevice and get rid of downcasting. The QIODevice
couldn't really work with non-socket and non-file devices
(like e.g. QProcess), as it lacks general error and finished
reporting signals (it has only general readyRead() signal).
Change-Id: I9352aec694564d4d2a26898841ed964bed470d82
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
There is no CMake install target for BareMetal. Therefore, the "Stage
for installation" option needs to be deseleceted, like it is being done
for other devices.
Amends: 2387e9e37a
Fixes: QTCREATORBUG-29293
Change-Id: Ic0e61ab19318f6383f55e6330b7559a734706a0e
Reviewed-by: hjk <hjk@qt.io>
There is no CMake install target for iOS Simulator. Therefore, the
"Stage for installation" option needs to be deseleceted, like it is
being done for iOS device.
Amends: 2387e9e37a
Fixes: QTCREATORBUG-29293
Fixes: QTCREATORBUG-29475
Change-Id: I6406446534c1ddedbf01cdab4d074bddc44dc495
Reviewed-by: hjk <hjk@qt.io>
If CMake version is lower then 3.27
- Shows the warning in general message
- Starts CMake without debugging
- Stops debugging correctly
Change-Id: Ibb13555c20ae2961c0a3c2ef6ec0fcc25930dddc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Changed the grid spacing to depend on view distance rather than
zoom factor, making it more understandable. Also it now takes into
account the distance of the lookat point from the grid plane to improve
spacing when focusing objects far away from the grid plane.
Simplified the logic on how subdivision alpha is calculated, making
it more flexible in case we want to allow configurable grid spacing.
Also, now the grid steps are bit more sensible numbers, i.e. multiples
of 50 instead of multiples of 55.
Change-Id: I37bcdb9469273b3ac8981519182096aa789d5b77
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The function emiting those signals can be called with an empty file
path. Use the document file path in this case like in
TextDocument::saveImpl.
Change-Id: I9e3381999a25c49df1d5db060ef5467b12220ad4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When shaders are cached in addition to pipeline caching, further
speedup of another 20% or so is achieved on resetting puppets in
complex 3D projects.
Task-number: QTBUG-103802
Change-Id: I55c950b14c7d854ca3b4de40558ecd26889aa134
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Also capitalize first letter of category name.
Change-Id: I1a86a27d98a4cf666c0b748193eb093061ad2a3c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
When receiving a null proposal and the processor is not running after
updating a proposal we need to make sure the previous visible proposal
widget gets closed.
Change-Id: Icb0a7293698e603df3ba8cab34a08c10fe6784da
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
...instead of from Qt SDK
Change-Id: I10d3104477b7cd7c729121175c66a7402ea49651
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
None of the functionality it provides is actively used.
The QObject inheritance itself is left as the factories act as
guard objects in some connections.
Change-Id: Ia6f2707a3a0a4e2810acdb4dd566afee855468b4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and split out the static interface.
Change-Id: I5f9e3ed1e0c75fe26fa843858014070cb6cc0e6f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Added warning when current clangformat major version does not
match with version what checks was generated for.
Change-Id: I818c9a4f79385cba4e492ea5428bb051f329a9d4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and split out the static interface.
Change-Id: Iaa92ab8e0b29e47736af6c2b5ed146369f2d7294
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and split out the static interface.
Change-Id: I0a1bb1c2fa71fa41fe54a3cbedd69f5a8f73713b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This will serve as the basic building block for several comment-related
features.
Task-number: QTCREATORBUG-6934
Task-number: QTCREATORBUG-12051
Task-number: QTCREATORBUG-13877
Change-Id: Ic68587c0d7985dc731da9f539884590fcec764de
Reviewed-by: David Schulz <david.schulz@qt.io>
