Do not try to run the conan executable if conan executable is
not found.
If the conan auto-setup fails warn about it and provide the message
how to skip the auto-setup configuration and do not fail due to the
missing conan_paths.cmake file.
Also print a status message that informs the user that the package
manager auto-setup is performed, with the information how to skip
the step.
Task-number: QTCREATORBUG-25680
Fixes: QTCREATORBUG-25891
Fixes: QTCREATORBUG-25818
Change-Id: I0969ba9b417448f89efd22d7c361e3a54e552ed1
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Alp Öz <aoz@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This patch
- improves performance by removing the usage of QRegularExpression for
trivial string operations (this is called 3000 times after configuring
Qt Creator)
- fixes handling of version number like "2.-1" which are the result of
imports with only a major version number like "import QtQuick 2"
Task-number: QTCREATORBUG-25899
Fixes: QTCREATORBUG-26178
Fixes: QTCREATORBUG-26216
Change-Id: Ic792909513f4fe25ac72043645f297ee41890375
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
These classes are strongly related, so no need to spread them around.
Change-Id: I4258b0c4198b3c650454ac734d7e52e09f46a4eb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Fixes restoring project settings with enabled test tools but
having globally disabled these.
We need to take the real active state for test tools into
account not only the global one.
Kind of enhances b99d7623f3.
Change-Id: I29c8cc4fff7c82140da41d3c85823d5980c96d9f
Reviewed-by: David Schulz <david.schulz@qt.io>
So that Qt Design Studio can set its own implementation for the New
Project dialog box.
Task-number: QDS-4490
Change-Id: Ie04b041a5b6e25b38416f53b0ee4943839c2f64f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reuse ProcessReaper inside process launcher.
Automatically reap all internal QProcesses of QtcProcess
(either direct child of QtcProcess in QProcessImpl
or indirectly inside process launcher).
Make ProcessReaper work again on QProcess instead of on
QtcProcess, so it may still be reused for non-QtcProcesses.
Change-Id: I950cac5cec28f17ae97fe474d6a4e48c01d6aaa2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
COOKIE FOR TOKEN 0 ALREADY EATEN (InferiorStopOk). TWO RESPONSES FOR ONE
COMMAND?
Change-Id: I569a9715f073f3fbba71045f14fa30a06cd434e9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Fix color dialog removing color property after rejecting the dialog when
color is binding.
Task-number: QDS-4826
Change-Id: I4cae3b70b18a0131ac555d5b8502d05de5409070
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Open the first .ui.qml file of a .qmlproject to not
confuse users.
Task-number: QDS-4986
Change-Id: I56c77c2101fd549cb7b96ea7d273bb4f5234693a
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The commit a71d725e46 which fixed issues
on ARM Macs also removed logic for CONFIG+=<arch> arguments to qmake,
which was removed from qmake in Qt 5.6 (since PPC and 32bit Macs are no
longer supported or relevant, qbase f58e95f098c8d78a5f2db7729606126fe093cbdf).
The commit only removed part of the logic though, leading to the
Makefile parser and the qmake step disagreeing on the architecture of
the last qmake run, leading to the qmake step being executed again.
Remove the whole architecture detection and matching logic from
everywhere, which only did anything meaningful on macOS, and is not
needed there anymore either.
Fixes: QTCREATORBUG-26212
Change-Id: Ib60ebca1143296194454a63992ab90a97fdb56b6
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This redirection did nothing except to horribly obfuscate the code.
Note that most callers already accessed the model manager directly, and
some bridge functions were not called at all.
Change-Id: Ic1c728afe79bf98544da23a1955ee82d0dbde94f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Asset library refresh will crash if done while there is a modal dialog
open, so postpone it a bit in that case. The timer used for this
will also reduce unnecessary refreshes, improving overall performance.
Change-Id: Ib2ff29f5f79428c6543a20f611c708ba80e88ded
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
When installing a signed apk, adb might throw the following log
"All files should be loaded. Notifying the device." which is being
treated as an error and will stop the deployment from going forward
until user input is given. The current condition is not catching it
probably because it has a \n at the end, but let's treat it as a
warning.
Change-Id: If071730b39871b4e60f8755d14ba352b86e7c244
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Although, recent Qt versions (Qt 5.12+) don't really need r10, this
can be useful if an older version is used, or if the user wants to
explicitly use Ndk r10.
Change-Id: Ic88929a747bcea89384a7bae9d8f8b26135fae65
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It looks like posting the delete request from custom
deleter might not deliver the actual delete to the QtcProcess
for some reason (e.g. event loop wasn't spinning anymore).
Change-Id: I4f797984e28d738015881bd0fe4f91d28f525989
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
By having the function body in the class we automatically get the
same inline functionality and get rid of the warnings below on LLVM
Clang 13.
src/plugins\coreplugin/find/ifindsupport.h:71:27: warning:
'Core::IFindSupport::highlightAll' redeclared inline; 'dllimport'
attribute ignored [-Wignored-attributes]
Change-Id: I0daa6412678090f45bdfb6401157cb68bcb0241f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
No need to compile an extra translation unit for this.
Change-Id: Ie21346700818ccadab864b77f13f167bd27a457a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It's not needed, and conflicts with the namespace of the same name in
some contexts.
Change-Id: I281025abbfad0feb602f006e3b997a8b9c308b48
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Sometimes after creating QtcProcess we move it into a different
thread. In this case we should move all the children, too.
Without parent-child relation all the children will stay in the
old thread.
Change-Id: Ibde44d6153092a155dd2d200a7116a046910dddc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
It may happen that CMakeProcess destructor puts its internal
process into the reaper. After this, when the CMakeProcess
is already destructed, the internal process may still be working.
Since we have set the StdErrLineCallback lambda for the process
which accesses the private m_parser field, it may potentially
crash.
Solve it in a general way, so that whenever we put a process
to the reaper we reset its callbacks.
In addition, disconnect all the slots connected to process'
signals.
Fixes: QTCREATORBUG-26220
Change-Id: I63ea0e0ed6a62ef97ac695572f18014458489c5c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Figuring out the used imports checks all model nodes, which means
model needs to be updated before used imports are determined.
Fixed by moving setupUsedImports() call after model sync.
Fixes: QDS-4985
Change-Id: I3f03055d36cb638bcfcd48dc973dbae3af7d8002
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
It is wrong to query the global active state when
adding test tools known to be active.
Change-Id: I89ab292e1a71b43757e6308fa4b4c584d62fe28b
Reviewed-by: David Schulz <david.schulz@qt.io>
When using Qt5.11+ we run into some deprecation warning
for the logging handling on Windows.
Silence this by specifying the new environment variable
as well which is checked first.
Change-Id: I1ca2b826de4516c606b260d053b949b5761c8414
Reviewed-by: David Schulz <david.schulz@qt.io>
When running ctest with Qt based tests we missed output coming
from qtestlib.
Due to running a separate QProcess we need to force the output
on stderr to be printed not via the Windows debug console.
Change-Id: Ie3b957230836efd59f11b6a1e7ac310fa44fa073
Reviewed-by: David Schulz <david.schulz@qt.io>
* Added QDebug operator<< for the Field classes so that they could be inspected during runtime (i.e. logged)
* Added optional QDebug operator<< overloads for QVariant (wizarddebug.h) - to better visualize the data parsed from the wizard.json files (QVariant objects), by using a format more in the like of json.
Change-Id: I53a729b24e4f2d9c9acf1ed802ac9dc3bb67f373
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The flag was set whenever the n or p key was pressed allthough
we only switch the item if also control is pressed.
Change-Id: Ib1b6ab14d1ddf7dee954651382b9b0fc454ddca1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Do not close already visible proposal widget if we get new results for
the same base position. Just replace the model of the widget and update
the prefix.
Change-Id: I298aba6eb8177edc17fea783189a2f987dbf15a2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
