Commit Graph

62421 Commits

Author SHA1 Message Date
Thomas Hartmann
35db14897a QmlDesigner: Fix crash
Change-Id: Ie2d2b2226c576997af3e86c79ea8f9cb0cf66964
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-11 13:24:59 +00:00
Thomas Hartmann
65deec7365 QmlDesigner: Fix crash
Change-Id: I6c27519dd24d99d3f7f0970c574ef258d685f265
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-11 13:24:33 +00:00
Assam Boudjelthia
525a284f3e Android: simplify AndroidSdkManagerWidget::installEssentials()
Remove an argument that doesn't need to be be provided explicitly
by the caller and can be done internally.

Change-Id: Ie225f847560b746ce9b8103ab38caca5caca1b0a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-11 12:35:33 +00:00
hjk
d7fd254a79 Utils: Fix maximum size computation for backtraces on abort
Change-Id: Ia974343cdeb6d54d2e7331735c9cdd063f445af1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-11 12:30:13 +00:00
Christian Stenger
4faff875d8 ClearCase: Remove unused locals
Change-Id: Ib62cbadc865ee8ab61daf20b8809aff1af2fa444
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-11 12:15:39 +00:00
David Schulz
13af74a4e8 LanguageClient: remove fragile flag from lsp proposals
Those proposals are not fragile anymore since they reuse the old
completion widget. This fixes vanishing of none idle editor completions
on backspace if there are less than 3 characters to complete.
Additionally this removes the double completion request if there are
more than 3 characters typed in.

Change-Id: Id47d341adf954dfaaaeb70c17f6774ba38cc8bdf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-11 12:15:09 +00:00
Christian Stenger
191626e2ea Squish: Allow querying and displaying server settings
Change-Id: I6158aa11fa314ca7c42f175ccd03330059eef910
Reviewed-by: hjk <hjk@qt.io>
2022-07-11 11:55:49 +00:00
hjk
79f0fe4819 Qnx: Inline qnxsettingspage.ui
Change-Id: I628325154abd37e8a5803f44628def42acb533dd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-11 10:38:42 +00:00
Jarek Kobus
f330a7b1e9 QtcProcess: Make timeoutS a default arg of 30 seconds
Change-Id: Id11911e74ede109b49583d82592b333ad577e8ee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-11 10:21:46 +00:00
Jarek Kobus
61258bd658 QtcProcess: Get rid of unneeded arg from readDataFromProcess()
Change-Id: Ifecf7b4a9668bc362e454a6e5084eb1d7308e4eb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-11 10:21:38 +00:00
Jarek Kobus
e793841b4f Remove Core::ShellCommand
Move the implementation into VcsCommand.
Use Utils::ShellCommand inside coreplugin API.

Change-Id: I74a34057b33832a138b05f1dfa6937565027edb4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-11 10:04:08 +00:00
Jarek Kobus
9891a879aa Core::ShellCommand: Remove unused futureProgress()
Change-Id: I15f0ed521714adc873c06f510a03a44a941aaffa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-11 10:03:55 +00:00
hjk
917d7e0007 ImageViewer: Inline imageviewertoolbar.ui
Change-Id: Ie7b4c77477ce78107c5f55edccdcbd4db74b010b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-11 09:58:09 +00:00
Marco Bubke
e00f6864a0 QmlProfiler: Fix warning
Change-Id: Ib846c2d347610cdde4592960ad96b03195f3c13f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-11 09:50:03 +00:00
Christian Stenger
d829b27f15 Valgrind: Fix Qbs build
Change-Id: I50a48a1c1adcfae9ff4cbba8b50bb02e8dca9405
Reviewed-by: hjk <hjk@qt.io>
2022-07-11 09:34:08 +00:00
Marco Bubke
9faf6d0826 QmlDesigner: Adapt to C++ 17 [[maybe_unused]]
It has the advantage to to move the attribute to the declaration instead
of using a workaround.

Change-Id: I08b712f146a0625d0367657c31d6c1e5f7caec41
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-11 09:29:52 +00:00
Marco Bubke
02d05f76d9 QmlDesigner: Explicit instantiation of ProjectStorage
Change-Id: If56a3b7f8189c998a6335a31ecca8a82cb269604
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-11 09:28:02 +00:00
Marco Bubke
dc32c6028c QmlDesigner: Add getter for type id
The type id getter expects a valid module id, an exported name and
optionally a version.

Tsk-number: QDS-7271
Change-Id: I9af5f926b97606fc312eb1158367aba7105cdefb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-11 09:24:12 +00:00
Christian Stenger
53a28c7080 McuSupport: Fix compile
Amends 5be5f7a331.

Change-Id: I3261c68aae0521dca38679e54e7775184ea623ff
Reviewed-by: hjk <hjk@qt.io>
2022-07-11 09:19:31 +00:00
Thomas Hartmann
8953be1d3f QmlDesigner: Add transaction to deleteDynamicPropertyByRow()
Change-Id: Iebbd127ba43698b82e7f7124c5b929e406687f22
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-11 09:02:40 +00:00
Cristian Adam
8d99df9a7c CMakePM: remove unused headers, enforce sorting of headers
Used clangd hints.

Change-Id: Iade4de67c1d2e5fdd1a880c5603b31203170ebbe
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-11 08:43:09 +00:00
Jarek Kobus
37ac00e498 ProcessInfo: Don't use QtcProcess::readDataFromProcess()
There is no big benefit of calling readDataFromProcess()
when the last argument is false. Simplify
getLocalProcessDataUsingPs() method.

Change-Id: I3839f93574945ef2bb6d147415cffc61d95afda0
Reviewed-by: hjk <hjk@qt.io>
2022-07-11 07:36:35 +00:00
Piotr Mućko
5be5f7a331 McuSupport: Version detection handling for kit requirements
Create appropriate instance of version detector depending on
parsed data from JSON and pass it to McuPackage's ctor. Also tests.

Change-Id: I4f7e5cd6d998745dfe951284c34904526abc216b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-11 07:23:38 +00:00
hjk
866f20e4f9 Valgrind: Use Tr::tr
Change-Id: I77b27462d88079699e620ef459f951846c15c3e2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-11 07:14:37 +00:00
Eike Ziller
f901478c6a Bookmarks: Convert to Tr::tr
Change-Id: I3fd7472b731264b4399412ed36b1b9aba9b7d1c3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-07-11 07:07:40 +00:00
Christian Stenger
1e723327fe Debugger: Fix build with Qbs
Amends 9894c6eaf0.

Change-Id: I13358bddf13abfc239de9254dfa125fc46c244a4
Reviewed-by: hjk <hjk@qt.io>
2022-07-11 06:11:32 +00:00
Marco Bubke
7dc3ff425a RemoteLinux: Fix warning
Change-Id: I644d3f62d25cb89dc054aba3c97a84f5b9afcdff
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-09 12:40:03 +00:00
Thiago Macieira
d4ed6d6129 Debugger: force qfloat16 to float to print
It'll get a _Float16 cast operator, which will cause ambiguous overloads:

watchhandler.cpp:782:24: error: ambiguous overload for ‘operator<<’ (operand types are ‘std::ostringstream’ {aka ‘std::__cxx11::basic_ostringstream<char>’} and ‘qfloat16’)

Change-Id: Ic44396b31ba04712aab3fffd16ff43d6616878f9
Reviewed-by: hjk <hjk@qt.io>
2022-07-09 05:44:00 +00:00
Cristian Adam
531288a715 CMakePM: Group CMake settings into one category page
CMake settings were split in two places, which complicates things.

Now they are both into one settings category, just like other build
systems Qbs, Meson.

Change-Id: I55f434d83604c9b3be111fc89014b720ee72b513
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-08 19:02:42 +00:00
Knud Dollereder
8d30f1d004 Prevent access of invalid frames
Changing keyframe positions while the timelineview
is hidden might lead to access of invalid frames
when showing the timelineview again.
Prevent this by calling invalidateScene from
within the showEvent.

Change-Id: Ib9c1e90de5bd7679823c4faeed9156da764c98a6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-08 16:09:41 +00:00
Knud Dollereder
1df1a065de QmlDesigner: Improve usability of boolean animation curves
Boolean animation curves are now painted from min to max of the value range
instead of from 0 to 1. This allows to see value changes when the curve is
loaded together with other animation curves of different value ranges.

Boolean curves are now forced to be step interpolated.
If the user tries other interpolation types the request is denied and an
error message is written in the new status line.

Added a status line that displays the current frame number by default and
an informative text in case the user did something forbidden.

Respect the current state when populating the curve editor.

Fixes: QDS-6950
Fixes: QDS-6889
Change-Id: Ia5fa1c1c55ee93eda5a39fd83987b54fb41d54db
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-08 13:20:26 +00:00
Cristian Adam
f49ffa0ab4 CMakePM: Use HeaderViewStretcher for Tools QTreeView
This way one can change the size of the items in the view by
moving the delimiter left and right.

Without this patch the size would stay fixed and looks weird on
Windows with CMake being detected from Visual Studio.

Change-Id: Iaaf1cfb6e854a26e4a2e6535dfd47c19d77125bb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-08 12:47:48 +00:00
hjk
9894c6eaf0 Debugger: Convert to Tr::tr
Change-Id: I5d2475c790851c68f9997ac6af72b5eaca58482d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-08 12:32:38 +00:00
Christian Kandeler
bb3549a721 ClangCodeModel: Move completion code to its own set of files
Change-Id: Iad856881ace80896f4aceab3fbf129d7635de642
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 11:58:42 +00:00
Artem Sokolovskii
a427527328 ClangFormat: Fix saving settings for standard code style
Task-number: QTCREATORBUG-27269
Change-Id: I8ddd30e55989dc3f9ee83d3cb1a3c2a794144da8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-07-08 11:13:04 +00:00
Artem Sokolovskii
e8f1d97a3b EditorSettings: Move Restore Global buttone
Change-Id: I58729f868a214e7ad15d4960e28d4b7bb0c3cf98
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-08 11:12:32 +00:00
Alessandro Portale
9f469cef11 Android: Don't show 2 issues per Android Qt if unconfigured SDK
Only call registerNewToolChains() and updateAutomaticKitList() if the
Android SDK is configured and the required environment for the mkspec/
qmake parsing is set.

Fixes: QTCREATORBUG-27805
Change-Id: I66eca659074afeea97a894cc418a95675e46ff1e
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-07-08 10:40:55 +00:00
Assam Boudjelthia
f079479756 Android: Look for latest JDK version and not 1.8 specifically
Recent SDK Manager that is used by Qt Creator works with JDK 11+,
and JDK 11 is needed by Qt 5.15.7+, so look for the newest JDK
instead of 1.8 as currently being done.

Change-Id: I6ff415aa300d742735e8636b24a03116d5bfe2b6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-08 10:40:43 +00:00
David Schulz
d3a40b1d04 CodeAssist: Fix disapearing completion list after update
Change-Id: I3e35fe53a69e7806c0c8a5959ef8c16344aace8d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-08 10:19:23 +00:00
David Schulz
8170501502 Editor: visualize indent
Paint a horizontal line every indent size in the whitespace at the start
of each block.

Fixes: QTCREATORBUG-22756
Change-Id: I044ccb4adefa4c8c9a3a610f0e996a810487fa1e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2022-07-08 10:12:42 +00:00
Eike Ziller
173363b616 Meson: Fix settings saving
Amends c24291648b

Change-Id: I0f80e1483c0550d7ec3add0f9869eb96c758052b
Reviewed-by: hjk <hjk@qt.io>
2022-07-08 09:11:31 +00:00
Eike Ziller
10163afae0 Merge remote-tracking branch 'origin/8.0'
Conflicts:
	share/qtcreator/translations/qtcreator_ja.ts

Change-Id: I436b8f60971f11a5fb7962a57600ad075135f397
2022-07-08 10:21:30 +02:00
Christian Kandeler
1fb4737d0d ClangCodeModel: Move quickfix functionality to dedicated set of files
Change-Id: I7cc55afa7aa50ba584593457b6c1393794866c56
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 07:45:30 +00:00
Thomas Hartmann
6f0d2e6565 QmlDesigner: Add unusedProperty() as public member
Change-Id: If24e0d09145f0bb9e5459cae1b13302610818913
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-08 07:22:06 +00:00
Christian Stenger
674cca18a7 GitLab: Use IntegerAspect instead of QSpinBox
Change-Id: I06e9d907a6a65f8cf135031f0aed3cd3eca9281b
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 07:00:17 +00:00
Christian Stenger
ae1e006426 Utils: Allow programmatically change of IntegerAspect
Using setValue() on an IntegerAspect only had a visual effect
if it happened before adding it to a layout.
If the aspect had been added already the value silently got
changed (internally) but this was never reflected on the
respective SpinBox.

Change-Id: I60297d9d38835842b3b02a36787c0a2001477427
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 07:00:08 +00:00
Christian Stenger
fe07f7962c Squish: Move ownership of SquishTools into plugin
Change-Id: I9b5ed4ea37c2945642d644ec672f6e8cd2986c29
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 07:00:00 +00:00
Christian Stenger
eb22c0c615 Squish: Prepare handling of server settings
Change-Id: I3495eb82eb6c02901d4a05d40516c6088f9374dd
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 06:59:43 +00:00
Thomas Hartmann
8f141a8e26 QmlDesigner: Add instance to ConnectionView and make methods public
This allows to use the model from the property editor.
We do not implement the instance as singleton but use the View Manager.

Change-Id: I2d95235a31d4a776411336ef82ace0f230c9971f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-08 06:38:53 +00:00
Christian Stenger
bf0f2604c0 Squish: Extract functions for re-use
Change-Id: I3243619c8bb6a9ac6c4c9bfc6a438b23cc8bd37f
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-08 05:38:24 +00:00