... when we are about to send a new semantic token request.
Change-Id: Ibd421dd29bf3ea0e2b502c227341ff03259b2370
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This is not required and can create issues, when including this
header file.
Change-Id: I2472ecf45c1c8f1faf0d44c8ee97cfbb4736c6c8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The views can be accessed anyway via the model.
Change-Id: Id87d3f1bdf3e9ec84a68cfd3035a05f59b85fc7c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Instead of creating a new cache for every collector we now use a
collector dispatcher which is dispatching the request to different
collectors.
Tsk-number: QDS-7258
Change-Id: I024622d4b757e1ff10f7cab4204d1742ef5926da
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Instead of putting some strings into a list let the compiler to his
job and put it in a compile time tuple. This has the advantage too
that it can be of different types.
Change-Id: Ic4e7a9da8994d2a43ca115c1d69eab622c610437
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Move some repetitive pattern to PropertyMetaInfo
Change-Id: Iba8722d3d95881c1db85c12cbc2b2b8c4b629f2c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Before this change the done() signal was emitted 3 times
in a row. The reason was that first one was coming
synchonously from handleGotoDefinitionResult(), while
2 others were scheluded with queued connections.
So, the handler for done() signal was called 3 times.
The first invocation calls deleteLater() and clears
the pointer, while the object is still alive.
Before the request to delete later gets dispatched,
the 2 remaining done() emissions are dispatched,
so the handler is still called 2 times.
One possible solution would be to disconnect from
done() signal inside a handler. However, the done()
signal shouldn't be called many times, so this fix
ensures the done() is emitted only once.
This fixes the following prinouts:
"QCoreApplication::postEvent: Unexpected null receiver"
issued twice on every follow symbol interaction.
Amends 650bc260c6
Change-Id: I9b440a80386aca3462eda323e51a76696e53fa6b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The StringAspect needs to return a possible default value if
no value was set by the user. Otherwise it would write an
empty string when ::apply was called.
Also a small improvement for docker error logging is added
Change-Id: I85f80253894d2c3e726da714616e5275039febcc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
error: reference to type 'CPlusPlus::ClassOrNamespace *const'
could not bind to an lvalue of type
'const CPlusPlus::ClassOrNamespace *'
if (interfaces.contains(u)) {
Amends f7097cef19
Fixes: QTCREATORBUG-27806
Change-Id: Ia5c27260f71bf35c87352545fff42dcaef1f2649
Reviewed-by: hjk <hjk@qt.io>
Ensure that a freshly created AVD is properly listed and is usable. By
forcing a AndroidDeviceManager::updateAvdsList() after successful
creation.
Fixes: QTCREATORBUG-27804
Change-Id: I1ef0fb23d2c13b99d285f07505189f37929f4ed7
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Otherwise pyside6-project cannot find uic or rcc or might use those
tools from another pyside installation.
Change-Id: I34eff2fc2627b07a18a705e5d658bd7cf8ce9350
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Avoid manual termination and killing - use either
QtcProcess::close() or default QtcProcess d'tor.
Both will employ internal reaper for terminating
the running process asynchronously.
Change-Id: Ib1de1125da0c25b4f5c5b7ac0827336f99881679
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
When we call QtcProcess::stop(), the terminal process invokes
stopProcess() method. However, if it doesn't emit done() then
subsequent call to waitForFinished() will timeout with 30 s.
This should fix the 30 seconds hang when debugging in terminal
after pressing the red square button.
Change-Id: Iea1f9ade85dc8a4414dc49d7c8a2cbe80f0b5756
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
There's a QTabWidget and a list of RunControlTabs, whose indexes got
confused in several places.
Fix this and decrease the likelihood of the problem occurring again by
never using indexes for the RunControlTab list.
Fixes: QTCREATORBUG-27743
Change-Id: I8a83b0c802fe76a09b4eba0da999a52fdeb6ddac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... when in clang-cl mode.
We observe strange behavior when keeping the MSVC /std:c++xx syntax,
namely that files that are not specified in the compilation database
appear to get parsed without a language version. The problem does not
occur when passing the flag via "clang:".
Fixes: QTCREATORBUG-27764
Change-Id: I0035e5fef6dfd37fbbe396b538f38fc29b23923b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This was broken by our compiler command line optimizations, resulting in
"-x" rather than "/T" appearing for MSVC/clang-cl toolchains and causing
clangd to assume C instead of C++ for some files.
Change-Id: Ib98db88ac90e4e45a7016a7edcb80a279df372aa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Because the project storage is integer id based the string based API
isn't fitting well for the new approach. PropertyMetaInfo can be easier
mapped to the project storage.
Task-number: QDS-7197
Change-Id: I49bc650abdaacf4b039d76c2514b5ad05ec84abe
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Delete it later instead.
Fixes: QTCREATORBUG-27803
Change-Id: I1108a87bc762a7da690b8999c9e73e127d79d3c4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
There is no big benefit of calling readDataFromProcess()
when the last argument is false. Simplify
runSubmitMessageCheckScript() and use QtcProcess::exitMessage()
for error message reporting.
Change-Id: I4ddaf3e72a2b5d49b47a2024da84862d92ab49fc
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
... for a temporary kit created by the importer.
The way the importer works is that it sets up a random kit (with a
default toolchain) and then overwrites toolchain and Qt version. If the
new toolchain is of a different type than the original one, the debugger
will not match anymore. Fix this by calling fix() on the changed kit and
adapting the DebuggerKitAspect so that it sets itself up from scratch if
the current value doesn't match the toolchain.
Fixes: QTCREATORBUG-27758
Change-Id: Ib0539f07c0c38728de89a49299b7d2439afc5744
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Change the behavior of the output pane when an error occurs in the
QML live preview to avoid focus lose.
Change-Id: I78326af5060c775837d7a2d930c1fdd73b500f16
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
The QtSupport plugin tests copy qmake into a separate directory. If that
qmake is from a MinGW Qt, the respective .dlls are missing, and the test
interrupts/blocks.
Fixes: QTCREATORBUG-27793
Change-Id: I1ac02c31b6b74cf382285b8a5246292f82f979e3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In order to avoid runtime warning:
"QFutureWatcher::connect: connecting after calling
setFuture() is likely to produce race".
Change-Id: I921396628e5615e7c2d87045d2e787388dbddcc6
Reviewed-by: David Schulz <david.schulz@qt.io>
This fixes the runtime warning:
"QFutureWatcher::connect: connecting after calling
setFuture() is likely to produce race".
Change-Id: I5c54ec10cef6bfd43a905e4e48fea05cb7b49297
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Some of our auto tests fail, so add an EXCLUDE_FROM_PRECHECK option for
add_qtc_test, which sets a corresponding label on the ctest, and exclude
these when running ctest on COIN.
Disable the Googletest based unittests for now, they are inconsistently
failing on CI, e.g. sometimes timing out after 60 seconds for tests that
usually take only a fraction of a second.
tst_perfdata from the perfparser submodule also fails. Temporarily
disable it explicitly, until the EXCLUDE_FROM_PRECHECK change can be
merged there.
Change-Id: I7e9d7aded75bbe8800f82f7aa125c181271a2a1f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
