Commit Graph

62421 Commits

Author SHA1 Message Date
hjk
68852bdd51 ProjectExplorer: Remove unused BuildStep::reportRunResult
... and a few unneeded Utils:: qualifications.

Change-Id: I900061baed6afbb5a4ce7c2fd6a346a44f6d0945
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-07-05 09:58:47 +00:00
Marcus Tillmanns
15c7f08e4a docker: Change Settings to single owner
We change DockerSettings to have a single owner.
Since DockerDevices are destroyed after the plugin
is unloaded, we have to make sure to remove the
settings from devices during plugin teardown.

For this we store a list of created devices in
the factory, and call their shutdown function when
the plugin unloads.

Change-Id: Ic9c7d8ad9437c48d68f20c9a8f8ad7449b3cb972
Reviewed-by: hjk <hjk@qt.io>
2022-07-05 09:42:07 +00:00
Eike Ziller
4d72cb55ba Projects mode: Use "Show Right Sidebar" action to toggle build output
For users who want the full area for the configuration widgets or don't
see output there because their build system doesn't put it there.

Fixes: QTCREATORBUG-26069
Change-Id: I4ffa73be88e5c7cc058227bc681f87e4c0a642bd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-07-05 09:08:40 +00:00
hjk
26f135f243 ProjectExplorer: Drop unused Macro::toByteArray(const QVector<Macros> &)
Change-Id: Ic3f0b8bda4fac1d31e2b3239e4a3ee261547b30a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-05 08:23:53 +00:00
Thomas Hartmann
106f034caf QmlDesigner: Rename text editor view from "Text" to "Code"
Change-Id: Ic279e33d051c071417ae9ea1bf45027c7f9d2c04
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-05 07:47:28 +00:00
Thomas Hartmann
5e96768eac QmlDesigner: Rename Connections View to simply Connections
Change-Id: I13f126b5a847cdd047a39063fd0d68c6606c24fa
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-05 07:47:18 +00:00
Eike Ziller
946d08c6fd Fix display of build errors/warnings in status bar
We show a summary of errors/warnings with icons in the status bar, if
the "Progress Details" are toggled off. The change that fixed the size
of that details widget to a grid, to prevent constant relayouting of the
output pane buttons while indexing runs, broke the size of the build
result summary.

The size was adapted in
ProgressManagerPrivate::updateStatusDetailsWidget() but that is only
called when FutureProgress::setWidget is called. When the build manager
later makes the warning/error details visible, the size was left at the
minimum size of 20 pixels, leading to the widget being cut off.

Amends b4f2ac0dd4

Change-Id: Ia41cf3db7e4485dff4712412976c1d4f5dd315b2
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-05 06:43:42 +00:00
Christian Kandeler
96be267a6e ClangCodeModel: Prevent documents from getting opened in wrong clangd
As per 8ad7ab2d2a, we prefer to open non-
project sources in a project-specific clangd, rather than the fallback
client.
However, we do *not* want clangd to open files from "foreign" projects.
Checking for the existence of a client for a specific file is not enough,
as we might be in the process of loading a session or the respective
project might have clangd turned off.

Change-Id: I2d5cb7027c6a3ad23e99606d6d6742d67fbc5384
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-04 13:05:06 +00:00
Christian Stenger
53269fc386 Squish: Do not directly delete process from handler
Change-Id: I1aa692285449a36b9ae88f7aa9a5c3b75769a7fb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-07-04 13:04:58 +00:00
Eike Ziller
2e8d6661ca Change log browser: Make bug numbers clickable links
And use monospace font

Change-Id: Ib847045150e4c3fcf1a9ef74f207ef9eb2415e71
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-07-04 12:43:01 +00:00
Jarek Kobus
8a37019b3b CMakeBuildSystem: Get rid of call to waitForStarted()
This is unneeded when followed by waitForFinished().

Change-Id: Ia30161da73ea877ba8973903a391100f29be8410
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 12:40:25 +00:00
Jarek Kobus
4a9fe3e709 TestRunner: Don't call blocking waitForStarted()
Handle failed to start case inside done() handler.

Change-Id: Id138f0ef1fc58b6e335e08d8222e99c29c06b942
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 12:40:16 +00:00
Christian Stenger
2d7457573b Squish: Aspectify settings
Change-Id: I9861de1803adaf39fda9378a3169e99e37ad8695
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-04 12:27:43 +00:00
Marcus Tillmanns
8a7a4fce6c docker: Add dockercli setting
Change-Id: I46fada555d697007042d823ef1cad0658be98e22
Reviewed-by: hjk <hjk@qt.io>
2022-07-04 12:21:00 +00:00
hjk
95c1f37a31 RemoteLinux: Reduce visibility of KillAppStep
Change-Id: Ib90a25ea5d3f2c7636aa099c87a3f71721ab9ea6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-04 11:11:13 +00:00
Marcus Tillmanns
0a77097395 cmake: Fix cmake option display
When editing a multiple choice cmake option the
background ( the text of the current value )
would shine through. This fixes that by setting
setAutoFillBackground(true) on the editor widget

Change-Id: Ie36ea13f2d0532c375f22a33569772c3b2c604fb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-04 11:10:52 +00:00
Cristian Adam
1afbeb696a ProjectExplorer: Better detection of MinGW GCC and LLVM abi
On Windows the ld.bfd from MinGW GCC and lld from LLVM have fixed
positions where they store the PE extended header.

These positions differ than what MSVC is using, and it's enough to know
if an abi is not MSVC to mark it as MSys.

Task-number: QTCREATORBUG-26247
Change-Id: I9ee35fb1b848fa574ed0506649a5e45fdbdf7974
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-07-04 10:50:41 +00:00
Artem Sokolovskii
0087bd492f Clangd: Fix autocompletion for old style SIGNAL and SLOT
Fixes: QTCREATORBUG-20737
Change-Id: If6d3c6ea5924537386eca81d90d4bb1e8f1a1466
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-07-04 10:33:37 +00:00
Christian Stenger
ec86b12724 Squish: Modernize SquishTools
Change-Id: I8b9394b95d0e9fe8e054c66df58436aef2ddfb05
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-04 09:34:38 +00:00
Marcus Tillmanns
6431932569 cmake: Add option to disable subfolders
An option is added to change the default behavior that
would create subfolders inside source groups for files
based on their location on disk.

When disabling the option, files will be added directly
under their respective source group.

The virtual folders <build-folder> and <other-files>
is also omitted when the option is disabled.

Fixes: QTCREATORBUG-27432
Change-Id: Id78e178011c5299d4f7257bf855a5d791eebf91c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-07-04 08:48:57 +00:00
Alessandro Portale
c899793b37 Android: Fix version mapping from sdk_definitions.json
- Support multi-digit values for version ranges, via "+" in the RegExp
- Turn the RegExp expression into a raw string for easier reading
- Fix shortVersion (Maj.Min.-1) handling by appending the ".-1"
- Explicitly define the Patch number range for 5.15 in sdk_definitions

Change-Id: Icf22f2b4f865b4d5bcff48569aa58137294129ce
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-04 08:26:04 +00:00
hjk
df26d12b73 Utils: Add a convenience function to iterate over multiple directories
Change-Id: I7959b65b5502362b15fab3c0fd78b3e76431ff64
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 08:00:51 +00:00
David Schulz
9dc1fb3381 LanguageClient: allow aborting hover handler on unreachable clients
Change-Id: I1163144de7d37d3e270e31f2bf523ba812a937a5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 07:17:41 +00:00
Marcus Tillmanns
e51790a180 android: remove superfluous >
Change-Id: I01ab2b5045f6037a4fd89b5ad02f105292d02e88
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-04 07:16:07 +00:00
David Schulz
37400e9084 LanguageClient: do not accumulate response handler
Change-Id: Icf297ddf09bb64aea1d50fb24efa231df01eaed1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 07:09:44 +00:00
David Schulz
a23311f8e7 Debugger: use QtcProcess output buffer
Change-Id: I03326879bbcf2411a1feab8b6826ddd4c0981286
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 07:09:35 +00:00
David Schulz
5a2b8a6218 Debugger: remove unused CdbCommand
Change-Id: Idad2b62ca60da1749970ced21445c2d82bc2a798
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 07:09:21 +00:00
David Schulz
dc94ce83ac Debugger: sort cdb engine includes
Change-Id: Iddbf7dace0f8b5f36ad2ab9823815588ac087042
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 07:09:08 +00:00
David Schulz
9eef4bd2f1 TextEditor: remove mark width factor
Needed to optimize painting of different text mark icons in one line.

Change-Id: Ia7f9dd12020e2a21875b3de54b65257f8ea337d9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 07:08:59 +00:00
Eike Ziller
91fb0cf123 Merge remote-tracking branch 'origin/8.0'
Conflicts:
	src/plugins/qmldesigner/qmldesignerprojectmanager.cpp

Change-Id: I5106bb632c2a3a144287097137be45b0894b9ee4
2022-07-04 08:53:22 +02:00
David Schulz
1ce044ef7a Editor: Update document layout only if the mark color changes
Change-Id: Ic0408e87422edcf880381a20d685b24c785919c3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-04 05:06:17 +00:00
Orgad Shaneh
4180e1b84f CodeAssist: Fix Coverity issues
* Initialize m_reason in IAssistProposal.
* Remove superfluous null validations.

Change-Id: Icb9b7a7a98db719540586142e30be75f37a4ab92
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-07-04 04:42:22 +00:00
Christian Stenger
ce74e9fb2d Provide Squish integration plugin
Change-Id: I43ae2ad35441339fa48714c14094b8003d0cf7c3
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-07-04 04:26:04 +00:00
Thomas Hartmann
866f16adb1 QmlDesigner: Fix TextEditorView::reformatFile
* Updating the document only if it actually changed
* Using the text cursor of the widget
* We can rely on the widget to exist
* Simplify how the cursor is restored

Task-number: QDS-6410
Change-Id: Idaa384533f12b9b7ad7078bcdc37c1afaf651662
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-01 17:30:21 +00:00
Mahmoud Badri
5a9a6804ee QmlDesigner: Implement drag-n-drop materials to the 3D Editor
Fixes: QDS-7011
Change-Id: Id6e4aea2c19561ea861507480636ae2358ece067
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-01 15:38:29 +00:00
Thomas Hartmann
b5a34902d0 QmlDesigner: Remove QTC_ASSERT
This crashes if edit3DWidget() is null and we check below.

Change-Id: If993b73461fb442fb6d668ba9fc15c46ea763a11
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-01 15:04:34 +00:00
Alessandro Portale
8a83938886 Android: Fix OS-specific parsing in parseDependenciesJson
The Linux-specific sdk_essential_packages should not be installed if on
Windows.

Change-Id: I6b13a131785c7a76a35abf282dacdf915781e6d1
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-01 14:20:31 +00:00
The Qt Project
d69cf8096d Merge "Merge remote-tracking branch 'origin/7.0' into 8.0" into 8.0 2022-07-01 13:27:55 +00:00
hjk
1257a4c5c3 QmlDesigner: Suppress some warnings when build without tests
Change-Id: I1358e7fa754b65d82261b1a512279e8122c597f7
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2022-07-01 13:26:08 +00:00
hjk
b29ca1e345 ProjectExplorer: Drop encoding roundtrip in gcc detection
Change-Id: I6fb407465f634287edeba59fe6427ddb0299112f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 11:42:34 +00:00
David Schulz
f587a0b186 ProjectExplorer: set correct task type
Change-Id: I56f9e66cde30d5ebb182f0badc4e1cb134237fe8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 10:32:17 +00:00
hjk
451da3e104 ProjectExplorer: De-noise kitinformation.cpp
Change-Id: I55d443e807dc0bcd737fb8edf0dac2301e00a6c3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 10:13:10 +00:00
hjk
7cc06b85d0 Replace more used of PathChooser::pathChanged by filePathChanged
Change-Id: I0f92be6fcfd0a5319ad9f5d3681266966e40705e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 10:07:24 +00:00
hjk
5a75da8d1a Utils: Avoid a use of PathChooser::pathChanged
Change-Id: If904cd81ac6e11a22872c2d97a39381499b16bec
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 09:44:23 +00:00
hjk
13d2516355 ModelEditor: Avoid a use of PathChooser::pathChanged
Change-Id: I3fa563d46c7dcd4d02b2452e0b233586b431282c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 09:44:14 +00:00
hjk
e2c8866f2a ProjectExplorer: Replace some uses of PathChoosers::pathChanged
Change-Id: I3b0cc4218d1b0222f49bf98bbff206a38fa0b571
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 09:44:07 +00:00
hjk
84a3529846 BareMetal: Avoid some uses of PathChooser::pathChanged
Plus some cosmetics.

Change-Id: I39924a0490b6f3a08a994388780628ebaf023b3a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-01 09:30:28 +00:00
Tim Jenssen
56bcad81ad Merge remote-tracking branch 'origin/7.0' into 8.0
Change-Id: I7cd5d3808007ef739212f4347ba9b16e7b298943
2022-07-01 09:22:10 +00:00
Tim Jenssen
a920bbf59f qmldesigner tests: remove unnecessary defines
Change-Id: I1363e7e2ac174b51236644dd37fe184e711e96d3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-07-01 09:17:39 +00:00
Jarek Kobus
c14f30a99b McuSupport: Use allOutput()
Instead of self constructed mixture of output and error.

Change-Id: I3937a861f6e629f5613cd365486386e2a2db29b3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-07-01 08:52:57 +00:00