Commit Graph

62421 Commits

Author SHA1 Message Date
David Schulz
89e16e8b8c Python: map building directory to pyside project device
Change-Id: If261483864a5e4a13554fdefbf3d9076b7d1f687
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-20 12:47:05 +00:00
David Schulz
f012f1b245 Python: try to find interpreter on device for run configuration
If the default interpreter is not on the run device of the kit try to
find any interpreter on that device and use it as the default
interpreter for this run configuration.

Change-Id: I52985281f0f1d2ac88759169400d64121299f95d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-20 12:46:44 +00:00
David Schulz
c81a5c0644 Python: trigger parse in build system creator
Otherwise we do not have any app targets for the python run
configuration after a kit setup.

Change-Id: Ib7648a72280a1d68246c11139775a23366fda286
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-10-20 12:46:37 +00:00
Henning Gruendl
cf9b36a6c7 QmlDesigner: Use AUX property to remember state
Use AUX properties to save the StateThumbnail state (property changes or
thumbnail). Also the save the state of the property changes state
section (expanded or collapsed).

Task-number: QDS-7732
Change-Id: I607bb05b7c71bb98e7781d058bb5736ab4b77e72
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-10-20 12:10:25 +00:00
Cristian Adam
d643ad80cb ProjectExplorer: Allow "cc" for MinGW imported compiler
Amends 152c01bd86 which added "c++"
as a C++ compiler.

Change-Id: I8ad77a488b74dce6170ebf824b7f372083847a2c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-20 12:04:07 +00:00
Leena Miettinen
c4ac5e414a UI text: Use a full stop in the end of messages
And fix the capitalization of some message box titles.

Task-number: QTCREATORBUG-28334
Change-Id: I858eefd5a12494723c40e0253a3708fa77284d1b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-20 09:25:08 +00:00
Jarek Kobus
d0278ae295 SelectableTextEditorWidget: Handle display settings
Avoid code repetition inside UnifiedDiffEditorWidget
and SideDiffEditorWidget.

Connect to display settings changed signal and apply
all but 4 settings (which are not desired for diff editor).

Change-Id: If4ae7f7c55690dac04fd1a00f8822db666a9ce2b
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-20 09:19:07 +00:00
Mahmoud Badri
0ac1920ed2 QmlDesigner: Clear search upon adding a bundle material
Fixes: QDS-8025
Change-Id: Iaa1f7d9f94b602e60171a00d0cc51d5b19d71468
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-10-20 08:09:53 +00:00
Marcus Tillmanns
36d7dcb6b2 CMake: Improve styling of cmake buildconfiguration
Shortens the "Run CMake" button and the cmake variables
tab header to make them easier to read on wide monitors

Change-Id: I2579a8fa1c2899ae94f9c4a72c4188dc61ecd5f9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-20 07:56:02 +00:00
Leena Miettinen
7c9d1ef516 UI text: Fix UI text to follow the guidelines
- Fix typos
- Replace "options" with "preferences"
- Fix capitalization
- Remove "please"
- Do not use contractions

Task-number: QTCREATORBUG-28334
Change-Id: Ie029eae435634aa2fb354e173fa107af72f7b025
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-20 07:38:32 +00:00
Miikka Heikkinen
c45f4eb654 QmlDesigner: Add support for easingCurve property to EasingCurveDialog
QtQuick3D.Particles3D.ScaleAffector has easingCurve property.
We want to use existing EasingCurveDialog to edit the value, but the
current dialog only supports property named 'easing' (used in
animations). Added support for 'easingCurve' property as well.

Task-number: QDS-8014
Change-Id: If0f47608f7ed3cb9db4a44f632d15b2135856800
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-10-20 07:35:30 +00:00
Leena Miettinen
b9e45d7b30 UI text: Fix spacing in multi-line messages
You need an empty space at the end of a line (before quotes),
but no empty space after \n.

Task-number: QTCREATORBUG-28334
Change-Id: I192836cb10b819a359778879c64e6b80aaa059f2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-20 07:02:52 +00:00
Marcus Tillmanns
3ac5051af9 Utils: Fix FilePath::fromString host decoding
Previously FilePath::fromString did not decode %25 (%) and %2f (/),
so a round of ::fromString(::toString()) would not return the same host.

Change-Id: I99c7317fb149443c2e52c099f7da7c4ef6768aff
Reviewed-by: hjk <hjk@qt.io>
2022-10-20 06:45:42 +00:00
Christian Kandeler
5c313b706f ProjectExplorer: Show missing warning text in MakeStep widget
The tooltip didn't show up at all, and even if it had, it would be weird
to have a warning icon all by itself.

Task-number: QTCREATORBUG-25089
Change-Id: I517c762b050f93aa2f2c4aa89f208e4ccb7515c5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 14:00:20 +00:00
Artem Sokolovskii
60cd36ed31 ClangFormat: Remove deprecated entries in clangformatconfigwidget
Task-number: QTCREATORBUG-28263
Change-Id: I48b0456f3c7bea88905cea40d1e447655da64676
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-19 12:39:31 +00:00
David Schulz
938e9cab0f ClangCodeModel: fix null pointer access
Change-Id: I2c9e4dc04b7b27986eb0a3a74d8fa6879715df87
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-19 12:25:55 +00:00
Yasser Grimes
2d5512f2c4 McuSupport: Indicate the usage of QtCreator9+ for QtMCUs 2.3 and above
Starting from QtMCUs 2.3 legacy code is not used in McuSupport plugin
and the refactored code is used instead.
Trying to use 2.3 in older versions of QtCreator will result is using
incomplete refactored code causing errors when generating kits.

This commit will indicate to the user to choose the correct version of
QtCreator for newer QtMCUs releases.

Task-number: QTCREATORBUG-28286
Change-Id: Ib3934ef50f9cee81f1fac8a36674473fc2169ef5
Reviewed-by: Rainer Keller <Rainer.Keller@qt.io>
Reviewed-by: Sivert Krøvel <sivert.krovel@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-19 12:24:13 +00:00
Leena Miettinen
14938b3881 Extension system: Make message shorter by removing repeated text
Task-number: QTCREATORBUG-28334
Change-Id: I44f95e96d16390b355628d9b8f6bc2b5a79025c2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-10-19 12:11:40 +00:00
David Schulz
3754ce184d LanguageClient: remove refactoring markers when deactivating document
Fixes: QTCREATORBUG-28182
Change-Id: Iab52862ecc205c65d8fbdac34b5f9bc78766e33b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-19 12:01:59 +00:00
hjk
b4446607ec App: Also accept --version with two dashs
That more common on Linux.

Change-Id: Id724932565a6d5292012e446914ef4fac1b4f652
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-19 10:54:16 +00:00
hjk
0819bf3781 App: Make -version output go to stdout
Fixes: QTCREATORBUG-28327
Change-Id: I0a263ec79ab49a4d1d0816fe798d8a0403e6fce0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-19 10:52:57 +00:00
David Schulz
0c7883f384 LSP: Fix translatable error message
Change-Id: I687c58d87e75ac665aaa1817cf5ddd06382008d7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 10:30:54 +00:00
Eike Ziller
2f3a6fff93 System settings: Fix translations after context change
The context unnecessarily changed from Core::Internal::SystemSettings
to Core::Internal::SystemSettingsWidget. Change it back.
Some translation were partially updated inbetween, remove duplicates
by prefering the new translations.

Amends dae9cb13cf
and b0847af740

Change-Id: If604c5fa0f40d8f5ac273f01c189ffaf45b67811
Reviewed-by: hjk <hjk@qt.io>
2022-10-19 10:12:56 +00:00
Christian Kandeler
0759f55c00 ClangCodeModel: Make use of clangd's new "definition" modifier
See https://reviews.llvm.org/D127403.

Change-Id: I791b2396266810bfb3610a9f37565e4f01d67879
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-19 10:09:16 +00:00
Cristian Adam
1c51dc1adf CMakePM: Do not use systemEnvironment() for CMakePresets
This doesn't mean that CMakePresets will work with a remote project, but
at least it avoids Environment::systemEnvironment() usage.

Change-Id: I17081c747d32e50224ac74507d3aa336ff5c8948
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-10-19 10:08:06 +00:00
Eike Ziller
fdee55643a New dialog: Fix translations after refactoring
The translation context unnecessarily changed. Change it back.

Amends 4e7ee4687b

Change-Id: Iee0f862bc492c6e90d58050d8a217eb9d485a2ee
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 09:59:34 +00:00
Thomas Hartmann
5ca3db5ff7 QmlDesigner: Fix crash
We access the rewriterView() for the decription.

Change-Id: I30883d02ab1a2b12dcd6a2bcac6fae82b97a2f5b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 09:45:51 +00:00
Thomas Hartmann
1523129d50 QmlDesigner: Add helper function to StylesheetMerger
Change-Id: If3857af4a3541cb1b77a87d168f33571954dd5e4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 09:45:41 +00:00
Thomas Hartmann
ea13277c7a QmlDesigner: Fix StyleMerger for custom types
If the template uses custom types they are only found if
we register the correct fileUrl.

Change-Id: Ia358a39d5c5c5bbcaf403ae3c250495ddadfc326
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 09:45:32 +00:00
Cristian Adam
23092b57b8 CMakePM: Use filePath().deviceEnvironment() to find ninja
Amends 45ec26783f

Change-Id: I05b52295841d60ff693d6e7b12c9e4ceaf0f09eb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-19 09:32:23 +00:00
Cristian Adam
ae07c31976 PE: Clean environment before compiler environment detection
By calling vcvarsall.bat with "/clean_env" before the actual
vcvarsall.bat call we make sure that the correct environment settings
are picked up by Qt Creator.

For example calling Visual Studio Community/vcvarsall from an
environment where Visual Studio BuildTools/vcvarscall was already
called, will not return a Visual Studio Community environment, but a
Visual Studio BuildTools environment.

The above scenario can happen when developing Qt Creator itself with a
different Visual Studio setup.

Fixes: QTCREATORBUG-28315
Change-Id: Ib99cbba2a5c6299953728e92cf0283c10f7837f3
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-19 09:11:20 +00:00
Marcus Tillmanns
6dd15ef3f3 ProjectExplorer: Ensure working dir is reachable
Previously the working directory might not be reachable by
the executable.

This change fixes that by calling "ensureReachable", and
changing the path to an on-device path of the exectuable.

This also fixes the path when the Host is Windows, and
the build device is a unix type system by changing the paths
from e.g. "c:/..." to "/c/..."

Change-Id: I6c86e16c867bb654b6c2a4951d9f62fdb879298e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-19 08:56:35 +00:00
Cristian Adam
389d2acd87 Utils: Add arm64 support for qtcassert's dumpBacktrace
Change-Id: I91918689b2d2cde89f7879c482c7826eb55f1c16
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-19 08:47:54 +00:00
Marcus Tillmanns
4cab804e85 Utils: Don't return self during find
find can return the directory that is searched in as
one of the results. We need to filter it out.

Change-Id: If2902497e67d3a7a216430e725ec86227a392ccb
Reviewed-by: hjk <hjk@qt.io>
2022-10-19 08:23:10 +00:00
Eike Ziller
638e73e4f8 Clangd indexing: Hide cancel button, open settings on click
Since we cannot reasonably "cancel" indexing, hide the cancel button
from the progress indicator.
Open the Clangd settings page when clicking on the progress indicator
instead.

Fixes: QTCREATORBUG-27744
Change-Id: I625464e7f7456bcf7f01ce7e52f6bd6b53e3d8b2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-19 06:24:54 +00:00
hjk
ada6989079 RemoteLinux: Allow use as build device unconditionally
Works out-of-the box for plain C++ "Hello World" & CMake.

Change-Id: I696886582ad2db98e40dd31ad5d9bf8f7d30aabb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-19 06:01:55 +00:00
Orgad Shaneh
0dd8d64060 Revert "ProjectExplorer: Simplify node creation"
It breaks the project tree, at least for Qt Creator CMake project.

This reverts commit d1284570d6.

Change-Id: Ic5fe14cd4da476ca421551968e67fb8688433bbf
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-19 05:39:15 +00:00
Jarek Kobus
d85dd1962b QtcProcess: Disconnect from ProcessInterface signals
... on destruction.

Change-Id: I6751e1ba2999f506e85ebb697a8a1c7152ea9abb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-18 16:48:43 +00:00
Marcus Tillmanns
5c7c3a410d ProjectExplorer: Use device env when inspecting gcc
Previously the host environment would be used while inspecting
a gcc / g++ compiler. When doing so on a Windows Host
against a Docker target, this would fail.

Change-Id: I0e7b392101cee23e17813fa07f6c04bb9d3999c9
Reviewed-by: hjk <hjk@qt.io>
2022-10-18 16:18:07 +00:00
Thomas Hartmann
3be3663bf7 QmlDesigner: Do not compare type names for file components
For file components the fully qualified type name is not properly
defined and the component is created from source anyway.

Task-number: QDS-7992
Change-Id: I2c2754c1bab53257a210c2e4de990a0a768618a3
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-10-18 15:31:40 +00:00
Thomas Hartmann
edd07ff986 QmlDesigner: Delay project preview generation by 10 seconds
This way the preview generation does not block opening the project
and the project is fully loaded. If the preview is null
we store this in the data base and wait one hour until we
try to regenerate it. Otherwise we might try to render a preview
whenever we switch files.

Task-number: QDS-7992
Change-Id: I80a078ec7b8d418fa1fccd14bc4603b82c36c5e0
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-10-18 15:31:32 +00:00
Thomas Hartmann
d3e83f601e QmlDesigner: Fix test testRewriterSignalDefinition
Otherwise the check if the property was handled will throw an assert.

Change-Id: Ifc2fab22cd10ae811cd36137196c1ed6ba82677e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2022-10-18 14:42:41 +00:00
Marcus Tillmanns
f7a2132598 CMake: Don't filter out new keys
Previously, if you have a filter set in the CMake Settings
variable list, adding a new one would immediately hide it,
as the text filter hides the "<UNSET>" key. This made it look
like the adding failed.

With this change, new Variables are always shown so
they stay editable to user.

Change-Id: I9c2eb7f9983b23e1cd3aa50f589142551caaf56f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-10-18 14:29:54 +00:00
hjk
4266f612e6 Utils: Rename FilePath::relativePath() to relativePathFrom()
Hopefully less confusion about the direction.

Change-Id: I61727d6c4d19e0dfe46f24ff24f5d90f9835d05c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-18 13:41:24 +00:00
Alessandro Portale
54f7ebf001 Utils: Fix missing DetailsWidget outline
On some systems, QPalette::Midlight can have the same color as the
background color. So instead of using QPalette::Midlight on non-macOS,
mix our own color with 15% text color intensity, to visually match what
Qt Creator < 9.0 did.

Change-Id: I40848b5e16344c07f42c20415194f893641d5f70
Reviewed-by: hjk <hjk@qt.io>
2022-10-18 13:33:15 +00:00
hjk
d47a72e26c CMake: Use the OS of the source directory as ${hostSystemName}
In case of building on a remote system  CMake considers this remote system
as host.

Change-Id: Ifb9d0b2a2c4c49ba4ee009795f5b432c7b951e0d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-10-18 13:26:01 +00:00
Eike Ziller
471b036803 CommandButton: Fix build with older Qt versions
Make sure QAction is included not only accidentally via other Qt headers.

Change-Id: I946bcdc852989f50d1464393013169c00aa8172f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Sivert Krøvel <sivert.krovel@qt.io>
2022-10-18 13:22:14 +00:00
Eike Ziller
101ef19d1e ImageViewer: Show current default settings in tooltip
List the current default settings in the tooltip for the "Set as
Default" button.

Fixes: QTCREATORBUG-28322
Change-Id: Ic3a21218a60821e328d6db2375a0e5a08616d686
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-10-18 13:08:58 +00:00
Orgad Shaneh
1478a36530 ProjectExplorer: Fix prepending executable path for custom toolchain
Amends c60c642fe5.

Change-Id: I214c3d83ef5f1642d581e84f9219e929d765c471
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-18 12:56:58 +00:00
David Schulz
60a8e987b5 Docker: use docker device os type for file access
Change-Id: I3e3e91491c77d0146f2d52777ba1d05d2f45a9d3
Reviewed-by: hjk <hjk@qt.io>
2022-10-18 12:37:50 +00:00