There is a case where we need the no-port version even with a
non-standard port.
Provide access to both version, but to avoid confusion, make the
difference explicit in the function names.
Fixes: QTCREATORBUG-29616
Change-Id: I9b93b7dd89099a4f24a7c7c0174bdc97b85666d4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Without the default value setting the initial value already
triggers a 'Restart now or later' on closing the settings
dialog without canceling.
Amends 3726f0d6c1.
Change-Id: I3fa7071d945fbee1d282e46ad47b0d46b47ddbcb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Assign a name for a label for easier retrieval and fix the used
objects inside the shared script.
Change-Id: I1769b87d776a2dc9fee9ca9eb26805f6a8475fc0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This reverts commit 9dc9a43f40 as this may
lead to having multiple different fonts in similar widgets, even inside
the find toolbar compared to the editor when having different font sizes.
As there is no good solution to make this more consistent and appealing
revert the original patch.
Change-Id: Ie59bdb43721c467345e029376f13fa88b12d5e92
Reviewed-by: Tasuku Suzuki <tasuku.suzuki@signal-slot.co.jp>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The name of the android-*-deployment-settings.json file will be required
in other places.
This factors AndroidQtVersion::androidDeploymentSettingsFileName out of
AndroidQtVersion::androidDeploymentSettings.
Change-Id: I41d4c978adb94776df7621369dbe545faabf81ac
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
This way the popup message is not spanning the whole screen.
Testable with find_package(Qt7 REQUIRED).
Change-Id: I3f1943b603baa02c55f2f8f63c75908468e69d9a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
We changed the QHash and then accessed the invalid iterator.
Change-Id: Ia6f4536cff92776b8d74f96224dee84e3b28fac3
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Function completions nowadays provide the special tooltip holding
the variations of argument lists if it is an overloaded function.
Check for it and if it is present just close it to avoid an endless
loop.
(When processing the file we use 'Cursor Down' to navigate through
the file but if the tooltip is open we just toggle between the
overloads and process the same line again and again)
Change-Id: I21742c5a460cf1537151e30c3135bebb83695703
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Instead of making the OS specific decision whether to set DPI rounding
options or not in several places, leave the OS specific check to
StyleHelper::defaultHighDpiScaleFactorRoundingPolicy() and test for
"Unset".
Change-Id: I37ab4a0c643d1b1597e5f45496510f2f36f1a386
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Some ffmpeg binaries come without the ddagrab filter, e.g. the ffmpeg
binary that is contained in the latest ImageMagick package for Windows.
Therefore, offer the older and omnipresent "gdigrab" device option as an
alternative, chosable via ComboBox in the settings.
Change-Id: Idc5f8e2a6597d93f79a603733456f83a90c31505
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This patch also allows the user/installer to supply a path without
the device root, to make it easier for the installer.
Fixes: QTCREATORBUG-29694
Change-Id: I641b06dd2f4a9d94079fb26f2ed949c5246c1c1e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
In principle that'd be fine there, but the host equality is too strong
in some cases (isSameDevice should help), but it also still gets fed more
or less random content to create display names. Finding the exact
condition is tricky, and the remaining path is good enough.
Change-Id: I4ec29c2f259a7b761d00012bcd9a6d69a057043c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
We can't use SCREEN_TEXTURE to apply fade as it doesn't contain
transparent objects. However, it turns out it's not actually necessary
if the grid itself is also transparent (opacity 0.99 is sufficient),
so SCREEN_TEXTURE use was removed.
Fixed all components of the helper grid to have same bounding boxes, as
it appears bounding box of the mesh is relevant to alpha calculations.
Now subdiv lines of the grid no longer randomly change their alpha
values when just orbiting the camera.
Orbiting the camera also caused constant property updates on the grid
material due to float math rounding errors, so round the result to
five significant digits there.
Limited the grid area to 30000 units as there is not much point
in bigger grid due to the fade and very large objects can cause other
issues.
Fixes: QDS-10821
Change-Id: I65c31e99a45fd30186dcdcb185f9978b5c1b322e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This fixes the issue that the SelectionAspect was read incorrectly,
causing an invalid settings entry of "-1".
Also the settings key changed for the quite probable case that some
early testers have the invalid "-1" in their settings.
Change-Id: I97061e2787068bc3bb6cf4bd2d7b0aab767598d5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Mechanical, plan is to move m_mainWindow there and switch
around construction.
Change-Id: Ic7936623586ac68c2cdd69a40042262802579d23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
To improve the speed of parsing the result of a remote
cmake call, we move the file fetching and parsing into a
mapped concurrent call.
We also first uniquify the list of files to remove duplicates.
Fixes: QTCREATORBUG-29618
Change-Id: I18108928ba3b5f4f8ec3d5610b216c5ccf060877
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
In Qt 6, the API and environment variables intended to influence the
HighDPI behavior changed quite a bit. Until recently, (see "Amends"
change), Qt Creator still supported the Qt 5 options instead of the Qt 6
options.
With Qt 6, HighDpi support is always enabled. Just the DPI rounding
policy should be set by user or application.
This change adds a ComboBox in the General settings, which allows to
select a DPI rounding policy:
https://doc.qt.io/qt-6/qt.html#HighDpiScaleFactorRoundingPolicy-enum
The default setting is "PassThrough", which is the default policy for Qt
6, and which is also the default in Qt Creator since version 11.0.2.
Amends: d1deeb2c0d
Fixes: QTCREATORBUG-29501
Change-Id: Ib19b40cb3945cecc71b7c10f42fa2b06b3cc6153
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
E.g. cppquickfix_test.cpp in Qt Creator is ~260KB, and editing it is
quite sluggish with ClangFormat enabled.
Change-Id: Ifa0db8198b8c15fd03571176b9e94f046da3e44d
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Remove the unnecessary re-setting of the text edit
content due to the undo => edit => undo => edit
connection.
Fixes: QTCREATORBUG-29688
Change-Id: I7838ed594ae3741df757fa5eb3cdd90506428be3
Reviewed-by: hjk <hjk@qt.io>
Make sure that the container state is synchronized
with the main thread.
Change-Id: I8b50a380779038b273a1eb6645aa08309e90bc56
Reviewed-by: hjk <hjk@qt.io>
We test for equality by the pointer. To ensure it is uniqueness we now
search for the qualified name. If we get a hit, we use that instance. We
have to add the qualified key too into the cache to make it work.
Change-Id: I7f09203aad5591c41798902a75fc971ece7e1c05
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
You can now return a container and it will be appended to the result
container. That has the drawback of generating temporary container but
if we get them already it makes the code much more readable than a raw
loop.
Change-Id: Ibcd38e85ef759c18cd8da0fac0185f0f6fc123e2
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
