Using the new .json wizard engine allows us to get rid of much old
custom wizard logic. As additional benefit for the end user of Qt
Creator, the .qml.ui split is now optional.
Change-Id: Ic6d35e650cf0a7735cdfac9080f95015309a5879
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Otherwise we get a lot of confusing noise in that case.
Change-Id: I0fb77b0ae841fd863790acd86f2b24acab0e7374
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
The previous code miraculously moved window and range to the right
places, but went through a series of invalid states in between.
Change-Id: Id6b1fd6d615d7900beda914a0415720a57d464b5
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Doing this correctly enforces the const-ness of the private class in
const methods of the public one.
Change-Id: I846cadfd4838cb56db9871469ba18ac861e2eb48
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This is more in line with what the other render passes do.
Change-Id: I80381e9436fa02c4573283c23a89873f3d6ade2a
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
We have to make sure that all the nodes get deleted when the states are
deleted. Previously, we relied on the RenderState destructor to
recursively delete nodes owned by their parents. This is rather hard to
understand and can easily fail if we create a pass state without calling
TimelineRenderState::assembleNodeTree() afterwards.
The best way to deal with this is to properly encapsulate the nodes into
the states and add destructors which delete them.
Change-Id: I8b1ce16084afc1c85a90609f8f8d889147f7832f
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
As TimelineAbstractRenderer sets the flags it should also clear them.
Change-Id: I78245a9d9048ed50cd0819cc48d22bed89531883
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
"modelId" is the term used everywhere else.
Change-Id: I36204a68e0b2537a1efa2f50737f3fb618d8bb8a
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This is a handy helper function for derived classes but shouldn't be
used from outside.
Change-Id: Iaa357c63cd711c38f299f30e0c7ed35b88b52b24
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
By limiting how often we scroll to the bottom and thus limiting
how often we redraw.
Change-Id: I42ec9dc6284112025108000420ccdfdf5d003f34
Task-number: QTCREATORBUG-14307
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
QWizard used to enable the back-button again after we were done
disabling it.
Change-Id: I14d756536de7d23cc4e6bac3a4e5a1d18b91f46d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The only thing they did was trigger some QML code that set the zoom to
10% of the available range. 10% is somewhat arbitrary, so we shouldn't
have it in the general purpose timeline. Also, we don't really have to
pass the signal through several connections just to do that in QML.
The clearChildren() didn't have any effect there as dataAvailable()
should only happen if the view is already cleared.
Change-Id: I1813ed37a82fc3fd5c3b7fc02b2afb1dcbcadcfb
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Now that every usage of that command is using it in a separate
thread we can do that without any problems.
Change-Id: If38a734ceb5c519cd3ed28357374c83843e67c8e
Task-number: QTCREATORBUG-13634
Reviewed-by: BogDan Vatra <bogdan@kde.org>
We used to only identify the avd by api level and abi. That was
obviously incorrect, but at the time I didn't know how to get
the actual avd name from a running emulator.
Turns out this is reasonable easy via telnet on the emulator port.
Change-Id: I387901a5294674f44399c0726abcc9feea221e8d
Task-number: QTCREATORBUG-13095
Reviewed-by: BogDan Vatra <bogdan@kde.org>
... and cloning. Most aspects already did, it does no harm, might
save a cast later, so follow suit.
Change-Id: Id6275806657b723d4352a4b772b220cb9a2d9a5f
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
- change the line edit to accept actual text input in a form similar to
QKeySequence::fromString (with special "native" form on OS X)
- add a button that allows entering a key sequence by pressing keys,
including support for e.g. escape key, which was broken before because
it closed the dialog
- add a warning label, that allows filtering the list for all
potentially conflicting shortcuts
Task-number: QTCREATORBUG-6
Change-Id: I94fc63525f653127e87f6ef2bffe72d8dcaa867d
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
While at it, make non acceptable chars give better feedback.
Change-Id: I080f01592b2c8cbd6580734ca3e6fd46b9491106
Task-number: QTCREATORBUG-13589
Reviewed-by: BogDan Vatra <bogdan@kde.org>