Commit Graph

72533 Commits

Author SHA1 Message Date
Orgad Shaneh
52beb85676 ElfReader: Initialize a member
Reported by Coverity.

Change-Id: Idddb778e02e1a26c251c5ead3ed5700545abae12
Reviewed-by: hjk <hjk@qt.io>
2022-03-09 11:25:39 +00:00
Samuel Ghinet
a61f7db1ea Fix: Recents don't show up for Custom presets
In the New Project dialog for QDS, if the user had created a project
from a User-defined (i.e. Custom) preset, this preset did not appear
under the Recents tab.

Task-number: QDS-4989
Change-Id: Ib1f5e772fc9a45ad727627152f292f6e1178ee8c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-03-09 10:55:49 +00:00
Leena Miettinen
72eba8218d Doc: Describe Meson Parameters build setting
- Edit the build settings topic for grammar and style.
- Update screenshots.

Task-number: QTCREATORBUG-26610
Change-Id: I168a08921457cd62a013c64c3aaffcffb866626d
Reviewed-by: hjk <hjk@qt.io>
2022-03-09 09:12:14 +00:00
Miikka Heikkinen
2c32c9c991 QmlDesigner: Deactivate particle system when locked
Particle systems are now deactivated in 3D edit view unless nodes from
exactly one system are selected. Selected nodes that are not part of
any particle system are ignored for this determination. This now also
includes deactivating previously active system when an empty
selection is received from creator side (happens e.g. when selected
system is locked).

Fixes: QDS-6405
Change-Id: I5b1636640594e51db5d6e725684075727536b1a5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-08 11:32:54 +00:00
Assam Boudjelthia
4ba957f9d8 Remove "Device" keyword from platform device name
QC uses the display name set in IDeviceFactory to refer to the
platform name. However, the display name usually have the "Device"
keyword at the end because it's coming form the IDeviceFactory.
That would work fine for example in new device creation dialog.
But QC is using that in other places like new file/project wizard
to show the supported platform for a project, and that's where
having "Device" seems unnecessary or wrong.

This fixes that behavior, but removing that keyword when calling
KitFeatureProvider::displayNameForPlatform().

Change-Id: I5fd4bbcb1ec2579f8b7e86226a7d50b6d7807382
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-08 10:57:49 +00:00
Assam Boudjelthia
0f6e9f7146 Android: don't add all the Service meta-data for Qt 6.2+
These values were removed in Qt 6.2, don't add them in that case.

Fixes: QTCREATORBUG-27088
Change-Id: I5560b18c0a849f7382b498097923ba425e47c40a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-08 10:57:12 +00:00
Samuel Ghinet
618eda3572 Implement custom presets
Task-number: QDS-4989
Change-Id: I95844ae97204ad3bb94905c89f8e16b79eed8f64
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-08 09:39:43 +00:00
Miikka Heikkinen
ec02c157ee QmlDesigner: Simplify hidden and locked handling for gizmos
There is no need to have an event filter to listen to changes to
_edit3dLocked and _edit3dHidden properties, as they are only changed
in one place. We can simply emit the change notification there.

Fixes: QDS-6403
Change-Id: I8136f38fd8e435e3a4dbd69d70169496e1675dfa
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-08 07:38:41 +00:00
Assam Boudjelthia
e1643c8903 Android: display Android 13 packages correctly in sdkmanger
Change-Id: I49cc45dce0523e55ff56df7e429dd9dc93f46534
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-07 11:45:33 +00:00
Mats Honkamaa
f268c2b1fa Doc: Update 3D Editor docs
Updates to 3D Editor docs:
- Add info about Camera/View alignment
- Add info about Particle Editor
- Add info about visibility toggles
- Update screenshots

Task-number: QDS-6079
Change-Id: Ie1949956f61bbb51ea37e4fd58ca2817638297df
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-03-04 10:17:49 +00:00
Mahmoud Badri
c250d31ca0 QmlDesigner: Enable dropping external assets to a specific folder
Fixes: QDS-6311
Change-Id: I25bccfa6788e3b5d47fc598decbf7e03a00399b4
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-03-04 10:14:00 +00:00
Miikka Heikkinen
8da5a772fe QmlDesigner: Group also proxy actions of commands in Edit3DWidget
This fixes exclusion handling when actions are triggered via shortcuts.

Fixes: QDS-6301
Change-Id: Iedfaaed0c2f7d534fa77743a6daa093e334d001d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-04 08:29:29 +00:00
Robert Löhning
0fa5303916 Welcome: Replace search term when adding tags
Currently, both are mixed into one so neither of them works. When both
are separated with a space, the search term is ignored anyway so it's
better to just remove it.

Change-Id: I449b5d80dc50620f13f37c908e63877eb63b3c26
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-03-03 20:04:20 +00:00
Robert Löhning
50199cab93 Squish: Fix checkLastBuild() with python3
Change-Id: I25c02f91eab4a7cbf784ab726e0fe24210050a84
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-03-03 20:02:26 +00:00
Leena Miettinen
a61c39eb26 Doc: Update screenshots of New Project and New Wizard dialogs
Rename some screenshots and use them in several places.

Fixes: QTCREATORBUG-27139
Change-Id: I3986a3060710270b4d4400228d4917e83e3183da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-03 14:11:06 +00:00
Artem Sokolovskii
72991ea5c1 [ClangFormat] Fix bax with BasedOnStyle field
Behavior was: The field became "LLVM" after a change to another style.
Fixed behavior: BasedOnStyle field becomes and stays chosen style.

Change-Id: I0d41a216f7f06c5681cc20a52c736406307a3724
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-03 13:26:40 +00:00
Christian Kandeler
99f73bf37f Update qbs submodule
... to HEAD of 1.22 branch.

Change-Id: Id77d7265d226949cfce18124b4bee45b65c043f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-03 10:34:14 +00:00
Orgad Shaneh
c2cceee844 QmakePM: Fix potential null dereference
Reported by Coverity.

Change-Id: Ibdb47a711aca4989b22a7f94fd905deff86cb27c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-03-03 10:24:34 +00:00
Christian Kandeler
631e2c2a4a ProjectExplorer: Log some values to narrow down a bug
Task-number: QTCREATORBUG-26875
Change-Id: Ifad56dc711241a03d391328cae202adc338ee0eb
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-03-03 10:21:31 +00:00
Miikka Heikkinen
98673190ad QmlDesigner: Add visualization gizmo for ParticleEmitter3D
Particle emitters are now visualized in 3D edit view either by
a small sphere for point emitters or by a proper model for
model based emitters. The visualization model is rendered
transparent. The visualization models can be displayed either
always or only when the parent particle system is active
in editor.

Trail emitters are not visualized, as any visualization would
be misleading, since these emitters follow generated particles.

Fixes: QDS-6189
Change-Id: Idb6f12cadd9cea8110e5290cc18443aeb62c38d6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-03-03 09:34:57 +00:00
Cristian Adam
1b22558857 GitHub Actions: (re) Enable MinGW build
Both LLVM/Clang 14.0 and Qt 6.2.3 dependencies have been compiled
with MinGW 11.2.0

Change-Id: I14dc8b62d243f21dc31ba72605d5aa4b16085279
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-03 09:28:31 +00:00
Eike Ziller
ce400a4482 File System view: Fix persistence of Show Folders on Top
Fixes: QTCREATORBUG-27131
Change-Id: I0252cc2d9f026873c7a6a8e70e457a8d150ca1c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-03 08:51:04 +00:00
Cristian Adam
8c00c4c34e CMakePM: Do not modify container in loop
Amends 2f77dc3415

Change-Id: Ida99d5c83eb1b30865b90d83583244728efb38a7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 13:36:09 +00:00
Christian Kandeler
9735049e2c ClangCodeModel: Suppress "Unknown argument" error
Unknown compiler flags are an unsuppressable error in clang.
But we do not want to maintain a blacklist of unsupported GCC and MSVC
options or a whitelist of supported clang options, as both would
constantly go out of date.
As clangd seems to work fine despite the error message, we simply filter
out this type of diagnostic.

Fixes: QTCREATORBUG-27113
Change-Id: Ib32601831eded60daf80eb0ca5cf01bbd71493fa
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 12:59:54 +00:00
Christian Kandeler
f8cec0a85a ClangCodeModel: Properly highlight static data members
C_STATIC_MEMBER is mutually exclusive with C_FIELD, so it must not be a
mix-in style.

Task-number: QTCREATORBUG-27111
Change-Id: If9e5f44790f1b7d124f4b2e9859f8c2223c0c424
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 12:59:22 +00:00
Cristian Adam
1778008067 GitHub Actions: Update ccache to version 4.6
Change-Id: I112d3860c6e1b66be70d5cf2b11f026bafa624ad
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 10:06:50 +00:00
Cristian Adam
e1e5d2a68d GitHub Actions: Update LLVM/Clang to version 14.0
Change-Id: I168661c4a4c2a52e824b1cfaa8ed45db1d8682dc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-02 10:06:42 +00:00
Eike Ziller
897907f401 ImageViewer: Handle invalid SVGs and GIFs nicely
Fail opening the file in the image viewer, like we do for other images,
so Qt Creator can offer a different editor (binary editor).

We have separate code paths/backends for SVGs and movies (including
GIFs), which didn't catch invalid images early.

Fixes: QTCREATORBUG-27121
Change-Id: I1bfbca70b7d76ee9cac3e0f35494b62e3856069e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-02 07:48:33 +00:00
Tim Jenssen
2dfa9f0882 qds: fix crash, if two or more projects be opened
Change-Id: I8b91f8ce0139334e765d6dd55e1afefbbe5366c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-03-01 20:18:15 +00:00
Thomas Hartmann
1ea773f187 Help: Show home page when activating index or content
Instead of showing the last page this will always show the home
page when activating index or content from the help menu.

Task-number: QDS-6392
Change-Id: Ic158d22ba3739f5db513e04ebde00fdadc24a9d5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-03-01 19:25:39 +00:00
Tim Jenssen
d2b39c800f qds: add missing spaces to user visible text
task-number: QDS-6379
Change-Id: Ibe84b5526413e8294f13a46d4760101e18d0ab08
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-03-01 12:39:25 +00:00
Robert Löhning
a763f5d689 Squish: Port tst_SCOM04 to CMake
Change-Id: I71f8978a41b25b2ed5fffaac1be6ff77cb3099f4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-03-01 12:26:13 +00:00
Leena Miettinen
7e4ee37978 Doc: Fix "typos"
Change-Id: Ifc4f6295dad8263a53e4d8b7f1da44415d09b5fd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-03-01 12:08:24 +00:00
Mahmoud Badri
85eae98e6e QmlDesigner: Allow deleting multiple selected assets
Also small relevant cleanup to the code.

Fixes: QDS-6312
Change-Id: I31ed0204ad9ae541a822cc4b58ef303aa3da7a68
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-03-01 11:59:43 +00:00
Thomas Hartmann
5a31ba3564 QmlDesigner: Change states thumbnail size to 320, 320
Task-number: QDS-6390
Change-Id: Id125e96a6b1615b7ac5c8eafe680f61b84a5353c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-03-01 10:26:41 +00:00
Christian Kandeler
8247f4f3dd ClangCodeModel: Do not highlight objects in method calls
... as output arguments with clangd.
We might want to do so in the future, but right now it's not intended.

Task-number: QTCREATORBUG-27111
Change-Id: Ie6941f18943a1d6942901c526c62999cba6c1125
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-01 10:14:32 +00:00
Christian Kandeler
c5187da4ab ProjectExplorer: Respect leading whitespace in custom output parsers
Leading spaces are often relevant and must not be trimmed.

Task-number: QTCREATORBUG-26892
Change-Id: Ie5c119a2c4df22f2c7bae2c9abaf5362d51c8c4e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-03-01 10:12:25 +00:00
Christian Kandeler
41038ba8cf ClangCodeModel: Do not highlight argument of operator*
... as output parameter with clangd.

Task-number: QTCREATORBUG-27111
Change-Id: I5def562dcb9b8b0dac036fd46ed7e996c0297c95
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-03-01 10:04:16 +00:00
Mahmoud Badri
c7d2b8d5cb QmlDesigner: Don't process folders when opening a standalone Qml file
Only assets on the same level as the open Qml file are visible.

Fixes: QDS-6374
Change-Id: I51a1bad06ae98e5aa708517816c21395073859d1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-03-01 09:23:22 +00:00
Miikka Heikkinen
17710da67c QmlDesigner: Fix hotkeys for particle play and restart
The hotkeys overlapped transform gizmo hotkeys.

Fixes: QDS-6300
Change-Id: I3a87f2cedb218fbecea5641c86265f413487cef7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-03-01 08:57:23 +00:00
Thomas Hartmann
d7c330d454 Fix crash when widget was not created
We only create the actions in case the widget is actually created.
m_projectModel and m_sessionModel are intialized as part of the
SessionsPage widget.

Task-numnber: QDS-6332
Change-Id: Ib127de69ca4057c229bf977c012e5cd2b2a53f0d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-03-01 08:55:05 +00:00
Christian Stenger
869ad16d04 Squish: Remove outdated condition
Change-Id: I89029f50cc0a303111f9960eac3f3c17b4c05fb0
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2022-03-01 08:54:43 +00:00
Björn Schäpers
0803390a83 QbsProjectManager: Directly delete project parser
It holds a pointer to the future which is deleted directly 3 lines
below. And a signal (taskStarted) can come to the parser before it gets
deleted, then accessing the deleted future. Which results in a
segmentation fault.

Change-Id: I468c6477023488d6d922d6bf621cba886740d8f4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-28 19:29:56 +00:00
Leena Miettinen
fc82e593af Doc: Update Qbs settings
Task-number: QTCREATORBUG-26610
Change-Id: I98261c9fa36f34d8b13a2b12a3a545f6662916b5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-28 16:56:58 +00:00
Oswald Buddenhagen
691e3ff12d fix markup
Change-Id: I87f316aeff1d30c6df5758b7384c1020d8f7e55c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-28 16:54:41 +00:00
Leena Miettinen
659d82c499 Doc: Fix broken links when building with Qt 6
Some section titles have changed in Qt 6 and some
platforms and modules are not supported. Where necessary,
use fixed links to Qt 5 docs.

Fixes: QTCREATORBUG-27015
Change-Id: I469a630731f9c37deffe5ca454f5365310aaf713
Reviewed-by: Tommi Mänttäri <tommi.manttari@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2022-02-28 16:05:01 +00:00
Mats Honkamaa
741a2de6b9 Doc: Document toggling visibility of menu items
Debug, Analyze, and Build menu items are invisible by default.
Visibility can be toggled from Options.

Task-number: QDS-6372
Change-Id: I5134868e8cd08c229b6c3a8ff3c53a1cc67949ab
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-28 15:08:45 +00:00
Mats Honkamaa
e19fa8ba96 Doc: Fix link in particle tutorial
Broken link to the particle tutorial project.

Task-number: QDS-6387
Change-Id: I26f59fb1b8f935c384219623621204009302d86f
Reviewed-by: Tanja Remes <tanja.remes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-28 14:43:46 +00:00
Leena Miettinen
8ca2c21087 Doc: Move file about components and properties supported on MCUs
..from Qt Creator to QDS. The Components view is no longer
visible in Qt Creator by default. Moving the file makes it
easier to find its contents during search.

Change-Id: I340d54e990a4e5c09a51b94fe64f3b0e951911ff
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2022-02-28 14:26:51 +00:00
Leena Miettinen
a6c44fdb1c Doc: Remove remaining referrences to Library view
The view was divided into Assets and Components views.

Task-number: QDS-6216
Change-Id: I5a73f60e511bb2936a009bbe6f61004f9d85d348
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-02-28 14:26:45 +00:00