Commit Graph

80529 Commits

Author SHA1 Message Date
Jarek Kobus
7eb778dc3d Theme: Limit the usage of qMakePair
Change-Id: Ibc47dfc4f48ab1b3bc2fe77b353d13d1e22d8b8f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-04 08:05:22 +00:00
Jarek Kobus
43f3b70437 QMakeProjectManagerPlugin: Limit the usage of qMakePair
Remove unneeded Utils:: scope.

Change-Id: I9d42aa2005214004b91686168e2bcaa420354a6c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-10-04 08:04:05 +00:00
Jarek Kobus
4857a58fdd GitLab: Limit the usage of std::make_pair
Make the code less verbose.

Change-Id: If938923022f8bcdb2559328e03035b8b38145f3e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-10-04 08:00:24 +00:00
Leena Miettinen
eeb1cd22ce Doc: Describe new Text Editor > Display preferences
- Visualize Indent check box
- Tint whole margin check box
- Update the screenshot.

Task-number: QTCREATORBUG-27876
Change-Id: Ie61cf82e35f8dda75e0aeea08eda92993ff36a71
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-10-04 07:32:59 +00:00
hjk
23e96dd6fe Utils: Use a single QString as data store for FilePath
Plus a few integers to get access to the pieces.

This reduces sizeof(FilePath) from 72 to 32.

Change-Id: I65eb856ad47b6a250c705d8d01893781a21d8e02
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-10-04 07:27:16 +00:00
Mats Honkamaa
599c882057 Doc: Update custom property documentation
Task-number: QDS-7735
Change-Id: I1f4551e6d5f1319c73bc6e1b05c3c0390feecda9
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-10-04 06:38:10 +00:00
Marcus Tillmanns
5f1e4418de Sanitize: Add sanitize flags to shared libraries
For MSVC, all libraries need to have the same flags,
therefore we add them here.

Change-Id: If980ca138dfde0a5ec52b1879c2c703309950a37
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-10-04 05:45:30 +00:00
Mats Honkamaa
7d3593fc4a Doc: Add timeline animation tutorial
Add a tutorial describing how to use timeline animation and
binding animations to properties.

Task-number: QDS-6460
Change-Id: I99a586842f6cc6fe3acb0785757eb1d2de86df54
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-10-03 11:19:54 +00:00
Jarek Kobus
604730f14d CleanDialog: Use more FilePath
Change-Id: Id545b8c412d55d8e1976cbe0bbdad36e22eb93a0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-10-02 19:04:58 +00:00
Robert Löhning
f5c725cf23 Restore object names lost while inlining
Amends 715e5800a5
Amends e070d826e5
Amends f3bceeda53

Change-Id: Ifafc0b79fc751696443d1b1288d3a272851445b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-30 18:16:02 +00:00
Jarek Kobus
b6c8ce20e6 WebAssembly: Limit the usage of qMakePair
Change-Id: If4bdf567cf0dd1e01cbe41971f2d47ebc06a1d65
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 17:30:15 +00:00
Jarek Kobus
b885281ce7 Android: Limit the usage of qMakePair
Change-Id: Ic079174e75d3a538d5d97fc3931ddd035623f4a6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 17:30:09 +00:00
Jarek Kobus
c09c7ccba0 Differ: Fix broken logical XOR
I bet the intention was to do logical XOR operation.
In cpp it's done with operator!=().

Amends: 24a25eed14

Change-Id: Idfc5dbf09b4f4b6c81aa237a956d5d4e04155c09
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-30 16:52:12 +00:00
hjk
efbab2e7c4 CMake: Be a bit more specific on what is not reachable
Change-Id: I5d521a9562d36850c264e1af48b46e16c642fde9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-09-30 15:31:16 +00:00
Jarek Kobus
5ab100a2b9 CMakeProjectManager: Limit the usage of std::make_pair
Make the code less verbose.

Change-Id: I8dc194f0cb4ed38c4c117482a7011019444edc40
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-09-30 15:12:34 +00:00
Jarek Kobus
55efe40a58 Vcs plugins: Replace foreach with ranged for loop
Change-Id: I9be29ef128f49f62a6e1f450d8c5277b467310e9
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 15:09:42 +00:00
hjk
8640e00447 CppEditor: Proliferate FilePath use a bit
Change-Id: I7e2669c3adf5de39804da2bf06d99f5ae03447dd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 14:56:08 +00:00
Miikka Heikkinen
f2b2f488e2 QmlDesigner: Fix mouse position on material browser to 3d editor drag
The mouse position from Edit3DWidget needs to be mapped to Edit3DCanvas
before resolving the 3d position.

Fixes: QDS-7840
Change-Id: I85bc1e9268d6f683382a5431997263429ea13470
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-09-30 14:55:05 +00:00
hjk
57b32ed773 CppEditor: Inline cpppreprocessordialog.ui
Change-Id: I2941e6fd3da93d1a71fb7d98e6d39634ae957d42
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 14:52:12 +00:00
hjk
5ff70b6f99 ProjectExplorer: Introduce an IDevice::usableAsBuildDevice
Better approach than whitelisting ids from leaf plugins.

Change-Id: Ida7e23d7ea02eb76d7de4049737f2cb0fad2b9d7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-30 14:38:47 +00:00
hjk
4b1f1cb335 CppEditor: inline clangdiagnosticconfigswidget.ui
Change-Id: Ic0800378b31eac71c743cda13e7306c0c1131129
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-30 14:34:33 +00:00
Jarek Kobus
f65c42c797 Various plugins: Limit the usage of std::make_pair
Make the code less verbose.

Change-Id: I22ceb8d74567d78042f537b185f8e504227c24c6
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 13:37:52 +00:00
Miikka Heikkinen
243e473b4c QmlDesigner: Fix timeline check when committing dynamic property value
Timeline has to be recording for us to care about it at value commit.
Otherwise, if there is timeline but it's not recording, we end up
with soft assert and losing the dynamic typename, which causes
isDynamic checks to fail later on that property.

Change-Id: Ib63467ecc4fca1d14409d3c68bb3a5fcd13c10ce
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-30 13:14:05 +00:00
Christian Stenger
60d78e4bb0 Squish: Cancel wizard early if settings are wrong
Add an error label for the user and stop internal actions
to avoid displaying error message dialogs with less helpful
information.

Change-Id: Ie0d075121fabb56b67300eaf6c0ebde674475b9c
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-30 12:46:54 +00:00
Leena Miettinen
bea4dd861d Doc: Describe new locator options
- Open as Centered Popup
- Triggering all kinds of actions with the "t" filter

Task-number: QTCREATORBUG-27876
Change-Id: I6aebe62726fae9ba68d4f841cce6ee4cf7434747
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-30 12:46:36 +00:00
hjk
b1e8772848 CppEditor: Inline clangbasechecks.ui
Change-Id: I630f794377936139eade42f56a8bd46175e84143
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 12:39:29 +00:00
Jarek Kobus
8a645e8a1d GitPlugin: Limit the usage of qMakePair
Change-Id: I9a164d951c43a9fc30bbdfffada22d9876d35e3f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 12:27:12 +00:00
Marcus Tillmanns
34dc092642 Docker: Improve File contents read speed
Change-Id: Ic94715d2c362ac3aa75dabf4f95c74737abd6264
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 12:13:52 +00:00
Marcus Tillmanns
8d67bc36a7 ToolChain: Cache validity
Checking the validity of a toolchain can involve a call to
a remote device.

We cache the status now to speed up places that repeatedly
check the validity like opening the Toolchain Settings Page

Change-Id: I2b1d8aeba99fb9761d60d4710806bf4b767eaac9
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 12:13:43 +00:00
Christian Stenger
b3890d1b7c Squish: Fixup initial generated suite.conf
Change-Id: I217b2e6a1d89356b0482b91af53a1dd313f4efdd
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-30 12:13:16 +00:00
Marcus Tillmanns
b29c7bc4a6 FSEngine: Fix engine to handle root path correctly
Change-Id: Idd5b75875a87e624675ed40cba668caf5013e6a9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-30 12:13:08 +00:00
Mahmoud Badri
395e40b8f3 QmlDesigner: Allow dropping bundle materials to Navigator
Fixes: QDS-7844
Change-Id: If3c58f82797beabe76baf99ea2dddc59032729df
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-09-30 12:08:55 +00:00
David Schulz
4f9a5ea896 LanguageClient: Inform user of failed prepareRename request
Also instantiate the search result window if we get an error and use it
to display errors.

Change-Id: I49dcdcc5ad2ace64391f8d2d849995b046032957
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-30 11:59:52 +00:00
Christian Kandeler
9e27ea3bb3 Fix some compiler warnings
Change-Id: I67135a49c7bc8169dd159cdab381c21f27be02f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-30 11:53:11 +00:00
Christian Stenger
9ac0ac9ca1 Squish: Store opened suites into session
Opened test suites will now be stored into the session
and re-opened automatically when the session is loaded.

Change-Id: I5b7e55bf511918cb2e9eeec6f943cc7baced0a8f
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-30 11:37:17 +00:00
Jarek Kobus
4c1f410881 TextEditorPlugin: Limit the usage of std::make_pair
And qMakePair.

Change-Id: Id92a662fa0674b9e9f835280bb9378c8d00549e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-30 11:25:19 +00:00
Jarek Kobus
3885b936b6 CorePlugin: Limit the usage of qMakePair and std::make_pair
Change-Id: Ibf96ca29d2570841955366371f1bab11198b3e67
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 11:23:54 +00:00
Miikka Heikkinen
5da5830fa7 QmlDesigner: Fix dragging material from bundle to camera/light
Added check that target node is actually a model when applying material.

Fixes: QDS-7843
Change-Id: I6e165280c8b79ebbf8316861fe0eb9b947eac3be
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-09-30 11:15:00 +00:00
hjk
5d7c5e21c0 GenericProjectManager: Remove two uses of QFileInfo::exist
Change-Id: Ibfa64783ecd7150200683126b432abc8703debc8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-30 10:46:58 +00:00
Christian Stenger
ade4c33afc Core: Delay setting tab order a bit
Must happen after the respective widgets have been attached to a parent
widget.
Amends 38f88f6310.

Change-Id: Ib0841afb09cd12791422903c3bf38de2d0bd580c
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 10:23:36 +00:00
Jarek Kobus
d1e521d223 Utils: Limit the usage of qMakePair
Change-Id: I93eba395ddc580950a7eeb908555736ff48a3e3d
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 10:17:56 +00:00
Jarek Kobus
738803a4da Various plugins: Limit the usage of qMakePair
Change-Id: I9113dd47fb4f9026f3a732aebbd0aee31651b727
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 10:17:47 +00:00
Jarek Kobus
00741a7216 ModelEditor: Replace QQueue with QList
No QQueue's specific API was used anyway.

Change-Id: I6ac2d02c43ce4e3700589a4df97dd3f0983d23b9
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 10:13:12 +00:00
hjk
63f3921334 CPaster: Convert to Tr::tr
Change-Id: I00242638e483aa9cb5b54473982eed137e859ff6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 10:13:08 +00:00
Christian Stenger
c42ae96ba8 Squish: Move wizard into plugin
Avoids a soft assert when parsing the wizards without having
the Squish plugin enabled.
As the Squish wizard is using customized wizard generators
that are only available if Squish is loaded we should limit
the presence of the wizard file to this case.

Change-Id: I091c1e429f28b07679245abdc9a638135af84761
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-30 09:31:34 +00:00
Miikka Heikkinen
d238c50399 QmlDesigner: Store current value at material property copy
Now we store the current value of copied properties at copy time
instead of just storing a reference to copied property. This ensures
we paste the correct value.
When copying all properties, properties set by base state,
current state, and active timeline are copied.

Fixes: QDS-7804
Change-Id: Id6315dde96b30304fde007a87da578faaab43233
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-30 09:03:56 +00:00
Christian Stenger
1c8a1b9d82 Squish: Fix script generation
Handle whitespaces inside the application's name and
arguments correctly.

Change-Id: I5f3fc7c83e7b1e694e9f2a4583c6ac06b7528ff6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-30 08:37:55 +00:00
Cristian Adam
ee4c998ff3 CMakePM: Add supprot for CMakePresets version 3
This includes Condition and toolchainFile

https://cmake.org/cmake/help/v3.21/manual/cmake-presets.7.html

Task-number: QTCREATORBUG-24555
Change-Id: I1026390af67b2be1aa0c3b02b654fc19442d3c89
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-30 08:34:07 +00:00
Cristian Adam
45a275e054 CMakePM: Use architecture and toolset for project import
This fixes issues with Visual C++ generator, which needs the right
parameters to pinpoint the right compilers.

Also use CMAKE_TOOLCHAIN_FILE for qmake detection.

Change-Id: I6edc84c7ed1a892fbc5545ff61dc06ac20720f0a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-30 08:34:00 +00:00
Jarek Kobus
d2820ccdd3 ModelingLib: Limit the usage of qMakePair
Change-Id: Ic89f2a9598faadbda964f71dbe84bfd5400aec4f
Reviewed-by: hjk <hjk@qt.io>
2022-09-30 08:20:16 +00:00