ea550ee831
Core: Inline openwithdialog.ui
...
Change-Id: I4b849d87e4c0b95d992ddc54a169e6167264bc08
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
2022-07-28 07:04:58 +00:00
b3e3de517d
Core: Inline saveitemsdialog.ui
...
Change-Id: I3b3797fe963a26b18b076a0031d442119ab25d6e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: hjk <hjk@qt.io >
2022-07-28 07:04:51 +00:00
e7c59e8250
fsengine: Fix DirIterator::currentFileName, ::next
...
Change-Id: I958ff868ae11b66b62429d6aa9e01271a903b431
Reviewed-by: hjk <hjk@qt.io >
2022-07-28 06:34:16 +00:00
fef8942c42
CPaster: remove unused pastebindotcomsettings.ui
...
Change-Id: I4870f468052ead995535e972101626ef28296366
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-27 15:30:26 +00:00
82b330f509
CPaster: Inline pasteview.ui
...
Change-Id: Ib09de9def992f9d564eaf6398627f2b5633dd629
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-27 15:08:23 +00:00
e1a63ce928
FileUtils: Pass parent to file dialog
...
Change-Id: Ibbda132136215e34e078b943ac9909e42113643b
Reviewed-by: Marco Bubke <marco.bubke@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io >
Reviewed-by: hjk <hjk@qt.io >
2022-07-27 14:34:36 +00:00
f2ff0b9517
GlobalFileChangeBlocker: Use Utils::Guard
...
Change-Id: I0dd622535dfc933d242e1fa88d2f886fbe7bee49
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2022-07-27 13:04:40 +00:00
94310efa06
GlobalFileChangeBlocker: Don't install event filter on qApp
...
Connect to applicationStateChanged() signal instead.
Change-Id: I95ccabd06233902400bda0c01ea89b1c7cdf0e92
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Orgad Shaneh <orgads@gmail.com >
2022-07-27 12:45:00 +00:00
f9ae7c2bc6
TextEditor: inline highlightersettingspage.ui
...
Change-Id: Icc4b2fe7013f2ebb2eb57cc5f581798c87866ff5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-27 12:14:15 +00:00
230b98ce76
clangd: Add ability to change --limit-results
...
A user can set a value to the QTC_CLANGD_COMPLETION_RESULTS
environment variable which will be passed as argument to clangd's
--limit-results.
The clangd default value is 100.
Task-number: QTCREATORBUG-27152
Change-Id: Ic3e512a735fda1540b4f0ab56e39f9c5f0213e79
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-27 12:12:51 +00:00
072489829d
Utils: Make port.h slimmer
...
Fix the fallout. Also make comparisons hidden friends.
Change-Id: Ib16a294391f5732f94f9f411a48220b497691de2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-27 12:07:59 +00:00
df358c7833
ProjectExplorer: Remove unneeded #include in projectexplorer.h
...
And fix side effects.
Change-Id: Ib6f0c5618092f80204b409edec0a92004f2350d2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-27 11:56:09 +00:00
0f6a2bf640
ProjectTree: Avoid using sender()
...
Change-Id: I4c5606fb91f2f8714783272c5f5f48add2222e5a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io >
2022-07-27 11:09:09 +00:00
859f146760
WelcomePage: Only retrieve recent projects once
...
The recentProject list was retrieved for every ::data and ::rowCount
call. This triggered QFileInfo.exists call for each project
which was expensive. This fixes that so that the recent projects
are only filtered once for each model reset.
Change-Id: I6ce33a13c2446bece5b7dac1563ffa7bdc85bbaa
Reviewed-by: hjk <hjk@qt.io >
2022-07-27 10:17:12 +00:00
8d2f3ac3f2
CorePlugin: Add ok and cancel button to plugin dialog
...
Change-Id: I842be8fe3521026b98177e44925669fc5e67c83f
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-27 10:00:56 +00:00
0db66ae72c
TextEditor: inline displaysettingspage.ui
...
Change-Id: Ifb57a37d7ecc5a7b30ef495c6beec762a2df00be
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-27 09:47:48 +00:00
58c5b126d3
Utils: Settle on lowerSnakeCase for LayoutBuilder::Setter
...
Change-Id: Icfe487d8c7712cc8ad28f0f61e8ae4778a356fc3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-27 08:40:12 +00:00
5b72ecbff7
CompilationDatabaseProjectManager: Fix cached state being unhandled
...
In this code, database file is being hashed and if hash stays the same,
parser quickly returns ParseResult::Cached. But as database never gets
read, source tree isn't being built, thus dbContents() never gets called
I moved ParseGuard::markAsSuccess() call to the finish() method of parser,
so we tell ProjectExplorer that parsing finished successfully on Cached state
Change-Id: I7ea28017e653ac6e2d7f50047c09a6eb7ecda13f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io >
2022-07-26 20:29:39 +00:00
86b8f68f78
clangd: make --limit-results configurable in Preferences
...
The default value is the clangd default value: 100.
Fixes: QTCREATORBUG-27152
Change-Id: Icb6c67645b33325da591cb360c17b3dd55fc60ad
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-26 17:28:23 +00:00
44f1fd6498
Drop Qt5: Cpp/TextEditor: Get rid of QOverload
...
Change-Id: I010f211b40f876c0f033fd717aaa094f775ea214
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-26 16:58:45 +00:00
ebd0dd6ebc
Drop Qt5: Manual tests: Remove code below Qt 6.0.0
...
Change-Id: I87e267415ec84001ff594b3900ce8be4f0cadd73
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-26 16:52:02 +00:00
6266a7c118
TextEditor: Fix build
...
bool -> Utils::Layouting::WithoutMargins
Change-Id: Ie7262829455803e8a69370c891669aaa2f3e59f1
Reviewed-by: hjk <hjk@qt.io >
2022-07-26 14:07:42 +00:00
0082db664a
QmlDesigner: Fix enumeration
...
Change-Id: I22b24037354dbe8af8f79e841de0f6b512b668be
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io >
2022-07-26 14:02:35 +00:00
ec1dfa14d6
TextEditor: inline colorschemeedit.ui
...
Change-Id: I8a0d129fca74940eeb28860a0b69476f2b459e22
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-26 13:49:17 +00:00
568f83d964
Core: Inline filepropertiesdialog.ui
...
Change-Id: I256da32d9023886aecd2389a70c57b8572c46819
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
2022-07-26 13:20:09 +00:00
b97c495d2b
Utils: Make the second parameter to LayoutBuilder::attach() an enum
...
More explicit and more potential options (e.g. "treat grid as form")
than a bool.
Change-Id: I89413efe30410160c38b0e524ba64288dde2332e
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-26 11:52:16 +00:00
2f7b86dab3
Utils: Explain FilePath uses a bit
...
Change-Id: Ia7589c7e2b8440547dcc3db9251c37cd01eeced3
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-26 11:42:38 +00:00
b883a096ff
Help: Some cleanup
...
Change-Id: Ic6af45fda6c7fec57cf6c663a9d8f253e3851f15
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io >
2022-07-26 11:40:03 +00:00
db3cd00232
Drop Qt5: Remove porting.h
...
Checked also plugins in tqtc-qtc-super and in qtc-super.
Change-Id: I3e5b114a49e26ae52b71c11ef6a1f90264dd5a38
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-26 11:18:58 +00:00
f6b37328c7
AutotoolsBuildSystem: Avoid using sender()
...
According to the old explanation inside makefileParsingFinished()
the solution of using sender() can't work reliably in this
case. In scenarion where the old, deleted m_makefileParserThread
had the same address as newly allocated one we might not detect
correctly posted finished() signal of the deleted object.
According to QObject::sender() documentation:
"The pointer returned by this function becomes invalid if the
sender is destroyed", so we can't rely on its value.
Instead, add a new done() signal to the MakefileParserThread,
which is being emitted from MakefileParserThread thread (i.e. from
the thread where MakefileParserThread object lives in). In this way
the finished() signal is still posted to the caller's thread,
but this time if the MakefileParserThread object is already
deleted, the finished() signal will be gone together with the
MakefileParserThread object itself, so we also won't receive done()
signal anymore.
Simplify the internals by using std::unique_ptr.
Change-Id: I43be209ecb71539ddefd72e50e9d60bfb43c49cb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-26 11:15:58 +00:00
10da5083fe
Android: Fix warning
...
"warning: lambda capture 'this' is not used"
Change-Id: If4dc702495409954c2948d4964b13c1e075becea
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-26 11:12:37 +00:00
aa2f44b464
ProjectExplorer: Fix crash in SanitizerParser
...
We accessed an invalid iterator.
Change-Id: Ib12eeab81b14e5a0a9542161341ea00ac2d1eb0d
Reviewed-by: hjk <hjk@qt.io >
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
2022-07-26 11:11:14 +00:00
4a95f693fb
Utils: Tiny simplification in LayoutBuilder::Group implementation
...
Originally we needed the real type of the widget for a while.
Not anymore.
Change-Id: Ida7e3eb4b091baee90d510c5f6ec05bbcedfc11f
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-26 09:09:16 +00:00
530043705b
TextEditor: inline tabsettingswidget.ui
...
Change-Id: I9afe5978df1b1313c9d88493dcec9cfe3b7a6af9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-26 09:08:45 +00:00
dc839df59b
Utils: Introduce a Layouting::empty item
...
A bit more explicit than the current mix of Space() and asserting {}.
Change-Id: Ia296b1d23294dfccd1e33827e136b821a4d2c6fe
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-26 09:08:18 +00:00
e9a13d83a4
TextEditor: inline completionsettingspage.ui
...
Change-Id: I41f9b6376b3478a7a6aa0e96ee1165f9aa94d46e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-26 06:52:31 +00:00
c7f59ec188
TextEditor: Inline behaviorsettingswidget.ui
...
Change-Id: I255636d4da8c0282356cfcf307bd6a5a2daaa4fe
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-26 06:46:12 +00:00
8cb867670b
Drop Qt5: Debugger: Remove code below Qt 6.0.0
...
Change-Id: I6ccc87465e7bac13268b426070544ca84e0616b2
Reviewed-by: hjk <hjk@qt.io >
2022-07-25 18:20:39 +00:00
23075ca2f0
TextEditor: inline codestyleselectorwidget.ui
...
Change-Id: Id545fbee532e463fa41cdc4f8dfc2b9bcd807186
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-25 15:49:34 +00:00
4397282fe6
TextEditor: inline fontsettingspage.ui
...
Change-Id: I6bcfa9135ad66146850b0500c6d35889ab5c5df7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-25 15:11:12 +00:00
7499984f11
CodeStyleSelectorWidget: Use Utils::Guard
...
Change-Id: I2b5b99537137dfea4fa21aa167ded04255580b6e
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-25 14:41:25 +00:00
fd84986973
iOS: inline iossettingswidget.ui
...
Change-Id: Ibed7608fa23fb147a8049a5701b233b3b802f894
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-25 14:29:29 +00:00
b3b9ac8ab7
ActionManager: Avoid using sender()
...
Change-Id: I48e298ec6b1a44d865dbc813d86cf0ae7b3d7bef
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-25 14:11:47 +00:00
efb8812e71
tests: Add conan manual test
...
This way one could easily test the CMake auto-setup package
manager with a conan setup.
Change-Id: I4d8e7ab0b5cf84caf95d454358e1409658bd689a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
2022-07-25 14:04:25 +00:00
3daec60eb3
Drop Qt5: CorePlugin: Remove code below Qt 6.0.0
...
Change-Id: Ib00643f43ae1dfa42ae7ce6b4275fd50dd572765
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-25 13:57:57 +00:00
756f1ddafc
LibraryDetailsController: Use Utils::Guard
...
Change-Id: I6c31f14e9de641f56cf632895b4b96df27e63cf2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-25 13:53:03 +00:00
c78ecfe186
Drop Qt5: QtSingleApplication: Remove code below Qt 6.0.0
...
Change-Id: I3821f291ccd8cf55361dc92345e239bd4f2ac3ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-25 13:32:15 +00:00
a6d28c9205
WaitForStopDialog: Avoid using sender()
...
Change-Id: I559d8da00977f776c9d56cb63ea9ee6e72625de0
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-25 13:20:21 +00:00
d96bfdff84
DiffEditorWidgetController: Use Utils::Guard
...
Change-Id: I3d3e22ce26c85859eb8024f2b87c7c85c5ac65f1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io >
Reviewed-by: <github-actions-qt-creator@cristianadam.eu >
2022-07-25 13:02:43 +00:00
256b983d28
iOS: inline createsimulatordialog.ui
...
Change-Id: I40c6269a3d0ba61dfbdcc2ac55f4608b9c893e8c
Reviewed-by: Eike Ziller <eike.ziller@qt.io >
2022-07-25 12:58:09 +00:00
Eike Ziller
Marcus Tillmanns
hjk
Jarek Kobus
Cristian Adam
Artem Sokolovskii
Alibek Omarov
Alessandro Portale
Marco Bubke
Christian Kandeler