Commit Graph

69993 Commits

Author SHA1 Message Date
David Schulz
c1dff744a0 LanguageClient: Increment document version on every content change
Prevents applying results from outdated documents. Specifically
notifications and codeactions for documents that have been cleared on
the contents change handler but get a result before sending the actual
did change notification.

Change-Id: I640088d7cb2464dd4edd832319314bb04eab1df3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-09-07 10:24:43 +00:00
Christian Kandeler
4504570447 ClangCodeModel: Fix access type categorization with clangd
... in "Find References".
This was broken in d6acd21fc0.

Change-Id: I0a185a8440bd5260b7cc18a87cefb450be71e77f
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-07 10:06:06 +00:00
Leena Miettinen
9168110572 Doc: Fix link to next page
Change-Id: I991c80f6e282061aa05a8a456a6d995b124276b7
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
2021-09-07 09:45:12 +00:00
Cristian Adam
05c3f965e3 auto-setup.cmake: warn if conan or vpkg executables are missing
Warn the user if the package manager auto-setup doesn't find conan
or vcpkg executables and does nothing.

Some projects will fail, or in the case of Qt modules, will continue
working by using the system cmake packages.

Change-Id: If3b07e619c27a4b637a894690bd248ad98d6dda2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-09-07 09:35:29 +00:00
Johanna Vanhatapio
43c5558653 Doc: Describe the Morph Target Component
Task-number: QDS-4888
Change-Id: I091490e2649e4aae34cd9c5f929b38b8b9e10792
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2021-09-07 09:19:10 +00:00
Leena Miettinen
f3d6f7542c Doc: Fix the QDS Manual front page
- Create missing top level topics for Inplementing Applications and
  Developer Topics
- Update Advanced Designer Topics and Help topics
- Fix links to next and previous pages
- Fix TOC and front page (hide missing topics and remove NEW markers)

Fixes: QDS-4503
Change-Id: If4ab683bf4628de73c0b37e2c0c69859e1e99f13
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
2021-09-07 09:12:05 +00:00
Christian Kandeler
03c8db5513 Core: Fix warnings about unsused parameters
Amends e203581956.

Change-Id: Ia1ca257f43849bc0e96200c2980f23587ef73734
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-09-07 09:11:49 +00:00
Cristian Adam
e08928e4f7 auto-setup.cmake: Better handling of conan edgecases
Do not try to run the conan executable if conan executable is
not found.

If the conan auto-setup fails warn about it and provide the message
how to skip the auto-setup configuration and do not fail due to the
missing conan_paths.cmake file.

Also print a status message that informs the user that the package
manager auto-setup is performed, with the information how to skip
the step.

Task-number: QTCREATORBUG-25680
Fixes: QTCREATORBUG-25891
Fixes: QTCREATORBUG-25818
Change-Id: I0969ba9b417448f89efd22d7c361e3a54e552ed1
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Alp Öz <aoz@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-09-07 08:52:36 +00:00
Eike Ziller
95de5c93b1 QmlJS: Fix issues with getting modulePaths
This patch

- improves performance by removing the usage of QRegularExpression for
trivial string operations (this is called 3000 times after configuring
Qt Creator)

- fixes handling of version number like "2.-1" which are the result of
imports with only a major version number like "import QtQuick 2"

Task-number: QTCREATORBUG-25899
Fixes: QTCREATORBUG-26178
Fixes: QTCREATORBUG-26216
Change-Id: Ic792909513f4fe25ac72043645f297ee41890375
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2021-09-07 08:16:48 +00:00
Christian Stenger
481070d808 AutoTest: Fix test tools handling for project settings
Fixes restoring project settings with enabled test tools but
having globally disabled these.
We need to take the real active state for test tools into
account not only the global one.
Kind of enhances b99d7623f3.

Change-Id: I29c8cc4fff7c82140da41d3c85823d5980c96d9f
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-07 08:06:03 +00:00
Christian Stenger
87784a2e01 WebAssembly: Fix test expectation
Amends cd2e164b7d.

Change-Id: I41d2e68aea45c1b4f18f93d5103a6fd560b06c68
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-09-07 08:05:54 +00:00
Leena Miettinen
93857c279c Doc: Update example docs
- Update screenshots to show the new Properties view
- Update UI text
- Add links to term definitions and topics the describe views
- Add notes about limited support for 2D effects on Qt 6

Task-number: QDS-4561
Change-Id: I0e4a94cafd968f31aae6e540cd636e03dc300cc6
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-07 06:26:46 +00:00
Eike Ziller
af9408d9ae macOS: Fix creation of disk image with universal builds
Our universal Qt Creator build can be larger than 1 GB.
Increase maximum size of disk image.

Change-Id: I055e891f7da8e3c9db99a7b4b2d703cca594c22a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-09-07 06:25:45 +00:00
Thomas Hartmann
442907bc13 QmlDesigner: Use Qt::Key_Backspace instaed of QKeySequence::Backspace
Task-number: QDS-5011
Change-Id: If3e0719389e47110b8885ab709568a8daaf0ec1d
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-09-06 18:37:42 +00:00
Leena Miettinen
35d1acf457 Doc: Fix changed UI text in docs
- Settings is now Actions
- Origin and Rotation were moved to Geometry - 2D

Change-Id: I03dc91a202ef5c90e03011b8983abbe6b3d919a9
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-06 13:35:39 +00:00
Henning Gruendl
6d3248e669 QmlDesigner: Fix color dialog removing property
Fix color dialog removing color property after rejecting the dialog when
color is binding.

Task-number: QDS-4826
Change-Id: I4cae3b70b18a0131ac555d5b8502d05de5409070
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-06 12:46:29 +00:00
Thomas Hartmann
1393aa8505 QmlProject: Open the first .ui.qml file in QDS
Open the first .ui.qml file of a .qmlproject to not
confuse users.

Task-number: QDS-4986
Change-Id: I56c77c2101fd549cb7b96ea7d273bb4f5234693a
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-09-06 11:57:53 +00:00
Johanna Vanhatapio
1a3da3a06d Doc: Describe Instancing Components
New components in the QtQuick3D module:
- Instancing (FileInstancing QML Type)
- Instancing List
- Instancing List Entry

Task-number: QDS-4888
Change-Id: Iadf3bd75aee8fad3444681bd07eb1c26ddb7b554
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2021-09-06 11:09:51 +00:00
Eike Ziller
f3418d8661 QMake: Fix that qmake was run on every build on macOS
The commit a71d725e46 which fixed issues
on ARM Macs also removed logic for CONFIG+=<arch> arguments to qmake,
which was removed from qmake in Qt 5.6 (since PPC and 32bit Macs are no
longer supported or relevant, qbase f58e95f098c8d78a5f2db7729606126fe093cbdf).

The commit only removed part of the logic though, leading to the
Makefile parser and the qmake step disagreeing on the architecture of
the last qmake run, leading to the qmake step being executed again.

Remove the whole architecture detection and matching logic from
everywhere, which only did anything meaningful on macOS, and is not
needed there anymore either.

Fixes: QTCREATORBUG-26212
Change-Id: Ib60ebca1143296194454a63992ab90a97fdb56b6
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-09-06 10:10:32 +00:00
Miikka Heikkinen
8004909f79 QmlDesigner: Fix crash on asset library refresh
Asset library refresh will crash if done while there is a modal dialog
open, so postpone it a bit in that case. The timer used for this
will also reduce unnecessary refreshes, improving overall performance.

Change-Id: Ib2ff29f5f79428c6543a20f611c708ba80e88ded
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-09-06 08:12:43 +00:00
Assam Boudjelthia
c7061af61f Android: don't throw error on adb's "All files should be loaded." log
When installing a signed apk, adb might throw the following log
"All files should be loaded. Notifying the device." which is being
treated as an error and will stop the deployment from going forward
until user input is given. The current condition is not catching it
probably because it has a \n at the end, but let's treat it as a
warning.

Change-Id: If071730b39871b4e60f8755d14ba352b86e7c244
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-09-06 07:04:27 +00:00
Assam Boudjelthia
bf3dae64a2 Android: fix toolchain path retrieval for NDK r10
Although, recent Qt versions (Qt 5.12+) don't really need r10, this
can be useful if an older version is used, or if the user wants to
explicitly use Ndk r10.

Change-Id: Ic88929a747bcea89384a7bae9d8f8b26135fae65
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-09-03 17:06:02 +00:00
Henning Gruendl
7b688bfd12 QmlDesigner: Fix binding loop issue in UrlChooser
Task-number: QDS-4886
Change-Id: I3c57fc94d22bfb326409eeaf90b6e62d20b91418
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-03 15:45:50 +00:00
Henning Gruendl
30765917ea QmlDesigner: Fix CheckBox global hover
Change-Id: I69bf92c189002bc507693cb388822c322ae94d3c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-03 15:45:29 +00:00
Cristian Adam
e203581956 Core: Remove 'dllimport' attribute warning
By having the function body in the class we automatically get the
same inline functionality and get rid of the warnings below on LLVM
Clang 13.

src/plugins\coreplugin/find/ifindsupport.h:71:27: warning:
 'Core::IFindSupport::highlightAll' redeclared inline; 'dllimport'
 attribute ignored [-Wignored-attributes]

Change-Id: I0daa6412678090f45bdfb6401157cb68bcb0241f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-09-03 12:34:55 +00:00
Jarek Kobus
ebae255e49 Fix a possible crash when reaping a process with callbacks
It may happen that CMakeProcess destructor puts its internal
process into the reaper. After this, when the CMakeProcess
is already destructed, the internal process may still be working.
Since we have set the StdErrLineCallback lambda for the process
which accesses the private m_parser field, it may potentially
crash.

Solve it in a general way, so that whenever we put a process
to the reaper we reset its callbacks.

In addition, disconnect all the slots connected to process'
signals.

Fixes: QTCREATORBUG-26220
Change-Id: I63ea0e0ed6a62ef97ac695572f18014458489c5c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-09-03 10:05:34 +00:00
Miikka Heikkinen
4772253d9d QmlDesigner: Fix used imports not being in sync with model content
Figuring out the used imports checks all model nodes, which means
model needs to be updated before used imports are determined.
Fixed by moving setupUsedImports() call after model sync.

Fixes: QDS-4985
Change-Id: I3f03055d36cb638bcfcd48dc973dbae3af7d8002
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-03 09:50:58 +00:00
Artem Sokolovskii
83e926f1cd CppEditor: Fix space issue for auto generated Q_PROPERTY
Change-Id: I3744ecfc18c7291666f346ea7b047ee749672e05
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-09-03 08:37:25 +00:00
Thomas Hartmann
d7994871b6 QmlJS: Prepend "My" to default component name
Task-number: QDS-3313
Change-Id: I1bd9944a63333d38c9fd77801ef63d7d55787878
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-09-03 08:31:26 +00:00
Thomas Hartmann
5e464155d9 QmlDesigner: Remove "layer.enabled" when deleting effect
Task-number: QDS-3802
Change-Id: Ieb0e839e006c43be8f62318ffec06044eedefd78
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-09-03 08:31:20 +00:00
Christian Stenger
b99d7623f3 AutoTest: Fix synchronizing test tools
It is wrong to query the global active state when
adding test tools known to be active.

Change-Id: I89ab292e1a71b43757e6308fa4b4c584d62fe28b
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-03 07:13:23 +00:00
Christian Stenger
e76f83aa90 AutoTest: Silence deprecation warning
When using Qt5.11+ we run into some deprecation warning
for the logging handling on Windows.
Silence this by specifying the new environment variable
as well which is checked first.

Change-Id: I1ca2b826de4516c606b260d053b949b5761c8414
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-03 07:13:18 +00:00
Christian Stenger
368a6614f3 AutoTest: Fix getting more output from ctest on Windows
When running ctest with Qt based tests we missed output coming
from qtestlib.
Due to running a separate QProcess we need to force the output
on stderr to be printed not via the Windows debug console.

Change-Id: Ie3b957230836efd59f11b6a1e7ac310fa44fa073
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-03 07:13:12 +00:00
Artem Sokolovskii
17c6fb866c CppEditor: Add property name to the generated signal
Task-number: QTCREATORBUG-26184
Change-Id: I4689dfb8b74de154092b7916188159432a5c827d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-09-02 14:02:38 +00:00
Christian Stenger
d59f0f1051 AutoTest: Do not unnecessarily update QmlJS code model
We forgot to update the timestamp indicators which lead to several
triggered updates e.g. when modifying and storing a qml file inside
a watched directory.

Change-Id: I30858ea9e8073d648a84c7f188dff18ddef5b1c1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-02 08:43:11 +00:00
David Schulz
dc40af5fa5 Clangd: fix opening document with client for project
Using LanguageClientManager::openDocumentWithClient function to assign a
document to a specific server. This function also takes care of
deactivating the document for the old client and opens it if necessary
in the new client.

Fixes: QTCREATORBUG-26205
Change-Id: I3c3a5fbcd3d07c2e492ebffdf7870e4d2cb517d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-09-02 08:20:39 +00:00
Cristian Adam
27f0dd134f CMakePM: Do not treat generated files as project files
This would trigger an infinite loop.

Fixes: QTCREATORBUG-26207
Fixes: QTCREATORBUG-26204
Fixes: QTCREATORBUG-25346
Fixes: QTCREATORBUG-25995
Fixes: QTCREATORBUG-25183
Fixes: QTCREATORBUG-25512
Change-Id: Iaf081a00dcf318a0ec2708e839e0ab6535e0ef4d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-09-02 08:04:17 +00:00
Eike Ziller
1030715abc Do not try to deploy qbs-qmltypes, it's gone
Change-Id: I5cfe8c2e7e4e3aff6aad66d1979304522529cbf4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-09-02 07:40:17 +00:00
Christian Kandeler
22823b2190 ClangCodeModel: Add debug output to soft assert
I saw this getting triggered recently, and would like to see more
information if it happens again.

Change-Id: I1c616b8126b8b5eea3709a97124968e9e706aaf3
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-09-02 07:06:30 +00:00
Alessandro Portale
cd2e164b7d WebAssembly: Append EMSDK_PYTHON to environment PATH
The wrapper scripts of emscripten 1.39.8 (required version for Qt 5.15)
do not actively use the python interpreter which -at least on Windows-
is found under EMSDK_PYTHON.

This change appends the parent path of EMSDK_PYTHON to the environment's
PATH to make wrapper scripts (e.g. emcc.bat) work.

Fixes: QTCREATORBUG-26199
Change-Id: Icbc89f6d930f1c5ac5e4e6ac919383cfdd1b913b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-09-01 16:34:24 +00:00
Leena Miettinen
8db873a8c3 Doc: Add recommendation for optimizing large asset files
Building apps with large asset files added to .qrc files
requires huge amounts of memory, so they should be avoided
or included as external binary resources.

Fixes: QDS-4943
Change-Id: I8e4b3630b0543a33547c3477145adf3b2f47b758
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-01 14:18:33 +00:00
Leena Miettinen
b02b2b3da8 Doc: Update info about creating components from scratch
The name of the wizard template has changed in QDS and there
is now a Qt Quick UI File option.

Remove an obsolete screenshot and update the one that shows
a custom dial.

Task-number: QDS-4561
Change-Id: I189297b6dac949d32e013fe2401eb620642f662d
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-01 14:18:18 +00:00
Cristian Adam
830aeb8010 CompilationDatabasePM: Fix crash at loading project
If rootPath is empty, QtCreator will crash.

Fixes: QTCREATORBUG-26126
Change-Id: Iac0d29d84d7203c0ec2ac8f5e3035816f52d7cdc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-09-01 13:33:03 +00:00
Henning Gruendl
04c36419f7 QmlDesigner: Fix ColorEditor
* Change the look of the picker cross
* Cleanup custom RGB, HSL, HSV and Alpha value storage and handling
* Fix issue of alpha not updating when selecting gradient stops
* Fix initial color not shown correctly
* Fix ComboBox warning about parameter injection
* Add checkerboard image to GradientLine
* Remove GradientPopupIndicator
* Add signals to RealSpinBox in order to react to user interaction
* Cleanup code
* Change how porperty editor value emits value if old and new color are
  equal

Task-number: QDS-4755
Change-Id: I1a8095664fc8ed53c52659ac20557c03b89704c9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-09-01 13:20:36 +00:00
Leena Miettinen
74bfae6a4a Doc: Describe selecting Qt version when creating projects
- Describe the "Custom screen width" and "Custom screen height"
  fields.
- Format wizard template descriptions as tables instead of lists.
- Add and update screenshots.

Fixes: QDS-4889
Change-Id: Ib2db26355d08565c04c60ad52192fcf8561e8f65
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-01 11:22:52 +00:00
Leena Miettinen
7c71f37130 Doc: Indicate which 2D effects are available in Qt 6
Fix field names that were changed in the Properties view.

Task-number: QDS-4561
Change-Id: Ib0190ae50ba127be0667d4a4a649bd5d6cd88882
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-09-01 10:51:11 +00:00
Thomas Hartmann
913d034e52 QmlDesigner: Never instantiate controls from component
This will break the file selectors for styles.

Change-Id: Ie539f768eb277fb4dc0df3eceb736ff9e4353837
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-08-31 20:23:01 +00:00
Mahmoud Badri
c8d1f32e76 QmlDesigner: Improve Welcome screen scollbar
- scroll bar only visible when needed
- change color when active
- remove useless stuff
- remove 3 warnings

Change-Id: I0fbab4ca574c060f85adb0d5b6b54381337a7eae
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-08-31 16:58:05 +00:00
Leena Miettinen
40217517b8 Doc: Update docs about Logic Helper properties
Update screenshots and GIF animations.

Task-number: QDS-4561
Change-Id: I52a41709b21cfb4ba00e07706046501c18a0800b
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-08-31 12:07:28 +00:00
Miikka Heikkinen
b6aaa5dfd2 QmlDesigner: Fix root item size on new project launch
Resizing the window doesn't actually trigger rerendering of the
root item image in single item rendering, so we ensure that happens
by making root item size dirty.

Fixes: QDS-4957
Change-Id: I08750c855458cc309a2683e56557c42dc7c49274
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-08-31 11:25:13 +00:00