Importing 3D assets doesn't need to create Qt5NodeInstanceClientProxy,
so skip that in puppet initialization as it may lead to misinterpreting
some command line parameters given to the puppet.
Fixes: QDS-13123
Change-Id: Ifa6601dfa7da1a613b2c897a287a7baeb07dd712
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This patch replaces the blind traversing in the project root to find
and parse the additional qmlproject files which are used by MCU
projects. Instead it's now using the qmlProjectModules() function to
reliably get the valid ones for the MCU projects.
Task-number: QDS-13068
Change-Id: I4e5e1791714345b69c0b2ac7929ae39c30521224
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Recursion for possible imports was interrupted when an incompatible
folder was detected, even though that folder could have compatible
subfolders.
Fixes: QDS-13067
Change-Id: I61f0ac6265e922c515dcd380a481434a1ddfcc93
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
QStringView is easily convertable to std::u16string_view, because data()
is returning QChar* and not char16_t*.
Change-Id: I4dcdceca0c1ee82ea02494d8a45e9ab3011e4dcb
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We use in blog entries 4.6, not 4.6.0. That makes the matching easier.
Change-Id: Ib22433a5a2b7b8c7757f6a59a77c6a9438e26e69
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reparenting or removing composed effect nodes requires recursive update
of the old parent to ensure all children of the old parent are rendered
correctly without the effect.
If the new parent of composed effect node has Image children, they can
in some situations randomly lose their textures in 2D view.
It seems that the only way to fix this issue is to toggle the
visibility of the affected node or its ancestor off and on, so we do
that to the new parent item when reparenting composed effects.
Fixes: QDS-11688
Change-Id: I003d3976d619f24164938846d9b4a15201bf7b59
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
walCheckpointFull() is writing back the log which is not
critical and should not crash the application
Change-Id: Ie01cc9be35de30dc9b89bcb00e9cd4358887c3b2
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Also small renames to add clarity.
Fixes: QDS-12998
Change-Id: I1b38fa501bcc606f13675a98c5543709d15ac615
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Properly set bundle id and path based on node type.
Change-Id: I9710b09789ebe33a3dbe9bb2f112fead53486278
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This initial reparenting to root doesn't seem to have a purpose as any
valid instance will be reparented to its actual parent later anyway.
Since it does break composed effects parent handling, it was removed.
Fixes: QDS-12022
Change-Id: I08993424b5c3ece739809375c11d0a2cd0e3498c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Also a small rename (remove '3D' as it can work for 2D in the future)
Change-Id: I72332f8b46fae6bf8e8e70fc21329ec1e80df047
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Fix the responsive layout in the property editor by adding the
remaining space when control and label max width is reached to the label
width in order to make long labels more readable.
Task-number: QDS-12243
Change-Id: Ib46f4d5e2ae7b48708ec790889180e6aeb932602
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Also remove methods not used anymore and make addLibMaterial() as close
as possible to addLib3DItem() in preparation to unifying them.
Change-Id: I4b0bbf3667c8203fd71a5440aee02d62a67673ca
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Made list a bit wider so that there will be no horizontal scroll on the
list. Also shortened the size info label text a bit so it won't cut off
as easily on systems with larger default font.
Fixes: QDS-13015
Change-Id: I39c175be42e743b0700079ddd5543a9c54bb975b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The way we resolve implicit imports creates random issues.
QtQuick3D.MaterialEditor implicitly imports QtQuick3D.
If QtQuick3D.MaterialEditor is scanned before QtQuick3D the types
of QtQuick3D are added to QtQuick3D.MaterialEditor and when later
QtQuick3D is scanned no type is added to QtQuick3D because of the cache
in ::createObjectsForImport.
The result is that QtQuick3D does not contain its types and prototypes
cannot be resolved. This does happen roughly 50% of the time and
is the reported issue.
In case QtQuick3D is scanned, first things work, but no "extra types" types are added to QtQuick3D.MaterialEditor.
To keep the patch minimal we simply skip this specific case.
QtQuick importing QtQml implicitly is not touched.
Task-number: QDS-11069
Change-Id: I74088b12a2e737a8a7467068c10a78c4be2a7bda
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Add AppStream data and desktop file for Design Studio.
Change-Id: Icc5cca03a3c0945a2f90b39fdd4c7dcecd0e8d6b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
...when the available space is less than full item height.
Fixes: QDS-13014
Change-Id: Iad848547c0736e335173a4feb489a0546f01e147
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Copy the added item's QML file to a temp directory and generate from
there. Also, fix that generated icons not appearing immediately by
separating the model refresh from the addItem(), ensuring the
refresh occurs after the icon is generated.
Change-Id: Ic4f32677b3c2f3895b7825aef7727ac6dd6240b2
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Fix an implicitly defined onFoo properties in Connections are deprecated
warning in the color editor.
Change-Id: I6b1eb0e997a8ec20bafad663c49506ebb6955eee
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
from https://en.cppreference.com/w/cpp/compiler_support/20
ranges support:
The One Ranges Proposal: Clang 13 (partial) 15*
For snapshots we use still Clang 12 (will be changed in near future),
but also QtCreator still supports that old compilers.
The gitlab CI uses much newer compiler versions.
Maybe we also add a check, if the compiler is too old,
do not compile QmlDesigner plugin.
Change-Id: I4d3281739a957546237f47f53fe8f523f4768978
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Add category classes for the model to make it tidier and easy to
extend (i.e. adding more categories).
Change-Id: Ied8641802f600c5cb0b036aba6ad44dbde612a09
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
We have very often the following pattern.
bool isKeyword(const QString &token)
{
static const QStringList keywords = {"if", "then", "else", ...};
return keywords.contains(token);
}
Instead we could remove the the allocation and give the compiler
the opportunity to transform the code. constexpr makes that prossible.
bool isKeyword(QStringView token)
{
static constexpr QStringView keywords[] = {u"if", u"then", u"else",
...};
return Utils::contains(keywords, token);
}
Change-Id: Ic25aa676085bf4bfc6e9ff3194813ff019bd40af
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Adjust FOV orientation depending on width and height of the rendered
viewport to ensure rendered scene stays within the viewport.
Change-Id: I83ed2b547e3bdaeb106dd938b94c72c0b2b8c2e5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The shared memory is allocated based on the key, so if every icon
is sent with same key, they will use the same shared memory. If QDS
side doesn't read the image before the next image is written into the
shared memory, QDS side will get wrong image if all images use same
key.
Fixes: QDS-13013
Change-Id: Ie8188520a76ca057a5b0f0927a7726652609fa35
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If preview generation crashes for some reason, the puppet cleanup needs
to be done asynchronously instead of directly in the callback function,
as callback is triggered from cleaned up instances.
Also add an error text to the canvas where the preview should be shown
if it can't be generated due to crash.
Fixes: QDS-13012
Change-Id: I6196e5b395b056f6b3033ea4da3a0101ef8ea48f
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Change from Document to Persitent auxiliary data type.
Change-Id: Ibaeae5985f49370292f102ccd76c8f1a77199891
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* Forward the auxiliary property formeditorColorProperty to the states
editor delegate
* Add functionality to enabled/disable certain colors in the form editor
canvas background combo box
* Disable context image property in the combo box when it isn't set
* When context image is set as the canvas background make the states
background transparent
* Fix Item as root being rendered with white background in
Qt5NodeInstanceServer::grabRenderControl
Task-number: QDS-12914
Change-Id: Ie2850986f4a54c6e03f33527d8308d01ba16884e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
and collect functions to identify images,
assets and resources in one spot.
Fixes: QDS-12839
Change-Id: I510673b0756dc1e580d753f54831b4c23224056b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
RewriterView does not own m_textModifier, so it needs to be checked.
Especially if it is called by a timer like in the amendQmlText() case.
With m_textToModelMerger, its a different story because its
an owned unique_ptr. So no need to check it.
Pick-to: qds/4.5
Change-Id: If19b58cc94ec5e8ddd68a8c12acba0f880cbdc6b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Added information about the new features and reorganized a bit.
Fixes: QDS-12818
Change-Id: I53049eb5959d1af36e83ef6f2ab8ebe2acff876a
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
