This avoids running into a soft assert and is basically the
common pattern used when shutting down the client.
Change-Id: I9a2eea8d2ffe51f81d6bb78353606ef492628897
Reviewed-by: David Schulz <david.schulz@qt.io>
Otherwise we might end up starting a second language server
when opening options page of Language Client plugin and
closing again with 'Ok' without modifying any setting.
Change-Id: I2b16436b92a0d622dc7df1b5fbdaf9f9f8e717a2
Reviewed-by: David Schulz <david.schulz@qt.io>
Instead, set the default level of all logs to QtWarningMsg.
The call to setFilterRules overrides the user preferences in qtlogging.ini.
Change-Id: Id5f6cd550d14ff7f45ae04c5d3110e0bafb0f072
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: hjk <hjk@qt.io>
m_branchView->indexAt(point) returned another model index
[column 1] than m_model->currentBranch() [column 0], if the
context menu was requested in thesecond (date/time) column.
The failed comparison then gave a lot of invalid actions
(like merge) for the current branch.
Change-Id: Icefc084c81f9b573cd151460db793d3c5a01eb2b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
index.isValid() is already checked in line 165,
so it does not need to be checked afterwards
because it is always true there.
isLeaf is only used once, so join the assignment.
Change-Id: I5f21486fd440b82d8e99be1248adf023da664c1e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Code "QStaticStringData<1> sd;" ends up as "QStaticStringData<4>"
when read by LLDB. GDB is fine.
Change-Id: Ieef8d4a4c267d6e0bb45c96f8dc9c05a79b66381
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Needs some hint that floats are involved.
Change-Id: Ie6871ce3b6bb7aaff27e6c763a6002a6d0a90d70
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Remove limitations for debugging on Android versions that are no longer
supported.
Task-number: QTCREATORBUG-21255
Change-Id: I9d36638b9b2c47485b4aa47d0c563e6c153271e5
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
The section levels should have been elevated, when the info was
moved into a separate topic.
Change-Id: I1b1592773356320f32758cac331611d73aed6106
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
It's a subset to thesymbols collecter so we try to share some code.
Change-Id: I058eee39289453e205f039b3850c1816f1d8ec1a
Task-number: QTCREATORBUG-21257
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This fixes the following error, when using LLVM 6.0.0:
cc1plus: error: -Werror=unguarded-availability-new: no option -Wunguarded-availability-new
Task-number: QTCREATORBUG-18398
Change-Id: I243e6165cd624440eb0f376594b2f802c5c909bb
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
It provides no real additional value and seems to
be more confusing when Qt Creator gets started with
command line options that load disabled or disable
enabled plugins.
Change-Id: I979f9ee95154af11aedd6100717043adc5e1e7a9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Otherwise we have a race condition. The breakpoints may be hit before
they are set.
Change-Id: Iccdd64758b150acdfadc18cba88abdf841feb6c7
Fixes: QTCREATORBUG-21253
Reviewed-by: hjk <hjk@qt.io>
... and keep just a copy of it in the model. This way we
can easily reset the setting model content to a preedit state
without rereading it from the user settings file.
Change-Id: Id2f094caade7c56eff48fd9abce00d687e607a39
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The default caused strange bugs because it was expected that no color was
set.
Task-number: QTCREATORBUG-21282
Change-Id: I3b520b944ffcb87838ba3e7b02e1d28b0f757679
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The second function overload must also return 1-based column.
Change-Id: I1d3a58c9267e4a8c8a031c72230f963596a7bb2b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
vimdiff requires a terminal, which is not supported in Qt Creator.
Fixes: QTCREATORBUG-21147
Change-Id: I6168ac9c4a03061a64a1699fca6f39c90df5168b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This reverts commit 179d8dce73.
It causes random crashes caused by different QProcesses so revert
until we find a solution for that.
Change-Id: Id42f996f54aa5926191f02f9b881ba72eb94689e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
The enum name has to be an identifier. For the example in the referenced
report it was a destructor, which violated invariants in the lookup
code.
Fixes: QTCREATORBUG-20952
Change-Id: Ib8c9c23d6e001368c11c6a4b80c4295559786823
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Git Blame has an additional widget, which is added before the refresh
button, but it still appeared after it.
It looks like insertAction was left there for historical reasons. Replacing
it with addAction doesn't affect the widgets positions, and they're still
placed before the line/column widget.
Change-Id: Id6b658b5c3c8a8bb256e03e13536865f007d41bf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
For the indexing we need all tool chain macros. Originally it was a fix
because the C++ version of the project part and __cplusplus could be
different but now they should be the same. They will be now removed in the
compiler options builder.
Change-Id: I7ae8721a29632473e76ecedb411a6c9001e5e199
Task-number: QTCREATORBUG-21265
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
It can be slow when many files are replaced.
Change-Id: I308698ef36973374f4526107fbda0d9ad907e707
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
If the line has multiple occurrences of the search pattern, all occurrences
got the same capture groups.
For example, text:
Foo(1); Foo(2);
Search for Foo\((.)\) and replace with \1, the result was:
1; 1
Change-Id: Idd4dc21397d5331b1e31a2860eca39d9bc407437
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The flags are only preserved in history if they are updated via
Find::updateFindCompletion. This was called for the find toolbar, but not
for Find in Files.
Change-Id: I16666cc854aed043bfe01175964a4c415020557c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Amends aed2c2c716
After checking which actions are enabled we may not trigger the menus'
aboutToShow anymore, since this can completely rebuild the menu
including recreating the actions. We also don't have to, since this
moved to before checking which actions are enabled.
Change-Id: I1108edce0818f71080b2926a1121c45de38672e1
Reviewed-by: David Schulz <david.schulz@qt.io>
DebugView app can't view error channel therefore logging
output from clangbackend is not visible. Merging both
channels solves the issue.
Change-Id: Iadfd97e3ec8c48afddd880647d9c3fe1c707e241
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
...to fix running into unknown __cplusplus values from compilers with
incomplete language support.
This amends
Toolchains: Detect unspecified language version
commit 5900766ecb
Change-Id: I88cca71ae66cc5d49b644e88658aaa5806862fba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
