Commit Graph

57165 Commits

Author SHA1 Message Date
Nikolai Kosjar
4cd527f496 ProjectExplorer/MSVC: Ignore warning options when looking for predefined macros
...since they should not have any effect on the macros. This potentially
also reduces the cache.

Change-Id: If50cfa50ce0fb29dff291bf2c329532fc6284644
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-10-10 06:49:19 +00:00
Nikolai Kosjar
feae30d7ad ProjectExplorer/MSVC: Cache more predefined macros
...as for the gcc toolchain. Do not cache only the "last" predefined
macros, but cache them all.

Change-Id: I404955e7419089bb03f7d354488f8b9980e8583b
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-10-10 06:49:13 +00:00
Nikolai Kosjar
eb01565c99 TextEditor: Make "Annotation Settings" link smaller
...in annotation tooltips.

Change-Id: I67b73773544cfb86a3d11228cc349cf10f024e7e
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-10 06:48:31 +00:00
Tasuku Suzuki
4801348a31 QScxmlcGenerator: Fix typo in the logging category
Change-Id: I2e86e574bca62e7f3af0157a71792cd0f8fb131e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
v4.8.0-beta1
2018-10-09 12:54:47 +00:00
Sergey Belyashov
fd186bed20 Russian translation update
Change-Id: I40965282a75586bb23e6e42b7d82bd8532290820
Reviewed-by: Alexander Volkov <a.volkov@rusbitech.ru>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
2018-10-09 12:47:51 +00:00
Ivan Donchevskii
76fad7aad0 Unittest: Fix compileroptionsbuilder-test paths on Linux
Match paths partially not to construct the whole path.

Change-Id: I397ac930e2d74b8eba98d1b523aabd4ed92f2aee
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-10-09 12:25:14 +00:00
Orgad Shaneh
acd387651e SilverSearcher: Support regexp substitution
Change-Id: I42cde61fdd052882ae84ae27466a9e79a1782398
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
2018-10-09 09:17:54 +00:00
Nikolai Kosjar
2a40c215e9 CppTools: Inline ToolChainEvaluator
Change-Id: Ie5579820e4683a5e4d7d73034441d662e017b6a3
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-10-09 08:14:16 +00:00
Nikolai Kosjar
3c5dc450b8 CppTools: Remove enum duplication
Change-Id: I2eb452780c21f8d30034bcfbb3266fc8daa10802
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-10-09 08:14:09 +00:00
Ivan Donchevskii
74fbcd9c63 Clang: Autodetect shipped clang binary as C++ compiler
We do not ship clang++ so it makes sense to detect clang
not only as a C compiler.

Change-Id: I37b95e38f253e6407fa27397815d9bcdbbd4a8e2
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-10-09 07:31:51 +00:00
Orgad Shaneh
c6dcb46357 SilverSearcher: Use nullptr
Change-Id: I6f33a8c4d746f849fd78b2da831f89dc221ddda8
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
2018-10-09 06:30:47 +00:00
Christian Kandeler
a7d502a309 CppTools: Fix clang warnings about old-style casts
Change-Id: I947051dec996e92e4afe178e985374587337c4f0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-08 13:36:03 +00:00
Orgad Shaneh
8760c5024d TextEditor: Support hyperlinks in TextMark tooltip
Change-Id: I3fa4470fb06469286901025c350d636fcdd9410a
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-08 13:28:02 +00:00
Nikolai Kosjar
b1031d25dc ProjectExplorer: Fix build with Qt 5.9
‘qEnvironmentVariable’ was not declared in this scope.

Change-Id: Ibd5922c07a360410e006315459b35b5c45f87a9f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-08 12:55:21 +00:00
Nikolai Kosjar
6aa11eb75e CppTools/ProjectExplorer: Remove enum duplication
... between CppTools::ProjectPart and ProjectExplorer::ToolChain.

Change-Id: I8b448747e454adbed77547460383b8515462cc81
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-10-08 12:34:57 +00:00
Laurent Montel
167f08e2ce Allow to define a environment variable for qtc templates
Now we can load qtc templates from anothers directories.
In kde we start to provide some templates and we need
to be able to specify it.

Change-Id: I373faae7fdc3fa34ac9b3c7c57d69c1a5e4d244e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-10-08 12:33:10 +00:00
Nikolai Kosjar
5900766ecb Toolchains: Detect unspecified language version
We checked the command line from the project manager for "-std=X" and
friends to figure out the language version to use. However, if such a
flag was not provided, we assumed the latest version we support. This
could conflict with the actual version of the compiler and its
predefined macros.

Figure out the version by inspecting __cplusplus/__STDC_VERSION__ in the
predefined macros of the toolchain. The MSVC compiler is an exception to
this, as it does not seem to properly set the value - check for
_MSVC_LANG if possible, otherwise simply assume some versions as before.

While at it, add also support for C17/C18 and the upcoming C++2a.

Task-number: QTCREATORBUG-20884
Task-number: QTCREATORBUG-21188
Change-Id: I464ffcd52d2120c0208275a050e82efda44fae1c
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-10-08 09:07:56 +00:00
Nikolai Kosjar
9192b6b024 Add qbs files for CompilationDatabaseProjectManager
Change-Id: I892abbb7c389e2e075b1637a386e0d089a533d9e
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-10-08 09:07:28 +00:00
Christian Stenger
55c61e59f9 Debugger: Fix wrong check in source path mapping
Change-Id: I4b11795326371c9bc30d42cf2fbf29932639f5d6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-10-08 07:26:56 +00:00
Nikolai Kosjar
c7b65c69b1 qbs: Remove pointless ExtensionSystem dependency from plugins
A QtcPlugin depends on ExtensionSystem, so there is no need to restate
the dependency.

Change-Id: I8e0cb5f94858e912f5ce528ee67b683d4d837c27
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-10-08 05:49:44 +00:00
Andre Hartmann
3177e53804 Git: Add support for github remotes
Github and gitlab uses a different syntax when cloning with ssh:

 git@github.com:qt-creator/qt-creator.git

Support this pattern for remote validatation also.

Change-Id: Ic67f2238b9cdd526e76715c86846542cdb73f503
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-07 15:44:01 +00:00
Andre Hartmann
96f982a016 Git: Check remote port for isValid in GitRemote
Change-Id: Iab922abcde0ac055417467f3c63a31dffa721986
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-07 15:43:39 +00:00
Andre Hartmann
0dfb2938ed Git: Add tests for GitRemote
Change-Id: Ia5e0c482afa7847f5ae8dae1b15d1dabfc908e32
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-07 15:01:10 +00:00
Alessandro Portale
bba2a2521b icons/export.py: Make exporting of additional scale factors easier
This changes export.py in a way that adding a scale factor becomes
easy.

Change-Id: Ib6649be931d36bf21df429fe5dd237b440913743
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-10-05 22:09:20 +00:00
Ivan Donchevskii
3858c7d3b9 Clang: Fix the crash in function overload completion
Check that the completions container is not empty.

Change-Id: I399b8cce42995d758013441d2d3d9f3d8156dc06
Reviewed-by: hjk <hjk@qt.io>
2018-10-05 13:57:09 +00:00
Ivan Donchevskii
66e5d2f492 Clang: Fix C++ method code completion
Clang returns no result type when the virtual method
from the base class is called in the same method override
in the derived class.

This is not a problem for us because it's not a method definition
and therefore it does not require special handling.

Change-Id: I736989165c1f031dc1937c7935e26da8236d9e9e
Reviewed-by: hjk <hjk@qt.io>
2018-10-05 13:57:00 +00:00
Andre Hartmann
c29e483607 GenericProject: fix sorting file list when appending an entry
pos was -1 for a value that should have been appended as
last element to the list. Unfortunately, list->insert
treats -1 as prepending in front of the list, which lead
to incorrectly sorted lists.

The function got broken during the review process of
the introducing commit 758544c058.

Change-Id: I693e4d79b0d493deeac0ea8781d637fe50d008b8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-10-05 13:52:47 +00:00
hjk
36b654567d Debugger: Finalize moving Operate by Instruction to engines
Fixes: QTCREATORBUG-21211
Fixes: QTCREATORBUG-21212
Change-Id: I6c0259052336f2141462157c319abeaec9a1e483
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-05 12:54:44 +00:00
Ivan Donchevskii
e0d7d03720 Clang: Fix ClangFormat build with clang-7
Change-Id: I0859b7aad1a49f8d46ee4b32cc32039cfa0b482b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-10-05 11:08:27 +00:00
hjk
0e84c8892d Debugger: Do not double quote in tooltips
Instead of e.g. 'Interrupt "GDB for "test""' use 'Interrupt GDB for "test"'
for button tooltips.

Change-Id: Ibe08e0007800332696dbc7f298bf5119ea8e5338
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-05 10:52:57 +00:00
BogDan Vatra
5811848a7b Android: Remove old support for gdbserver
Change-Id: I6d2e8abf0baa5606ad3d79cc7f1f57813e8255b1
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2018-10-05 10:37:23 +00:00
Christian Stenger
efc851e01e Debugger: Hide 'Registers' by default
Registers had been not visible before 4.8 except the user
explicitly enables it.

Change-Id: Ie515a59b40a7f3cd3b9e62eca2707d8a76ab4ab1
Reviewed-by: hjk <hjk@qt.io>
2018-10-05 09:10:36 +00:00
hjk
4d2a6db1a8 Debugger: Show something in start action text again
... even if the action is disabled.

Change-Id: I7f5bb0abd73d25650fab4c9dafbe70c772d2cb0e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-05 08:50:07 +00:00
hjk
a743e25d27 Debugger: Use the intented mechanism to update icon on the fat button
Change-Id: I58e40c2d3db23d00d55e5e86c6f4ebc6cbabea90
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-05 08:49:17 +00:00
Ulf Hermann
bc2260ab29 QmlProfiler: Make the tool test more robust
Apparently there is a different message box that commonly pops up while
we are waiting for the attach dialog. Just close it and try again. Also,
stop the timer once we have seen the dialog. Otherwise we might fail on
extra message boxes that pop up afterwards.

Change-Id: I06ae16eb3ad89c9a022ac6fae781f8465425d96f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-05 07:46:32 +00:00
Alessandro Portale
e8f28dbef3 LanguageClient: Add an options icon
Server "can" with speech bubble saying "<>".

Change-Id: I7eca0109aa5917f341f6310c8f175b1833ff9c00
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-10-05 07:42:22 +00:00
Alessandro Portale
0f4782fbca design.creatortheme: Set DarkUserInterface=true
It is a dark theme and should be marked accordingly.

Change-Id: I437a293162f5bff4ac549f08401ed9f7349213eb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-10-05 07:41:58 +00:00
Christian Stenger
3c965f3cb5 Android: Fix compile for gcc5.3
Change-Id: Ic061a4bc55e1924b82cc2ac1fd5c483654de90eb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-05 06:36:05 +00:00
Alessandro Portale
50d1790886 creatoricons.svg: Remove unused icons and adjust outdated ids
Change-Id: I34989912a6e23de91a4ac2fa095c0b7826a4e578
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-10-05 06:31:57 +00:00
BogDan Vatra
25264d9bd9 Fix debugging on Android arm64/x86_64
On Android 64, there is no lib/ symlink anymore, so we need to upload
gdbserver from QtCreator.

Change-Id: Ib6f6d9b623dc61b72dd434ce1b3b409e880bdeaa
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2018-10-04 15:36:35 +00:00
hjk
8f987866b6 Project: Introduce BaseIntegerAspect base using spinboxes
Basically upstreamed/pimpled from VxWorks::BaseNumberValueAspect

Change-Id: I1dbedbbdd55b684fe1bb823e57d4830fb2eb0b0e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-10-04 15:23:26 +00:00
hjk
10262574d4 Debugger: Fix stopping of core file debugging using the fat button
Task-number: QTCREATORBUG-21094
Change-Id: If60f6bea93a583ab27e9e8b17c07402b2ac0854c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-04 14:42:57 +00:00
hjk
2e4e18161b Debugger: Guard against some impossible situations
Change-Id: Ia1fd356b4f8ef71dd3b456a3b28598ff680b9344
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-10-04 12:13:37 +00:00
Ulf Hermann
1bc3103ef2 QmlProfiler: Add more fine grained checks to tool test
The test frequently fails for unknown reasons. Check if we actually see
the attach dialog, or if some other dialog interfers.

Change-Id: Id279b8aa0a822dbdb565fe4105bfcb28ad704e3c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-10-04 10:47:41 +00:00
Ivan Donchevskii
f6e5202b80 CompilerOptionsBuilder unit-tests
Bonus: minor compiler options builder issues fixed.

Change-Id: Ie25f8fad6729339de05f2bf9b614ceac873e2634
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-10-04 10:24:13 +00:00
Andre Hartmann
e79d68dab6 Git: Improve local file detection in GitRemote
* Make sure url has a proper size before accessing
  its elements
* Also check for valid drive letter before ':'

Change-Id: I958cbd492caa8a6ad4a5bf424277d8287f8cf0d4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-10-02 19:42:18 +00:00
hjk
30bd144540 RemoteLinux: Add target information to runconfig name
Was there until 4.6.

Change-Id: I044e9a184a3f495f967bfa6712f1cd5cbe5603d5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-10-02 14:52:50 +00:00
Eike Ziller
049291504d Fix function extraction for nested classes
If the function is added to a class inside a class, these must be
prepended before the inner class name.

Fixes: QTCREATORBUG-7271
Change-Id: I07042cdd4927af3b630c6ab1b5587971754e1199
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-10-02 13:31:48 +00:00
Eike Ziller
7a7898e2c9 Reduce priority of "Convert to Camel Case" refactoring
Otherwise this is too annoying in case the function is called the way it
should be.

Fixes: QTCREATORBUG-8114
Change-Id: I51063a11e7979e24fc9020344aa5ff800b5064a9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-10-02 13:31:02 +00:00
Christian Kandeler
0776659503 Kit config widget: Prevent horizontal scrollbar
...by using Utils::ElidingLabel rather than a plain QLabel in
QbsKitInformation.

Change-Id: I4014ee918f0ea712a2975ffb4638c495fd8e0c71
Fixes: QTCREATORBUG-21102
Reviewed-by: hjk <hjk@qt.io>
2018-10-02 13:19:33 +00:00