feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
68,568 Commits 108 Branches 368 Tags
ac47d51bfb379b8c3b51d832d54a90dba18a518f
Commit Graph

717 Commits

Author SHA1 Message Date
hjk
a710f7f8c0 Analyzer: Move setIfPresent helper function close to the only user 
Change-Id: I8d99fe6438e4d954ad44403ac4a34f7e85a7f021
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
 2013-08-12 13:21:48 +02:00
hjk
5fa7b60b97 Analyzer: Cleanup settings handling 
More flexible, less over-engineered this way.

Change-Id: I3e224a6be85d3a187056d79fd506e8cf6a32c8a9
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
 2013-08-12 12:39:54 +02:00
hjk
e94183ca2f Analyzer: Introduce AnalzyerAction 
This wraps the menu related aspects of an IAnalyzerTool.

Change-Id: I065cb5f269a40af2137f434a7cdf915bd9a76839
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-08-08 17:41:39 +02:00
hjk
84331769f0 Analyzer: Re-introduce ValgrindTool level 
This partially reverts 1fb755bb42. It turns out that this is a better
place to have the valgrind specific startLocal/startRemote logic
shared by the valgrind tools.

Change-Id: I1638b6d7665db81227e0a1a9aeef1ce944449391
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-08 15:51:54 +02:00
hjk
15caea1d26 Analyzer: Handle createProjectSettings outside IAnalyzerTool 
Less indirection.

Change-Id: If702a0a44c1fc96510fd1c5411fda51660dde10b
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-08 15:46:57 +02:00
hjk
91de546680 Analyzer: Flatten AnalyzerManager::addTool 
Add tool/startMode combo one by one.

Change-Id: I1e6cfe98fb1b1291cae6f440105991f3f99f2a6a
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-06 16:15:05 +02:00
hjk
0d2ef9fca2 Analyzer: Inline Setting::registerTool into its only user 
Change-Id: I10f57785bd26a15aef6fe72f26e7bf28a3a8d31f
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-06 16:14:54 +02:00
hjk
d95ae65c62 Analyzer: Use action as handle for tool plus start mode 
Change-Id: I33f99f28fb99c21cc62cda57ec1ba1aa2963b065
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-08-06 16:14:41 +02:00
hjk
51b390cada Analyzer: Remove some explicit uses of Analyzer::StartMode 
Change-Id: I6d28a533d4ee2e93e4b3407e7fdd670c45886708
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-05 17:09:22 +02:00
Aurindam Jana
f8a2698bcd IAnalyzerTool: actionId() is re-implemented in derived classes 
Change-Id: I5a0a485e239eeb33a9d8ad8cfd0f9cc40e1ff6d2
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-08-05 15:43:44 +02:00
hjk
835ef9507b Analyzer: Use the run mode stored in the parameters instead of a copy 
Change-Id: I045622efa22bfcb26f9161556ccbbfb3df08599d
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-05 15:10:47 +02:00
hjk
62af817175 Analyzer: Remove some unused code 
Change-Id: Ifa1468e357cae873df6a34380957100521317471
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-05 09:51:17 +02:00
hjk
b65390904b Analyzer: Slim down AnalyzerManager interface 
Change-Id: Ia6f4ba7a342d3ba2dfbf30511192155daf02a8d6
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-05 09:50:35 +02:00
hjk
1ec636cbd6 Analyzer: Move common startTool implementations to IAnalyzerTool base 
Change-Id: I963cb2d025a10cee75b9a9648531c4daeb1b70aa
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-05 09:50:28 +02:00
hjk
213cb601af Analyzer: Use AnalyzerManager for run control creation 
Less code.

Change-Id: Ic26d291ada7efd05899623738d89c52b4175716c
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-05 09:50:08 +02:00
hjk
baed8a12ff Analyzer: Remove unused AnalyzerStartParameter::toolId member 
Change-Id: I34e713ec1c9de99584ba206cfa1e38cd46e880fc
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-01 13:18:54 +02:00
hjk
cad3b13bbd Analyzer: Remove IAnalyzerTool::canRun 
That's taken care of the run control factories directly now

Change-Id: I1cd7470e78a93459bee878f5e32594e7cf339a91
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-01 12:54:49 +02:00
hjk
3de45d8c55 Analyzer: Merge IAnalyzerEngine and AnalyzerRunControl 
Change-Id: I74edaef59600a44924d2692c1ebc7f98d8581115
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-08-01 10:33:01 +02:00
hjk
1fb755bb42 Analyzer: Remove intermediate "ValgrindTool" inheritance level 
It's an empty shell nowadays.

Change-Id: I661735eccf035b58cc405905a58bd74e787e6abc
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
 2013-08-01 10:32:51 +02:00
hjk
2ba88d1c18 Analyzer: Remove IAnalizerTool::createStartParameters 
That's a needless indirection. The run control factories know pretty
well what kind of start parameters they need.

Change-Id: Ia2d92beb6512cd99254fe22e215950cc67d5d0ed
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-08-01 10:32:24 +02:00
hjk
db2dc342f4 Analyzer: Simplify IAnalyzerEngine interface 
Change-Id: Id5eac0145e04b809bf535087d3bb9a04124c2e87
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-08-01 10:32:13 +02:00
Aurindam Jana
05c6a5724f Revert back copyright headers 
The copyright was changed in
Ic8279755f0188ab53253a62322fcccf1c17b6aaf

Change-Id: If4251d13b6e653d49913d1c50044177491326edc
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-07-30 14:25:45 +02:00
Oswald Buddenhagen
6896546ba5 Merge remote-tracking branch 'origin/2.8' 
Conflicts:
	src/plugins/cpptools/cppmodelmanager.cpp

Change-Id: I0e69dfad951eb81d8008f5ca05e8fb6999ae2c8a
 2013-07-25 13:18:31 +02:00
Aurindam Jana
c57160eda6 Analyzer: Separate out run control factories 
Separating out the run control factories is the initial
step towards separation of run control from QML profiler
engine. The goal is to to make the engine agnostic of
the run control.

Change-Id: Ic8279755f0188ab53253a62322fcccf1c17b6aaf
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-07-23 16:17:21 +02:00
Orgad Shaneh
ad9e7ccab6 Fix coding style for else statements 
Change-Id: I1309db70e98d678e150388c76ce665e988fdf081
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
 2013-07-17 11:11:25 +02:00
hjk
b89afac9d4 Utils: Rename winQPidToPid to qPidToPid 
... and make it a no-op on non-Windows. Saves #ifdefs.

Change-Id: Ie791f7b9f1a425325d0b889e73758c5f7f7e6ad2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
 2013-07-12 09:39:35 +02:00
Friedemann Kleint
80e657b390 Valgrind: Compile on Windows. 
Change-Id: I3afd64b297a15af2e51c7fdd83292b9ca2a1cc1f
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-07-12 08:35:46 +02:00
hjk
fd183531dd Analyzer: Merge Valgrind process classes 
Change-Id: Ic2ef2304fb5524d07858052806124f6b02ca4dcb
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-07-11 17:37:01 +02:00
hjk
34981a8a90 Memcheck: Merge part of local and remote code path 
Change-Id: I683cedbe5fbed6d10b24100c51f77a75f74504a1
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-07-11 17:36:08 +02:00
hjk
46deab8377 Valgrind: Reduce number of function calls 
Change-Id: Ie243f55ee7b632d164ed70062fbfd129de3753b9
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
 2013-07-11 15:23:09 +02:00
Eike Ziller
ab0c3da08f Merge remote-tracking branch 'origin/2.8' 
Conflicts:
	qtcreator.pri
	qtcreator.qbs
	src/plugins/projectexplorer/projectexplorer.cpp

Change-Id: I37e550646f877b50693043894976a693ac22ad5e
 2013-07-11 08:02:41 +02:00
Eike Ziller
cc7c3c9623 Add QTCREATOR_COMPAT_VERSION 
Necessary for keeping compatibility within a minor series.
When bumping versions, the compatVersion now needs to be taken into
account too.

Change-Id: I588947f885480889ff2f58481f72db76e3f1a9f1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
 2013-07-09 15:14:10 +02:00
Eike Ziller
dd43d9908f Rename IDocument::fileName --> filePath 
That is what it actually is, wrt how Qt API calls it.

Change-Id: Ied02055debf6aad75556b0d9d22e8ba2f72be555
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
 2013-07-09 13:51:42 +02:00
hjk
bf34603320 Valgrind: Guard against missing logger 
Change-Id: I2fa2df124b83be12c2156f944d2ecaece9e51eac
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-07-09 13:20:59 +02:00
Daniel Teske
cc7fe5eac6 Project: Simplfy file adding/removing interface 
The filetype is only relevant for Qt4 projects. But even for Qt4 projects
the file type is insufficient to decide where the file should be added.
So remove the file type from the interface and let the projectmanagers
themselves figure out what they want to do.

Also fix
Task-number: QTCREATORBUG-9688

Change-Id: I02f7b1cd2e05efaf76e36fb9af34b109d4482f88
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
 2013-07-08 17:05:04 +02:00
hjk
5addb7c6f2 Valgrind: De-pimpl Valgrind::Internal::CostView 
No need for that in internal classes.

Change-Id: Id2e2783972e068cef9873c248ae54c013b933530
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-06-20 09:33:29 +02:00
hjk
ee8a0b30d9 Valgrind: Use BaseTreeView instead of QTreeView 
Change-Id: Ica796ba3d45b97fb5ed0856acb0860f15d45be56
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-06-20 09:33:09 +02:00
hjk
14a86f0091 Analyzer: De-noise 
Change-Id: I13796142c56621e56ba6142d214e01f6373369bd
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-06-13 17:03:04 +02:00
hjk
809f5f2ac8 Valgrind: Harden against missing devices 
Task-number: QTCREATORBUG-9456
Change-Id: I13b7c5f675a09a612631b97a0d95685872e22e04
Reviewed-by: hjk <hjk121@nokiamail.com>
 2013-06-13 13:33:27 +02:00
Tobias Hunger
cd028ac14f Do not pass a file that we know to be broken to QTextStream 
Change-Id: I1a593af642c70ca7a0654163e7a32d405a1c2aa6
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
 2013-06-05 10:40:56 +02:00
Christian Stenger
0e75e5cb61 Valgrind: Fix compile 
Change-Id: I247ba4ba11fc036d0afaa70d98e89eaf2315b60a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
 2013-06-03 10:44:37 +02:00
Eike Ziller
2125525e77 Move openEditorAt from BaseTextEditorWidget to EditorManager 
More sensible place, gotoLine is a method in IEditor anyhow.

Change-Id: I420a6bf17060c16e6f1a4f45e0bef89379fb6bf8
Reviewed-by: David Schulz <david.schulz@digia.com>
 2013-06-03 09:33:06 +02:00
Tobias Hunger
24ee641543 Fix dependency information according to output of dependency checker 
Change-Id: Ic1259f04f4120b6e495ebb3672f7f360c71cba7f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
 2013-05-22 16:41:39 +02:00
Aurindam Jana
fc194f82e1 Valgrind: Fix IP port detection 
Listen on either IPv4 or IPv6 localhost but not both.

Change-Id: I0fcec59fa1c21346582343ad30a9448e3ee9440f
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
 2013-04-25 09:33:36 +02:00
Aurindam Jana
49f1cd5334 Valgrind: Support both IPv4 and IPv6 
Change-Id: I3e7a7f0d9264c2fccb161e5d2dcf585db4fcd013
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-04-18 14:10:14 +02:00
Aurindam Jana
17a26e008a Valgrind: Query available port 
Use QTcpServer instead of TcpPortsGatherer.

Change-Id: I270a5a9464b2cec48b7e2da2772c8a042bf71d95
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-04-18 12:28:57 +02:00
Aurindam Jana
4e832deb02 Valgrind: Use a port from the device port range 
Change-Id: I046e536dfca0c84dd0dba4901aa316a31d4c4b43
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
 2013-04-17 15:49:09 +02:00
Tobias Hunger
47abeac15b Use EnvironmentAspect to retrieve the environment 
Change-Id: If878e22cc2715d05bb3e65ad908cd4fb5e21b03b
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
 2013-04-11 15:15:08 +02:00
Oswald Buddenhagen
f9f8cd354b auto-generate <dependencyList> in .pluginspec files 
Change-Id: I8bb9b4eb0ae5ed9b283da422be882603ae0e1b49
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
 2013-04-11 12:52:03 +02:00
Christian Kandeler
29a7540c2b Fix qbs build. 
Was broken by commit 533644290f.

Change-Id: I70753cdbfcc21333ab88657d7f0db03fd868f71f
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
 2013-04-10 11:50:33 +02:00