Commit Graph

717 Commits

Author SHA1 Message Date
hjk
953cdb971f TextEditor: More BaseText* -> Text* renamings
*Document* and *Layout* classes, all basetext* files

Change-Id: I1c6e376733a434fcb5c7f19c6210dfa031eeafde
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-09-26 10:12:51 +02:00
hjk
1ba91e3040 ProjectExplorer: Apply static pattern to ProjectExplorerPlugin
Adjust caller sites and surroundings.

Change-Id: I6c3c80e42f35eabedc1f89c8c42cca1025aca12f
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
2014-09-26 08:50:00 +02:00
Francois Ferrand
d33727b67a Remove duplicated arrow from analyzer filter.
The icon already includes the 'down' arrow, thus we need to set the 'noArrow' property to prevent
the theme from drawing a second arrow.

Change-Id: Ia910bcebb68b6faf4cc101685ba71e36069ef057
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-09-23 10:43:43 +02:00
Francois Ferrand
9c1f44e942 [Valgrind] Use standard font for currently selected memcheck entry.
The current item was displayed using the hardcoded "monospace" font, so that the current/system
font and size was not used. We now use start with the same font as the error list, and simply
activate 'fixedPitch'.

Change-Id: Ifcf6f0fc044e47b3a57281f6af2d70b7f1c618e4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-09-12 17:03:44 +02:00
Kai Koehne
e2584f69d4 Replace QLatin1String("x") with QLatin1Char('x') where possible
Change-Id: I2f90c8ae7b5e968b9de882833f8661ab540a9232
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-09-04 14:50:00 +02:00
Eike Ziller
b5b6a46b4e ExtensionSystem: Use Qt 5 plugin metadata instead of .pluginspec files
Change-Id: I2b2c704260c613985a4bda179658ec1f8879e70f
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-09-02 15:11:24 +02:00
Christian Kandeler
1d5091e48f Do not use deprecated Qt functionality.
Replace all* remaining deprecated Qt 4 functions with
their Qt 5 counterparts. This means we no longer need to
define the QT_DISABLE_DEPRECATED_BEFORE macro.
This patch is relatively small because most source-compatible
changes of this kind have been done before.

* The one exception is the QmlDesigner, which uses QWeakPointer
in a deprecated way all over the place.

Change-Id: Id4b839c6685f3b5bdf2b89137f95231758ec53c7
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-08-29 14:10:41 +02:00
Eike Ziller
aa6495a261 ExtensionSystem: Remove Qt4 support
Remove usage of the Q_EXPORT_PLUGIN macros, which do not exist in Qt 5.

Change-Id: I678c3cf10b9c5d5c1b9f252b0ecd1c97dc810a47
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
2014-08-27 08:44:34 +02:00
hjk
6431ab2c79 Use Qt 5's QStringList::join(QChar)
Less typing and less cycles than join(QString) where appropriate

Change-Id: I6ebc0e17e4d7fd9845864dd95b7de4ba4dad6906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-08-25 08:21:14 +02:00
Oswald Buddenhagen
f3a61e8bf7 Merge remote-tracking branch 'origin/3.2'
Conflicts:
	qtcreator.pri
	qtcreator.qbs
	src/plugins/android/androidglobal.h

Change-Id: I3367bf2ea47c088989175dddeed2210294346f4c
2014-08-05 14:24:23 +02:00
hjk
bf5e43be94 TextEditor: Merge ITextEditor and BaseTextEditor
Adjust all callers, de-export BaseTextEditorAnimator

Change-Id: I2329d976c1398e2449844bb480a4d4ed29859506
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-25 13:45:55 +02:00
hjk
b8adc78615 Analyzer: Use a more common default value for the initial dock area
Change-Id: I8449d7e540d715ffc1fbcc46b21a1a4ea7d740ab
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-07-24 10:32:15 +02:00
hjk
7bb3f728ef Analyzer: Set dockwidget title on inner widget first
Will be promoted to dockwidget title by the fancy mainwindow.

Change-Id: Idbb4d2869c254140a241cd5a8f5b75b3ef739692
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-07-24 10:32:06 +02:00
hjk
18dca1e3ac AnalyzerTool: Make runMode and toolMode value members
Change-Id: Iaf89bc399db65e17345effb2e9767692786b5ca8
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
2014-07-23 10:58:57 +02:00
Alessandro Portale
17ce7d4ad5 Replace set[Plain]Text(QString()) with clear()
...where applicable. Shorter, faster, more semantic.

Change-Id: Ifb1cf200f489f62a79e12c761e98a846992744dc
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-07-23 10:57:49 +02:00
hjk
cf8a614419 Merge ITextMark and BaseTextMark
Turns out we don't even need two-phase initialization,
by transparently postponing registration until we get
a non-empty file name, either at constuction, or at
file name change times.

Change-Id: I3e87e47c820066e6707e946fc474ab9c1993e61f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-07-23 10:38:31 +02:00
hjk
29e312f33e Debugger: Save width of manually resized tree view columns
Task-number: QTCREATORBUG-12670
Change-Id: I5c31ffd6d3bb3060e851df56e9d9a80101df9347
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
2014-07-18 09:23:58 +02:00
Orgad Shaneh
e6d85ebb17 Valgrind: Fix error display for shadow build
object() refers to the executable file (the build target), which
doesn't have to be inside the project's directory.

directory() refers to the directory of the frame's source file.

Change-Id: Icf9885d1346acbf42ea904e69d6c8eee4d6a40cb
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-07-14 10:39:41 +02:00
Orgad Shaneh
def9695e42 Fix Qt4 compilation
Change-Id: I59f5e4ceec008adedb6f548502c7c90854c033ab
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-07-06 07:21:48 +02:00
Orgad Shaneh
8a1bb5aeb3 Valgrind: Fix early deletion of process
Change-Id: I4d2606b1a69ae3f071b4fe702cbaf63d102e5e14
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-07-03 10:21:13 +02:00
hjk
48b12fe921 Valgrind: Compile fix for Windows
Change-Id: Id60005f4760746299827fb502f1c0afec71542df
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@digia.com>
2014-06-19 14:23:22 +02:00
Nikita Baryshnikov
12103e0f67 Reinvent deprecated qSort as Utils::sort
Change-Id: I4f6011cc2b6127037249aabc2426a88ad7108ebf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-06-19 14:00:32 +02:00
Nikita Baryshnikov
84e176edab CleanUp usage of QtAlgorithms
Change-Id: I61be20554014f90c2e1313167a3e3c869e26c35e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-06-17 08:19:29 +02:00
Orgad Shaneh
7166f13aa8 Valgrind: Initialize member variable
Change-Id: I0645e53dc010224a04a9bfe3a8eea34d360ac72d
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-06-16 07:46:34 +02:00
Orgad Shaneh
27f08d0ccb Valgrind: Remove redundant local variable
Change-Id: I8660d6ad7ed4453ed5c1e1e7ce5c7f2ca0ccec15
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-06-16 07:46:31 +02:00
Orgad Shaneh
7156183239 Analyzer: Remove unused field
Change-Id: I01ae56abd673e877ed018a336d1e31487f907ca3
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-06-16 07:46:28 +02:00
Orgad Shaneh
23b59a099a Valgrind: Update callgrind_control help text
Change-Id: I01088e55aceb8c973224de40ebe7dccc2587ca2d
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-06-16 07:46:24 +02:00
hjk
8694ad982d Debugger: More column resizing
Turns out setting the column resize mode on the view itself
is counter-productive as it takes away the ability to
manually re-adjust.

So set the mode only temporarily to get the preferred width
than switch back to manually resize mode and use the hint
to set some initial size. Also use the length of the header
label as absolute minimum.

Change-Id: Ic17e31334b23ce6d541f9459cd22be65145046d3
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-06-04 17:16:41 +02:00
Christian Stenger
8f6c5cde95 Valgrind: Fix passing multiple arguments to inferior
Change-Id: Iabed71d294e0d0a8775588da1fa2164ef39df455
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-06-04 11:19:37 +02:00
hjk
54cac66c72 ProgressManager: Handle QFutureInterface by value in addTimedTask
QFutureInterface acts by a shared pointer itself, so use that to
guards against the QFutureInterface object being destroyed while
the timer is running.

This feels awkward as QFutureInterfaceBase::future() is non-const
for unknown reason.

Change-Id: I1d43abe0c27183af2f01cf269e2a94d2fcaba46e
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-05-30 15:46:53 +02:00
Orgad Shaneh
dcf807d712 Valgrind: Pass const vector by reference
Change-Id: I1625d52a6743887db80ed9943a888d094b2d8012
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-20 13:29:19 +02:00
Orgad Shaneh
82aa1380f2 Cleanup whitespace
Mostly trailing whitespace

Change-Id: Ic324d20e8159c9d255895248ce04f25c692daf46
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2014-05-16 14:27:13 +02:00
hjk
5ac261bff2 Valgrind: Use generic timed future for uncertain progress
Change-Id: Idb7f1b1e5a0fcd0351d6c30f5a6dadcbec191898
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-05-13 14:05:58 +02:00
Christian Kandeler
d0b25af07b Valgrind: Remove unused function.
Change-Id: Ia14634a95e8227b65719052482dec9e9fd456877
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-12 13:54:02 +02:00
Christian Kandeler
2538b610c2 Valgrind: Don't use QString::fromLocal8Bit() on remote output.
Instead, assume UTF-8, which is very likely to be correct for a remote
Linux system.

Change-Id: I2976e2d79bf10d4db23f60f2c6c9fddffa58a9b7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-12 10:47:18 +02:00
Orgad Shaneh
60cd217981 Valgrind: Support console applications
Task-number: QTCREATORBUG-7311
Change-Id: I973136076118fd8868c6cb461ad31e107c73566e
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-05-08 17:52:27 +02:00
Christian Kandeler
aa52cfa0e6 Valgrind: Remove dialog asking for IP address.
When running the memcheck tool remotely, it sends its data via a TCP
socket to the development host, so it needs to know that machine's IP
address. The current code gathers all local network addresses and makes
the user choose one of them. However, we can get that information from
the SSH connection, so no user interaction is required.

Change-Id: Ia61decddd5fa1e285ca143605d944d6d9275b3e4
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-08 15:28:06 +02:00
hjk
5bc9461d83 Valgrind: Remove unneeded separate FutureWatcher
Change-Id: I21fde2125a4a5d653fe4209e3452dec59c783d24
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2014-05-08 09:00:42 +02:00
Tobias Hunger
dc61b989ac Project: Use Utils::FileName as return type for projectDirectory(...)
Change-Id: I3ea10aa204b1ea41702edab09884b416cd6d9e06
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
2014-05-06 11:48:10 +02:00
Orgad Shaneh
6eae258df2 Valgrind: Minor cleanup
Change-Id: I8457accbec28773de24d2921530a6c437de0d9ac
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-06 09:16:34 +02:00
Orgad Shaneh
4dfa08c22f Valgrind: Use QString for processOutput signal
Change-Id: I446f1a06b2c00280679dd09cd1818c1dd69c7e11
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-05-05 09:17:19 +02:00
Eike Ziller
0fb641c90e Merge remote-tracking branch 'origin/3.1'
Conflicts:
	qtcreator.pri
	qtcreator.qbs
	src/libs/qmljs/qmljsmodelmanagerinterface.cpp
	src/plugins/qmldesigner/designercore/instances/nodeinstanceserverproxy.cpp

Change-Id: Ie216b715d6f87a6d72d3b8fe3d4e777e561579f9
2014-05-02 10:00:20 +02:00
Christian Kandeler
575259c3c1 Valgrind: Fix "alien binary" filtering for remote analyzing.
The current implementation thinks an executed binary does not belong to
the project if it is not located in the build directory. However, for
remote analyzing, that file is never started from the build directory,
but from the place it was deployed to.

Change-Id: Iaaf473aac1cf90aa2300ab7c36b92008e269690a
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-04-28 14:05:19 +02:00
Christian Kandeler
f0594a0d61 Valgrind: Fix display name for analyzing remote external application.
The current one just adds the string "(Remote)", which is pretty much
guaranteed to trick users into thinking it's the one they must choose
when running remote valgrind. Instead, we must make it clear that it's
for analyzing something other than the current project. Unfortunately,
the string still contains the word "remote" because for some reason,
we don't offer valgrind for local external applications.

Change-Id: I27296851b747437e96dc22dbaf54eaf10dcf4be5
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-04-26 23:21:24 +02:00
Christian Kandeler
90bd5ce6b0 Valgrind: Return correct row count from ErrorListModel.
Inexplicably, the current implementation returns 1 if the error list is
empty, which results in a bogus entry in the view and is sure to confuse
people to the point that they might think the analyzer is not working at
all (I know I did).

Change-Id: I9f5999f859347993b012c408129f18260a8c2bea
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-04-25 09:19:20 +02:00
Christian Kandeler
6a33fb3293 Valgrind: Fix typo in signal-slot connection.
Change-Id: I2e206db3329c61ec2e46d37a93d1a542fe139759
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-04-25 00:05:03 +02:00
Christian Kandeler
d57d24068c Valgrind: Prevent invalid assertion.
Change-Id: I91748fd4ac43e9e00c0859209dbf39d10746b958
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-04-25 00:03:48 +02:00
Benjamin Zeller
0d017e5a5d remotelinux: Add generic Runconfiguration interface
Adds a generic interface (AbstractRemoteLinuxRunConfiguration), so plugins
can ship a custom remote runconfig.

Change-Id: I4ef8e39c4c69224d4e55224c782f3d544f10c945
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
2014-04-10 10:42:50 +02:00
Christian Stenger
c4fa365cbb Valgrind: Fix missing pause icon
Task-number: QTCREATORBUG-11836

Change-Id: Id38cecac418754adf61834ccc343420c31fb4f48
Reviewed-by: hjk <hjk121@nokiamail.com>
2014-03-28 16:56:21 +01:00
Jarek Kobus
96a3fd53e8 Fix tooltips, add lacking dots
Change-Id: Id54a11b6868d5033fd1ecfd6324b7e50b94e305c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
2014-03-13 12:06:27 +01:00