The icon already includes the 'down' arrow, thus we need to set the 'noArrow' property to prevent
the theme from drawing a second arrow.
Change-Id: Ia910bcebb68b6faf4cc101685ba71e36069ef057
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
The current item was displayed using the hardcoded "monospace" font, so that the current/system
font and size was not used. We now use start with the same font as the error list, and simply
activate 'fixedPitch'.
Change-Id: Ifcf6f0fc044e47b3a57281f6af2d70b7f1c618e4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Replace all* remaining deprecated Qt 4 functions with
their Qt 5 counterparts. This means we no longer need to
define the QT_DISABLE_DEPRECATED_BEFORE macro.
This patch is relatively small because most source-compatible
changes of this kind have been done before.
* The one exception is the QmlDesigner, which uses QWeakPointer
in a deprecated way all over the place.
Change-Id: Id4b839c6685f3b5bdf2b89137f95231758ec53c7
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
Remove usage of the Q_EXPORT_PLUGIN macros, which do not exist in Qt 5.
Change-Id: I678c3cf10b9c5d5c1b9f252b0ecd1c97dc810a47
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Less typing and less cycles than join(QString) where appropriate
Change-Id: I6ebc0e17e4d7fd9845864dd95b7de4ba4dad6906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Will be promoted to dockwidget title by the fancy mainwindow.
Change-Id: Idbb4d2869c254140a241cd5a8f5b75b3ef739692
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Turns out we don't even need two-phase initialization,
by transparently postponing registration until we get
a non-empty file name, either at constuction, or at
file name change times.
Change-Id: I3e87e47c820066e6707e946fc474ab9c1993e61f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
object() refers to the executable file (the build target), which
doesn't have to be inside the project's directory.
directory() refers to the directory of the frame's source file.
Change-Id: Icf9885d1346acbf42ea904e69d6c8eee4d6a40cb
Reviewed-by: hjk <hjk121@nokiamail.com>
Turns out setting the column resize mode on the view itself
is counter-productive as it takes away the ability to
manually re-adjust.
So set the mode only temporarily to get the preferred width
than switch back to manually resize mode and use the hint
to set some initial size. Also use the length of the header
label as absolute minimum.
Change-Id: Ic17e31334b23ce6d541f9459cd22be65145046d3
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
QFutureInterface acts by a shared pointer itself, so use that to
guards against the QFutureInterface object being destroyed while
the timer is running.
This feels awkward as QFutureInterfaceBase::future() is non-const
for unknown reason.
Change-Id: I1d43abe0c27183af2f01cf269e2a94d2fcaba46e
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Instead, assume UTF-8, which is very likely to be correct for a remote
Linux system.
Change-Id: I2976e2d79bf10d4db23f60f2c6c9fddffa58a9b7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
When running the memcheck tool remotely, it sends its data via a TCP
socket to the development host, so it needs to know that machine's IP
address. The current code gathers all local network addresses and makes
the user choose one of them. However, we can get that information from
the SSH connection, so no user interaction is required.
Change-Id: Ia61decddd5fa1e285ca143605d944d6d9275b3e4
Reviewed-by: hjk <hjk121@nokiamail.com>
The current implementation thinks an executed binary does not belong to
the project if it is not located in the build directory. However, for
remote analyzing, that file is never started from the build directory,
but from the place it was deployed to.
Change-Id: Iaaf473aac1cf90aa2300ab7c36b92008e269690a
Reviewed-by: hjk <hjk121@nokiamail.com>
The current one just adds the string "(Remote)", which is pretty much
guaranteed to trick users into thinking it's the one they must choose
when running remote valgrind. Instead, we must make it clear that it's
for analyzing something other than the current project. Unfortunately,
the string still contains the word "remote" because for some reason,
we don't offer valgrind for local external applications.
Change-Id: I27296851b747437e96dc22dbaf54eaf10dcf4be5
Reviewed-by: hjk <hjk121@nokiamail.com>
Inexplicably, the current implementation returns 1 if the error list is
empty, which results in a bogus entry in the view and is sure to confuse
people to the point that they might think the analyzer is not working at
all (I know I did).
Change-Id: I9f5999f859347993b012c408129f18260a8c2bea
Reviewed-by: hjk <hjk121@nokiamail.com>
Adds a generic interface (AbstractRemoteLinuxRunConfiguration), so plugins
can ship a custom remote runconfig.
Change-Id: I4ef8e39c4c69224d4e55224c782f3d544f10c945
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>