Quite often, I edit path lists in order to modify the order of entries.
It is nice to do this with via drag and drop in the PathListDialog.
Fixes: QTCREATORBUG-20965
Change-Id: I02492c537de694071822d4f261347acea46b220b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Exporting the full sqlite interface can lead to run-time conflicts with
the system sqlite that Qt's SQL support pulls in.
So re-build the sources for the unit test, as in the qmake build.
Change-Id: I8394b9c0aa4e21704bc84600f40b8f5d706ad66d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
dynamic_cast had issues with casting types over library boundaries, at least on
macOS/Clang, even though the types were exported and it worked on Windows/MSVC.
When we manually load the plugin libraries we must force QLibrary/
QPluginLoader to use RTLD_GLOBAL, so external symbols can be resolved
correctly.
See also the FAQ for GCC https://gcc.gnu.org/faq.html#dso
Task-number: QTCREATORBUG-23773
Change-Id: I0f85161d58ad7da390b9b2a20e15f260b9cac196
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
The summary label must not be able to make the DetailsWidget grow
horizontally.
Task-number: QTCREATORBUG-24136
Change-Id: If71b007c02ad1bbcdd4f2e3bf083dfce24a14787
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Turned out it was easy to overlook and didn't reduce the list of
visible plugins to a degree that makes a difference.
Change-Id: Ib261066b215b66ffb683a87b8592570d895917ac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This is a guinea pig to check whether using u"..." is ok
nowadays.
Change-Id: I402816d8892211e67fb6227cd0441c20c0b33818
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It can easily happen that callers insert indent ranges out of order, and
without sorting the indentation done earlier in the file is not
considered for the later parts, leading to inconsistent results.
Fixes: QTCREATORBUG-18929
Change-Id: Ice2abe92d54446bcdd102c6a1f822262a8533543
Reviewed-by: David Schulz <david.schulz@qt.io>
Code snippet:
void bar(); // call find usages for bar from here
void foo(int bar); // bar from here should not be in results
Add test for member function false positives, that is part of
QTCREATORBUG-2176. That was already fixed before.
Fixes: QTCREATORBUG-2176
Change-Id: I9a079caa83bbaea1edb7ba6aeb151d4d4c77952f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It was already only one id string with two names. Since it is not
an id for the factory but the id of the created run configuration,
settle of runConfigurationId() as accessor.
The factory and id fields in RunConfigurationCreationInfo were
redundant. factory always implies (runconfiguration)id (but not
necessarily the other way round, in theory different factories
are possible for the same runconfiguration type for different
devices). So drop the id field here.
In one case now factory pointers instead of ids are compared, but
this is neutral there as this happens in a context of a fixed Target,
device and project are fixed there, so id and factory are equally
unique.
Change-Id: I859aa91486a2dd4abfc7369540a3322d6ec6260d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Putting static functions into a header file causes warnings in all cpp
files that include the header and don't use the function.
Change-Id: I9147c034092515e486dc6113a1b053f4d8094686
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The default for non-packaging build is OFF.
Fixes: QTCREATORBUG-24128
Change-Id: Id422babe197e215d6cb33807a78ba1ee3aaabb32
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Try to be more paranoid about having several cmake binaries run for the
same project at the same time.
Change-Id: I6ceca456e515c0beeff46e6912d15b2dd87283a2
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Catch test functions defined with function-like macros.
To speed-up semantic analysis, find usages does not expand function-like
macros.
Semantic fails with "expected a function declarator" on such functions
and skips function body.
To avoid that, we create dummy function type specifically for this case
Change-Id: Ie2f2464ee57aa4dc86eed07b8b699458f95c0266
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
- Prevent insertion of keyframes in locked curves.
(QDS-2172 means locking, not pinning)
- Unselect keyframes when the curve moves into locking state.
- Make sure that locked curves are always at the bottom of the z-stack
otherwise they might prevent non-locked keyframes from being selected.
- Use the selection color as background for the whole row of a
treeview-item if it was selected.
- Always paint the locked/pinned/unlocked/unpinned icons in the treeview.
- Fix wrong mouse-hit-test for the locked/pinned icon hover events.
The delegate was sometimes wrongly assuming that the mouse is hovering
over a certain icon
Task-number: QDS-2172
Change-Id: I6caab3f9e8e61e0dc2738eca113d5e1eec420957
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Keep focus in the lower graphicsview when dragging the playhead
Update the timeline and curve editor when a keyframe value has changed
Select the keyframe when right clicking on an unselected one
Task-number: QDS-1417
Task-number: QDS-2129
Task-number: QDS-670
Task-number: QDS-919
Change-Id: Ic37816c03447b7a7deedce360795fa25805df315
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Avoid removing the openssl dir if the selected path already exist
and is not empty, rather just recommend selecting a different path
or empty the provided one.
Fixes: QTCREATORBUG-24173
Change-Id: I1e501b361d4917a59a5720146b11580e79ac32aa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
So we can integrate it deeper into the plugin wizard.
Change-Id: I7f7a9eb8e07d3eeab6a4ecf92161f7d04f5fa5c2
Reviewed-by: David Schulz <david.schulz@qt.io>
FileUtils::copyRecursively has the option to override the copy
operation, and this is e.g. used for asking the user if files already
exist, and to track what is actually copied.
Make that functionality available for re-use.
Change-Id: I16b7eddd32509b06866a1070e45ab58629f9a9be
Reviewed-by: David Schulz <david.schulz@qt.io>
Avoid copying the loop variable on each iteration if a const reference
would suffice.
For QPointers<>, this change only adds a const.
Change-Id: I5abe7d793cd46859a9a4f9304ec1bd41f899d72c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
With CMake 3.17-dev the install step is failing because of the symlink.
Change-Id: I012ce95f5cc61f4b5b9d6a4c48ded0f738b581f1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
(cherry picked from commit f392d13419)
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
- Binding Editor support for Binding Properties View
- Binding Editor support for Dynamic Properties View
- Small fix for Binding Editor comboboxes
Task: QDS-2164
Change-Id: I94da14ea97a16d40c5da0b21ff0e6f315f9e84a4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This helps with resolving QEasingCurve's prototype, which is only
available once QtQml has been loaded.
Task-number: QTCREATORBUG-24142
Change-Id: Icb19491071c195c16c527bd206ffdea6f5806b4e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
