- Add writer interface in order to support the current and the new
project structure in parallel. Using the new one if
qdsVersion is >= 4.5
- Separated templates for the new generator from the old one
- Add file name validity check
- Generate files in the folder src and cmake if they do not exist yet.
Only re-generate files in src/autogen.
- Add action to enable or disable the cmake-generator
- Add function that checks if a resource file is within the
project folder but not part of the project
Change-Id: I3d75dbee1043ed28e6126cf0b2c83994cb70ed45
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Effects are items and we have to use __effect/source and allEffects
to idenfify them and get the correct bounding rectangle.
* For now we use a custom parser to work around issues when editig the model
Change-Id: I78690498c44f8285d3bb6ce78eafcafb9c26b2f1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The joinable thread was under the locked mutex. So the sleep notifier
could not arrive.
Change-Id: I548c89904b09f8dcc02cb7ae0486880f519915d2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Threads are still considered joinable after their execution. So sleeping
thread have to be joinded first. Add test
Fixes: QDS-12308
Change-Id: Ie01588293e3b7ce9fe149d52a25ba03d174cca88
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Add QTC_CHECK for crash
* ActionAreas should not be "garbage" collected if they have no target.
* Initial ActionAreas do not have a target and ActionAreas without target make sense to a user. We do not want to delete them together with the target.
Task-number: QDS-12181
Change-Id: Ie520c47aad990a8ff07fc3346e6772226d334ce5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Color properties set with hex color values display a
color tool tip, but named colors failed for Qt6 while
it was still working with Qt5.
Change-Id: I6457bbdc86dd7f036bc48dc40cfa16cda570b95f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
This reverts commit 16c12f71ff.
Reason for revert: Introduces bugs.
AndroidQtVersion::addToEnvironment() set varying ANDROID_NDK_PLATFORM
values in successive calls. Only after a call of
QtVersion::ensureMkSpecParsed, a consistent value is set.
The symptom could be fixed by adding QtVersion::ensureMkSpecParsed calls
in strategic places (e.g. in the beginning of
AndroidQtVersion::addToEnvironment), but it does not make me confident
that this covers all potential code paths. The change that introduces
the issue is 16c12f71ff and will therefore
be reverted. It may be resurrected in QtC 14, but with much caution.
This issue seems to be specific to qmake. It hardens my impression, that
there are no easy gains to be made in the current state of the Android
plugin. An improvement for one use-case will break another use-case
which may be fixed only after two release cycles. It is Mikado code:
"Only touch if needed and safe".
Change-Id: I6ad860f6af8848a900d9421837a03929f9a57645
Fixes: QTCREATORBUG-30554
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Check if qmlls is enabled before showing tooltips from the QtC's code
model. This way, other hoverhandlers, like the one used for language
servers, have the possibility to show their tooltip.
Task-number: QTCREATORBUG-29826
Change-Id: I5d879c7d4c04a27bc668e8900f54984788b02727
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Use an elapsed timer in the syntax highlighter to periodically return
from the highlight and push a continue highlight to the end of the event
loop.
This allows the user to interact with the editor in between those
batches. If the user modifies the document in between highlighting
batches, the area that still needs a rehighlight is increased if needed.
This also reverts 62ea85ee6a and the
related changes.
Task-number: QTCREATORBUG-28727
Change-Id: I7c394dbdff658330bb72f3b68b9928980947db75
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If the linked project is not the top level project our
path mappings did not work.
Try to get the correct file path by using QC internal
find functionality.
This helps for opening files by activating issues inside
the issues table or when clicking links of the issue
details.
Unfortunately this does not help for the inline
annotations or respective marks.
Change-Id: Ie34e1b20ff8b1b2b37e9f04c1d41bc2a4c33f260
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Avoid having none of the buttons selected which looks
confusing.
Change-Id: I445c4da970c4dfbd8a35228e31092c788d0b5d37
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If the list of projects is long it is hard to get to
the right project.
Make it a bit easier.
Change-Id: Ifb56bda163ea9450831682c4ea4ccc1a2cb8ffd4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Extra margin property is added to effects that can spill outside the
source item. This property specifies the amount of space outside the
item that the effect is allowed to use for rendering.
Fixes: QDS-11607
Change-Id: I36d7392593faa6deb99726eaa02184aa87aa3571
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Replaced old hardcoding of 40px margin for effects with actual
sourceRect of the layer. Also check for effect first before clip, as
that clip doesn't actually affect the clipped item itself,
it only affects the children of the clipped item.
Fixes: QDS-12303
Change-Id: Ia962c74cdefb16ed17bea34f0fc50649256d78fe
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
While refactoring the signal got lost, bring it back.
Change-Id: I6b7d2764a5acc390c189b8d0000adc74ee2a4a9c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Do it even when the network reply fails, but contains
the valid json content.
Fixes: QTCREATORBUG-30536
Change-Id: I97f55ccf6997cd2c9ac6be72d673d9cee1a210de
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The root path was missing for the lite designer.
Change-Id: I4c24667e1e46c9c2443224d8bae183c7b91a616e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
TextEditor for qml files has a preview action nowadays.
Change-Id: I963ef8be8627e14ef56f18bbbc56b9007c5c69d2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The official ConPty API doesn't give the ability to forward "--
resizeQuirk" to "conhost.exe".
Fixing this involved taking parts from the WinConPty
implementation (https://github.com/microsoft/terminal/tree/main/src/
winconpty) and porting them to work inside ptyqt.
Fixes: QTCREATORBUG-30007
Fixes: QTCREATORBUG-30558
Change-Id: I45e81fa167c88a85b44958eade0d85f7680e8075
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This problem has been observed with clangd, but it's probably a good idea to apply the check generally.
Note that in the case of renaming, omitting the filtering can lead to file corruption.
Task-number: QTCREATORBUG-30546
Change-Id: I007edbae2cba5f59e427ab07e183162df9e99367
Reviewed-by: David Schulz <david.schulz@qt.io>
* Move the message into single place
* Improve the warning
Task-number: QDS-12195
Change-Id: I70ca89f39cf04b937336936015b2ccbf7deb98c5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
We changed the default build directory to be in a "build" subdirectory
of the source directory, which should not trigger this warning.
Fixes: QTCREATORBUG-30562
Change-Id: Ie9e6906602844fa08c187b92423839484a1cea92
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
