They are going to be reused in reading / writing
display name and mcus enabled.
Change-Id: I679de8858c37fb8629774d0166a7dbc56e5dab76
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
One missed #ifdef for the project cache.
Task-number: QDS-12253
Change-Id: Ib9fe2ef085d1208c3676fb184cb15899fa89bbde
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
That makes it easier to see what got wrong in the trace. So less
debugging.
Change-Id: I26ec3d6a6f81cbd20871260a2b32123343a20618
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Sometimes we have events without any duration
Change-Id: Iae81585051129b5c6a7983dff5e45161d6b6c389
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We gave now sqlite some hints how to merge the tables. That makes them
much faster. Still it is quite slow but we could introduce a caching
table.
Change-Id: I1f75820a53d648621a82dd719e8d8deb97e8d207
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The value function could stop the optimizer to remove the trace point.
The convert to string function is only called if there is a enabled
trace point.
Change-Id: I6ead32638438438602ac2116ffd353c6ed70b32d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Adding many small strings to a string can have overhead because there
have been checks. A static string simply cannot grow, so that overhead
is removed. It has the drawback that it can overflow but in that case
simply no arguments are shown.
Change-Id: Ia9106b6c49e396453eeb75b28df5a543a28dc8c9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The conversion from Qt.vectorxd was not strict enough
and expressions like Qt.vector2d(7 / Constants.width, 7 / Constants.height)
were read as [7, 7]. Reflection was not handled properly and the [7,7]
was written on selection.
Fixes:
* Avoid reflection
* Improve Qt.vector parsing; Move code to C++
* Handle "real" expression case and show binding indicator
* Fix setting an expression. We allow the binding editor/expression
indicator only on the first component of the vector
Task-number: QDS-12242
Change-Id: I6707bdac860852d96d416adbe911d43fe9128e8a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
It is really hard to debug the project storage because it gets so much
data. With the tracer is should be a little bit easier.
Change-Id: I79d60c6fbc32ba3fd7bdcc78916c1aa48f73e125
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
User feedback was gathered and in part implemented in form of a design
update. Smaller fonts, icons and gaps in the projects/sessions screen
and in the examples tiles.
Change-Id: I69d0d9ae21ba855feceeb77d620aa5b556377808
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This forks code from Qt to fix an issue with JSValue.
We must skip QJSValues when iterating properties
since copying or constructing the QVariant crashes.
Task-number: QDS-12263
Change-Id: I8db701cee94dccd7fe254c9473dc25b87f8a04f8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
According to docs for QLayout::replaceWidget(), the returned item
should be either deleted or inserted somewhere else.
Change-Id: I02da36dd0d3fe7de7fa04747d26ea01620349421
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Make a call to tryToConnect() a yet another task inside the task tree.
Prolong the lifetime of the linux device until the tryToConnect()
running in a separate thread is finished. This fixes a crash
when canceling the test and closing the preferences dialog while
tryToConnect() is still running.
Amends e8ad29d3af
Change-Id: I5aca6c9c3de0792421b9774faf45cd463854265e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
The project manager was passing correctly the system headers, but the
compileroptionsbuilder was ignoring them by having UseSystemHeader::No.
This change makes the project's view to be reflected in clangd's
compile_commands.json.
Fixes: QTCREATORBUG-30474
Change-Id: Ie3b80642e27ada4c8c8725f21e3cfbb2a4051aa0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
`NSApplicationActivateIgnoringOtherApps` is deprecated and doesn't have
any effect any more. Switch this to `NSApplicationActivateAllWindows`
which we actually want when running an application, and remove an
unneeded cast.
Change-Id: I75849533e4b172db577d5484ef12c8ee4df20d59
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The running VcsCommand may leak on shutdown. Make them always
a child of a guard object.
Change-Id: Ie2d07d15cd13f1c08636bb1e9c5face09c6a782d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
- Replace hasNext()/next() with a `bool advance()` method
- Replace QAFE::FileTime with QFile::FileTime, they are identical
- QAFE methods now return std::unique_ptr, which matches reality as call
sites stored the pointers in a std::unique_ptr anyway
FileIteratorWrapper:
State::BaseIteratorEnd is only needed when using hasNext()/next(),
hasNext() changes m_status to State::BaseIteratorEnd, then next() checks
that and changes m_status to State::Ended; this isn't needed with
advance() since it's only one method.
Change-Id: I4414f334715237a2fc13ace6f4733d975e2cfaa3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If an exception is thrown or the program is abortet there is still the
begin of a slice. Because a duration slice is only wirtten at the end we
get no slice.
Change-Id: I8b05e9ae045517a503c2a6f00936b05715b812ca
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
As EventQueueData was derived from EventQueue the order of
initialization was inverted. So we got dangling pointer. Merging
EventQueueData into EventQueue fixes the dangling references.
Change-Id: I3d9cee492304132fa612d6d19324656df597ec99
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The tuple are constructed on the stack, so we cannot hold references to
it.
Change-Id: Ia02bf21516c97eb67eca8fd56e68dbd10878ca9e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
widgetInfo() should be cheap but people make expensive stuff inside the
call. So we should try to avoid to many calls.
Change-Id: I66b0a5431471732dca934fc03efb307e2617fd65
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Pointer to temporaries create dangling pointer. So we have to copy the
tuples. The leafes still only contain references.
Change-Id: I37900be569283324178e223829f913fb4ccba16e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
