I got a crash when clicking "Test" in the configuration of an
already existing ("Local Remote") device that was intentionally
not yet set up with working authorized keys after dismissing the
qtc-askpass dialog. The full reason is unclear, but this here
fixes it for me.
Change-Id: Ie07b89b85576beb59583370191e337fd1219db51
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
If no CMake is found, show an error message (reusing an existing
translated string).
Fixes: QTCREATORBUG-30505
Change-Id: I6e3037ee97dfba21791191483fffab769a451125
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Some styles (e.g. macOS, KDE) disable the hover effect on
QAbstractButton. Setting the Qt::WA_Hover on our own button enforces the
hover effect.
Change-Id: I9f2f22c7e7c869a70ebb0e9032d162bd29e94166
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Qt installations on KDE systems may insert shortcut ampersands into
widgets texts. For self-painted widgets, we need therefore consider
Qt::TextShowMnemonic when retrieving metrics of a text and when drawing
it.
This change addresses the issue for Utils::DetailsButton and
Core::Button. Most likely, there are more places where this needs to be
fixed.
Task-number: QTCREATORBUG-30534
Change-Id: I98ef9bf8c8502d92d3a3884d1588be190934f5bd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If the column is too narrow we may overlap the text of the
column header. Explicitly clear the area before painting the
icon.
Change-Id: If73c1e2cc66c21dd9ffa41710873faa654bf235e
Reviewed-by: hjk <hjk@qt.io>
Limiting starting the container only from main thread is worse than the
potential for data access races. DockerDevice needs a rewrite here.
Change-Id: I485f5253d1f0ba0e7fb40ca7e1ddb37dd615212c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Remove output data from FormatText and rename it into FormatInput.
Use Utils::expected_str<QString> for output data and alias it with
FormatOutput.
Change-Id: I2cf21d73d2e973eeeb4431ae30b56bb5987986f6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Fix the warning:
QFutureWatcher::connect: connecting after calling setFuture()
is likely to produce race.
Amends e8ad29d3af
Change-Id: I834f41bd3b7c51520fb36945d4c09a8eafd2affc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Apparently the reasoning for having it, i.e. make
std::unique_ptr<Utils::MacroExpander> "copyable" is not
valid anymore.
This change also fixes the leak of a MacroExpander
returned by QtVersion::createMacroExpander().
Change-Id: I811ecf2eca8e5ce3a1da267da8290ba89df66db6
Reviewed-by: hjk <hjk@qt.io>
DebuggerProcessFinished in EngineSetupRequested means EngineSetupFailed.
Could be triggered with LLDB "Run as Root" plus <Cancel> in the dialog.
Change-Id: Idbfcaebfc302c7646f9b85275d1d57be17cd0922
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
qt_findAtNxFile does a better job at returing a suited @Nx-image for
"exotic" device pixel ratios. This change fixes for example the active
mode icon when running Qt Creator at 250% ui scaling.
Task-number: QTCREATORBUG-30464
Change-Id: Ia90ba3573fcd4af7941322d7dbc8905fe140192b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Use the actual image dpr for arithmetics rather than the application
dpr.
Fixes: QTCREATORBUG-30464
Change-Id: I52083bcca067282a677a9d0e1b7c62e9c7270c64
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
We have to check if the semantic info is actually valid.
Task-number: QDS-12203
Change-Id: Ia4fa411708f0235de4754ced057fb86dd9a4aa7a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
There are new operator== overloads that are causing this to now be
ambiguous.
qlist.h: In instantiation of ‘qsizetype QtPrivate::indexOf(const QList<T>&, const U&, qsizetype) [with V = QByteArray; U = Utils::SmallStringView; qsizetype = long long int]’:
qlist.h:935:20: error: ambiguous overload for ‘operator==’ (operand types are ‘const QByteArray’ and ‘const Utils::SmallStringView’)
qbytearray.h:520:5: note: candidate: ‘bool operator==(const QByteArray&, const QByteArrayView&)’
smallstringview.h:117:16: note: candidate: ‘constexpr bool Utils::operator==(SmallStringView, SmallStringView)’
Change-Id: I6818d78a57394e37857bfffd17b9ffb5101cdc5c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Setting m_status to BaseIteratorEnd should only be done in hasNext(),
because the latter is always called first, before any other member
function.
Change-Id: Ie55518a850655730fb760226d58c4fb171a7f2e1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Only call setPath() in hasNext(), the latter is called before any other
member method, and setPath() is guarded by a bool to only run a single
time.
Split some code to a helper function, which will be reused when porting
to new QAFEngine API.
Change-Id: Ibda0ede18593a3a20729b31e03e994ad2de126de
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It turns out caching the information is unreliable due to a variety of reasons.
We remove the cache for now as its less dangerous than trying to fix each
use case.
Change-Id: I8238166486a2fb29c101f700af1c8d7e4ad7a172
Reviewed-by: hjk <hjk@qt.io>
It tried to use an existing string, but missed the full stop
Amends 124c62a5a0
Change-Id: Idf66621b714da86be700d4ac18c6df2c7a83a468
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
We want to support more than one back-end in the future.
Task-number: QTCREATORBUG-28116
Change-Id: I72020c94b36072a297e13f44130e5e2482922cd4
Reviewed-by: David Schulz <david.schulz@qt.io>
Do not use the icon of the root function for the artificial "Incoming"
and "Outgoing" items in the call hierarchy. In the case of deprecated
functions this can be a warning icon.
Change-Id: Ib75a66296210d4da24208e98efb527b9af37b793
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Without the export, when compiled on macOS (with clang), the call
"runControl()->aspect<RunAsRootAspect>()" in runcontrol.cpp would
return a nullptr, since ProjectExplorer and libUtils had different
vtables for TypedAspect<bool>.
Task-number: QTCREATORBUG-30516
Change-Id: Ic3cef6545e97f59af2a1138f13762c07d9402e4a
Reviewed-by: hjk <hjk@qt.io>
